[GitHub] [apisix] hf400159 closed pull request #6948: docs: Modify the indentation.

2022-04-26 Thread GitBox
hf400159 closed pull request #6948: docs: Modify the indentation. URL: https://github.com/apache/apisix/pull/6948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [apisix-website] yzeng25 commented on pull request #1059: docs: add technical writers in the author list

2022-04-26 Thread GitBox
yzeng25 commented on PR #1059: URL: https://github.com/apache/apisix-website/pull/1059#issuecomment-1110608713 > > I did not change anything in docusaurus-plugin-content-docs-docs-apisix/current/plugins/mocking.md, so this is likely to be a mistake. > > @yzeng25, This caused by upstr

[GitHub] [apisix] hf400159 opened a new pull request, #6948: docs: Modify the indentation.

2022-04-26 Thread GitBox
hf400159 opened a new pull request, #6948: URL: https://github.com/apache/apisix/pull/6948 ### Description fixed https://github.com/apache/apisix-website/pull/1059#issuecomment-1110583657 Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and t

[GitHub] [apisix] yzeng25 opened a new pull request, #6947: docs: fix description format in mocking doc

2022-04-26 Thread GitBox
yzeng25 opened a new pull request, #6947: URL: https://github.com/apache/apisix/pull/6947 ### Description ## Issue I encountered a "Test and deploy" CI check failure in https://github.com/apache/apisix-website/pull/1059. While preview works as expected, the check faile

[GitHub] [apisix] zhendongcmss commented on pull request #6934: fix(balancer): Use default priority when setting upstream doesn't specify priority

2022-04-26 Thread GitBox
zhendongcmss commented on PR #6934: URL: https://github.com/apache/apisix/pull/6934#issuecomment-1110603735 > I'm curious about the trigger condition because priority is set as a default in the JSON schema. see: > > https://github.com/apache/apisix/blob/e56d23950ff18f7656a605ad80b5c9

[GitHub] [apisix-docker] Chever-John commented on issue #300: Redesign the document architecture of apisix-docker

2022-04-26 Thread GitBox
Chever-John commented on issue #300: URL: https://github.com/apache/apisix-docker/issues/300#issuecomment-1110595852 @navendu-pottekkat Yes, we need to think about our users. And we must insist that this document should be intended for users. Please continue your work with this goal~

[GitHub] [apisix-website] SkyeYoung commented on pull request #1059: docs: add technical writers in the author list

2022-04-26 Thread GitBox
SkyeYoung commented on PR #1059: URL: https://github.com/apache/apisix-website/pull/1059#issuecomment-1110586516 > I did not change anything in docusaurus-plugin-content-docs-docs-apisix/current/plugins/mocking.md, so this is likely to be a mistake. @yzeng25, This caused by upstream

[GitHub] [apisix-website] yzeng25 commented on pull request #1059: docs: add technical writers in the author list

2022-04-26 Thread GitBox
yzeng25 commented on PR #1059: URL: https://github.com/apache/apisix-website/pull/1059#issuecomment-1110583657 While preview works as expected, the check failed for the following reason. ``` Error while parsing Markdown frontmatter. This can happen if you use special characters i

[GitHub] [apisix-website] yzeng25 closed pull request #1060: docs: update authors for tidb doc

2022-04-26 Thread GitBox
yzeng25 closed pull request #1060: docs: update authors for tidb doc URL: https://github.com/apache/apisix-website/pull/1060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix-docker] navendu-pottekkat commented on issue #300: Redesign the document architecture of apisix-docker

2022-04-26 Thread GitBox
navendu-pottekkat commented on issue #300: URL: https://github.com/apache/apisix-docker/issues/300#issuecomment-1110577375 We could also focus on how to use the Docker image/Docker compose file instead of focusing on building the Docker image. Users would likely only care about the Docker i

[GitHub] [apisix-docker] Chever-John commented on issue #300: Redesign the document architecture of apisix-docker

2022-04-26 Thread GitBox
Chever-John commented on issue #300: URL: https://github.com/apache/apisix-docker/issues/300#issuecomment-1110573004 @VioletZhouECE Hi, can you say something about this issue? I'd be happy if you could suggest ways to improve this proposal~ -- This is an automated message from the Apa

[GitHub] [apisix-website] netlify[bot] commented on pull request #1060: docs: update authors for tidb doc

2022-04-26 Thread GitBox
netlify[bot] commented on PR #1060: URL: https://github.com/apache/apisix-website/pull/1060#issuecomment-1110562622 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | 676bfc47

[GitHub] [apisix-website] yzeng25 opened a new pull request, #1060: docs: update authors for tidb doc

2022-04-26 Thread GitBox
yzeng25 opened a new pull request, #1060: URL: https://github.com/apache/apisix-website/pull/1060 Changes: update authors for tidb doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [apisix] navendu-pottekkat commented on pull request #6929: docs: update "Getting started" guide

2022-04-26 Thread GitBox
navendu-pottekkat commented on PR #6929: URL: https://github.com/apache/apisix/pull/6929#issuecomment-1110553151 @Baoyuantop @hf400159 I fixed the second Route creation step after abstracting to Upstream. It is working for me as expected. I'm using an M1 Mac. ```shell ➜ example gi

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #6929: docs: update "Getting started" guide

2022-04-26 Thread GitBox
navendu-pottekkat commented on code in PR #6929: URL: https://github.com/apache/apisix/pull/6929#discussion_r859389759 ## docs/en/latest/getting-started.md: ## @@ -202,25 +221,25 @@ curl "http://127.0.0.1:9080/apisix/admin/routes/1"; -H "X-API-KEY: edd1c9f034335f }' ``` -Th

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #6929: docs: update "Getting started" guide

2022-04-26 Thread GitBox
navendu-pottekkat commented on code in PR #6929: URL: https://github.com/apache/apisix/pull/6929#discussion_r859389107 ## docs/en/latest/getting-started.md: ## @@ -177,15 +198,13 @@ This response indicates that Apache APISIX is running successfully. } ``` -## Step 2: Create

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #986: request help: does ApisixConsumer CR for kubernetes support plugins?

2022-04-26 Thread GitBox
tao12345666333 commented on issue #986: URL: https://github.com/apache/apisix-ingress-controller/issues/986#issuecomment-1110543942 Thanks for your report. It's true that keyauth and basicauth are only implemented in ApisixConsumer now, if you need to use other plugins, such as wolf

[GitHub] [apisix] Horus-K commented on issue #6945: bug: proxy-rewrite cannot modify X-Forwarded-Port

2022-04-26 Thread GitBox
Horus-K commented on issue #6945: URL: https://github.com/apache/apisix/issues/6945#issuecomment-1110532416 This made me have to modify the apisix listening port to 80 443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] hanzhenfang commented on pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
hanzhenfang commented on PR #6736: URL: https://github.com/apache/apisix/pull/6736#issuecomment-1110531231 So happy~😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [apisix-ingress-controller] rjiang-ptm opened a new issue, #986: request help: does ApisixConsumer CR for kubernetes support plugins?

2022-04-26 Thread GitBox
rjiang-ptm opened a new issue, #986: URL: https://github.com/apache/apisix-ingress-controller/issues/986 ### Issue description In Kubernetes, we use CR ApisixConsumer to create a consumer in apisix. However, it seems only support `basicaAuth` and `keyAuth`? Using apisix admin

[GitHub] [apisix-ingress-controller] Horus-K commented on issue #523: request help: 为什么apisix response header 中的location会携带9443端口

2022-04-26 Thread GitBox
Horus-K commented on issue #523: URL: https://github.com/apache/apisix-ingress-controller/issues/523#issuecomment-1110528461 https://github.com/apache/apisix/issues/6945 proxy-rewrite cannot modify X-Forwarded-Port same problem as mine -- This is an automated message from the Apache Gi

[GitHub] [apisix-ingress-controller] Horus-K commented on issue #523: request help: 为什么apisix response header 中的location会携带9443端口

2022-04-26 Thread GitBox
Horus-K commented on issue #523: URL: https://github.com/apache/apisix-ingress-controller/issues/523#issuecomment-1110527993 https://github.com/apache/apisix/issues/6945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] Horus-K opened a new issue, #6945: bug: proxy-rewrite cannot modify X-Forwarded-Port

2022-04-26 Thread GitBox
Horus-K opened a new issue, #6945: URL: https://github.com/apache/apisix/issues/6945 ### Current Behavior clb(80 port)-> apisix(9080 port) --> pod ![image](https://user-images.githubusercontent.com/48319268/165440701-290ae881-1feb-4700-8fba-72cb6b9ded71.png) ![image](https://us

[GitHub] [apisix] overstarry commented on issue #6893: bug: hack in my server look this

2022-04-26 Thread GitBox
overstarry commented on issue #6893: URL: https://github.com/apache/apisix/issues/6893#issuecomment-1110507177 ![image](https://user-images.githubusercontent.com/23260162/165436277-6ba4997d-38a8-4108-a770-88e169a6c769.png) -- This is an automated message from the Apache Git Service. T

[GitHub] [apisix] smile-luobin commented on a diff in pull request #6943: fix(docs): fix bugs in doc of request-validation plugin

2022-04-26 Thread GitBox
smile-luobin commented on code in PR #6943: URL: https://github.com/apache/apisix/pull/6943#discussion_r859348863 ## docs/en/latest/plugins/request-validation.md: ## @@ -55,9 +55,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13

[GitHub] [apisix] smile-luobin commented on a diff in pull request #6943: fix(docs): fix bugs in doc of request-validation plugin

2022-04-26 Thread GitBox
smile-luobin commented on code in PR #6943: URL: https://github.com/apache/apisix/pull/6943#discussion_r859350803 ## docs/en/latest/plugins/request-validation.md: ## @@ -55,9 +55,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13

[GitHub] [apisix] smile-luobin commented on a diff in pull request #6943: fix(docs): fix bugs in doc of request-validation plugin

2022-04-26 Thread GitBox
smile-luobin commented on code in PR #6943: URL: https://github.com/apache/apisix/pull/6943#discussion_r859350803 ## docs/en/latest/plugins/request-validation.md: ## @@ -55,9 +55,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13

[GitHub] [apisix] smile-luobin commented on a diff in pull request #6943: fix(docs): fix bugs in doc of request-validation plugin

2022-04-26 Thread GitBox
smile-luobin commented on code in PR #6943: URL: https://github.com/apache/apisix/pull/6943#discussion_r859350803 ## docs/en/latest/plugins/request-validation.md: ## @@ -55,9 +55,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13

[GitHub] [apisix] smile-luobin commented on a diff in pull request #6943: fix(docs): fix bugs in doc of request-validation plugin

2022-04-26 Thread GitBox
smile-luobin commented on code in PR #6943: URL: https://github.com/apache/apisix/pull/6943#discussion_r859348863 ## docs/en/latest/plugins/request-validation.md: ## @@ -55,9 +55,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13

[GitHub] [apisix] superTruth commented on issue #6944: 无法匹配路由

2022-04-26 Thread GitBox
superTruth commented on issue #6944: URL: https://github.com/apache/apisix/issues/6944#issuecomment-1110499463 已经找到问题了,域名写错一个字,导致没匹配上。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix] superTruth closed issue #6944: 无法匹配路由

2022-04-26 Thread GitBox
superTruth closed issue #6944: 无法匹配路由 URL: https://github.com/apache/apisix/issues/6944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix-website] netlify[bot] commented on pull request #1059: docs: add technical writers in the author list

2022-04-26 Thread GitBox
netlify[bot] commented on PR #1059: URL: https://github.com/apache/apisix-website/pull/1059#issuecomment-1110497863 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | a3c52c10

[GitHub] [apisix-website] yzeng25 opened a new pull request, #1059: docs: add technical writers in the author list

2022-04-26 Thread GitBox
yzeng25 opened a new pull request, #1059: URL: https://github.com/apache/apisix-website/pull/1059 Changes: Add technical writers in the author list for the follow 3 blogs in en-us and zh-cn -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix-python-plugin-runner] Chever-John commented on pull request #51: fix: fix error when forwarding tff files

2022-04-26 Thread GitBox
Chever-John commented on PR #51: URL: https://github.com/apache/apisix-python-plugin-runner/pull/51#issuecomment-1110494499 > Add test cases? Yeah~ I will do it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[apisix] branch master updated: test: reject bad client TLS request in handshake (#6941)

2022-04-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7b4bbba6b test: reject bad client TLS reque

[GitHub] [apisix] spacewander merged pull request #6941: test: reject bad client TLS request in handshake

2022-04-26 Thread GitBox
spacewander merged PR #6941: URL: https://github.com/apache/apisix/pull/6941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] superTruth opened a new issue, #6944: 无法匹配路由

2022-04-26 Thread GitBox
superTruth opened a new issue, #6944: URL: https://github.com/apache/apisix/issues/6944 ### Description 我现在配置了路由,但是路由实际好像无法生效,不太确定是什么原因造成的。我的https证书已经配对是正确了。我用的是docker启动,是需要独立安装过nginx吗? 这个是路由配置把匹配到domain的所有请求都转发到这个upstream: https://user-images.githubusercontent.com/7315362/1

[GitHub] [apisix] JohnnyQianP commented on issue #6936: help request: v2.13.1 there is no public-api plugin when used jwt-auth plugin

2022-04-26 Thread GitBox
JohnnyQianP commented on issue #6936: URL: https://github.com/apache/apisix/issues/6936#issuecomment-1110490399 > ```shell > curl -X PUT 'http://localhost:9080/apisix/admin/routes/r1' -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -d '{ "uri":"/apisix/plugin/jwt/sign", "plugins":{ "pub

[GitHub] [apisix] leslie-tsang commented on issue #6936: help request: v2.13.1 there is no public-api plugin when used jwt-auth plugin

2022-04-26 Thread GitBox
leslie-tsang commented on issue #6936: URL: https://github.com/apache/apisix/issues/6936#issuecomment-1110489740 > > @leslie-tsang, pls help to check. > > @JohnnyQianP, and pls check your `config.yaml`, if overwrite the `plugins` list > > I can see the "plugins" node in config.yaml

[GitHub] [apisix] leslie-tsang commented on issue #6936: help request: v2.13.1 there is no public-api plugin when used jwt-auth plugin

2022-04-26 Thread GitBox
leslie-tsang commented on issue #6936: URL: https://github.com/apache/apisix/issues/6936#issuecomment-1110488331 Hello there, @JohnnyQianP , I had just create test env with followed command, Unfortunately I can't reproduce the issue in my test env. More detailed reproduction steps with conf

[GitHub] [apisix] JohnnyQianP commented on issue #6936: help request: v2.13.1 there is no public-api plugin when used jwt-auth plugin

2022-04-26 Thread GitBox
JohnnyQianP commented on issue #6936: URL: https://github.com/apache/apisix/issues/6936#issuecomment-1110487513 > @leslie-tsang, pls help to check. > > @JohnnyQianP, and pls check your `config.yaml`, if overwrite the `plugins` list I can see the "plugins" node in config.yaml

[GitHub] [apisix-dashboard] Baoyuantop commented on a diff in pull request #2440: fix: advance matching in the route create page causes the page to crash

2022-04-26 Thread GitBox
Baoyuantop commented on code in PR #2440: URL: https://github.com/apache/apisix-dashboard/pull/2440#discussion_r859335773 ## web/cypress/integration/route/can-skip-upstream-when-select-service-id.spec.js: ## @@ -103,12 +112,45 @@ context('Can select service_id skip upstream in r

[GitHub] [apisix] hf400159 commented on a diff in pull request #6943: fix(docs): fix bugs in doc of request-validation plugin

2022-04-26 Thread GitBox
hf400159 commented on code in PR #6943: URL: https://github.com/apache/apisix/pull/6943#discussion_r859335035 ## docs/en/latest/plugins/request-validation.md: ## @@ -55,9 +55,9 @@ curl http://127.0.0.1:9080/apisix/admin/routes/5 -H 'X-API-KEY: edd1c9f034335f13

[GitHub] [apisix-python-plugin-runner] codecov[bot] commented on pull request #51: fix: fix error when forwarding tff files

2022-04-26 Thread GitBox
codecov[bot] commented on PR #51: URL: https://github.com/apache/apisix-python-plugin-runner/pull/51#issuecomment-1110482648 # [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+co

[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on pull request #51: fix: fix error when forwarding tff files

2022-04-26 Thread GitBox
shuaijinchao commented on PR #51: URL: https://github.com/apache/apisix-python-plugin-runner/pull/51#issuecomment-1110482418 Add test cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix-docker] VioletZhouECE commented on issue #300: Redesign the document architecture of apisix-docker

2022-04-26 Thread GitBox
VioletZhouECE commented on issue #300: URL: https://github.com/apache/apisix-docker/issues/300#issuecomment-1110479012 I'd like to work on this issue. Please assign this to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] SylviaBABY commented on pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
SylviaBABY commented on PR #6736: URL: https://github.com/apache/apisix/pull/6736#issuecomment-1110470155 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [apisix] hf400159 commented on pull request #6942: feat(doc): fix FAQ page error link

2022-04-26 Thread GitBox
hf400159 commented on PR #6942: URL: https://github.com/apache/apisix/pull/6942#issuecomment-1110467954 The Chinese version has been corrected. https://github.com/apache/apisix/pull/6736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] smile-luobin opened a new pull request, #6943: fix-docs: fix bugs in doc of request-validation plugin

2022-04-26 Thread GitBox
smile-luobin opened a new pull request, #6943: URL: https://github.com/apache/apisix/pull/6943 Signed-off-by: smile-luobin ### Description fix bugs in doc of request-validation plugin -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] tzssangglass commented on pull request #6934: fix(balancer): Use default priority when setting upstream doesn't specify priority

2022-04-26 Thread GitBox
tzssangglass commented on PR #6934: URL: https://github.com/apache/apisix/pull/6934#issuecomment-1110465905 I'm curious about the trigger condition because priority is set as a default in the JSON schema. see: https://github.com/apache/apisix/blob/e56d23950ff18f7656a605ad80b5c9a2576d3c01

[GitHub] [apisix] jwrookie commented on issue #6940: feat: As a user, I want to only change uri args or headers when hiding credentials

2022-04-26 Thread GitBox
jwrookie commented on issue #6940: URL: https://github.com/apache/apisix/issues/6940#issuecomment-1110464979 Hi, I want to try it, can you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix] branch master updated (13b63b8bd -> e56d23950)

2022-04-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from 13b63b8bd docs: update "Transformation" Plugins (#6891) add e56d23950 chore: the second returned value of n

[GitHub] [apisix] spacewander merged pull request #6910: chore: the second returned value of ngx.thread.wait is execution result but not err

2022-04-26 Thread GitBox
spacewander merged PR #6910: URL: https://github.com/apache/apisix/pull/6910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: docs: update "Transformation" Plugins (#6891)

2022-04-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 13b63b8bd docs: update "Transformation" Plu

[GitHub] [apisix] spacewander merged pull request #6891: docs: update "Transformation" Plugins

2022-04-26 Thread GitBox
spacewander merged PR #6891: URL: https://github.com/apache/apisix/pull/6891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] qlql489 opened a new pull request, #6942: feat(doc): fix FAQ page error link

2022-04-26 Thread GitBox
qlql489 opened a new pull request, #6942: URL: https://github.com/apache/apisix/pull/6942 ### Description fix error link in /docs/en/latest/FAQ.md and /docs/zh/latest/FAQ.md Fixes #6920 ### Checklist - [x] I have explained the need for this PR and the problem it solves

[GitHub] [apisix] hf400159 commented on a diff in pull request #6929: docs: update "Getting started" guide

2022-04-26 Thread GitBox
hf400159 commented on code in PR #6929: URL: https://github.com/apache/apisix/pull/6929#discussion_r859311912 ## docs/en/latest/getting-started.md: ## @@ -177,15 +198,13 @@ This response indicates that Apache APISIX is running successfully. } ``` -## Step 2: Create a Route

[GitHub] [apisix] tzssangglass commented on issue #6936: help request: v2.13.1 there is no public-api plugin when used jwt-auth plugin

2022-04-26 Thread GitBox
tzssangglass commented on issue #6936: URL: https://github.com/apache/apisix/issues/6936#issuecomment-1110448057 @leslie-tsang, pls help to check. @JohnnyQianP, and pls check your `config.yaml`, if overwrite the `plugins` list -- This is an automated message from the Apache Git Ser

[GitHub] [apisix] spacewander commented on pull request #6941: test: reject bad client TLS request in handshake

2022-04-26 Thread GitBox
spacewander commented on PR #6941: URL: https://github.com/apache/apisix/pull/6941#issuecomment-1110448014 Please rerun and merge after https://github.com/api7/apisix-nginx-module/pull/50 is merged. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] Baoyuantop commented on a diff in pull request #6929: docs: update "Getting started" guide

2022-04-26 Thread GitBox
Baoyuantop commented on code in PR #6929: URL: https://github.com/apache/apisix/pull/6929#discussion_r859307112 ## docs/en/latest/getting-started.md: ## @@ -202,25 +221,25 @@ curl "http://127.0.0.1:9080/apisix/admin/routes/1"; -H "X-API-KEY: edd1c9f034335f }' ``` -This conf

[GitHub] [apisix] spacewander opened a new pull request, #6941: test: reject bad client TLS request in handshake

2022-04-26 Thread GitBox
spacewander opened a new pull request, #6941: URL: https://github.com/apache/apisix/pull/6941 Signed-off-by: spacewander ### Description Fixes # (issue) ### Checklist - [x] I have explained the need for this PR and the problem it solves - [ ] I have

[GitHub] [apisix] qihaiyan closed issue #6805: feat: As a user, I want to let a Route to be bound to severial Services, so that a single Route could be able to serve different hosts bounded to differe

2022-04-26 Thread GitBox
qihaiyan closed issue #6805: feat: As a user, I want to let a Route to be bound to severial Services, so that a single Route could be able to serve different hosts bounded to different services URL: https://github.com/apache/apisix/issues/6805 -- This is an automated message from the Apache

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #985: feat:add authorization-annotation the ingress resource

2022-04-26 Thread GitBox
codecov-commenter commented on PR #985: URL: https://github.com/apache/apisix-ingress-controller/pull/985#issuecomment-1110428215 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/985?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=p

[GitHub] [apisix-ingress-controller] tokers commented on a diff in pull request #972: Doc: add 'enable authentication and restriction' document

2022-04-26 Thread GitBox
tokers commented on code in PR #972: URL: https://github.com/apache/apisix-ingress-controller/pull/972#discussion_r852794028 ## docs/en/latest/practices/enable-authentication-and-restriction.md: ## @@ -0,0 +1,342 @@ +--- +title: enable authentication and restriction +--- + + +

[GitHub] [apisix] zhendongcmss commented on pull request #6934: fix(balancer): Use default priority when setting upstream doesn't specify priority

2022-04-26 Thread GitBox
zhendongcmss commented on PR #6934: URL: https://github.com/apache/apisix/pull/6934#issuecomment-1110427760 > hi @zhendongcmss we need test cases to cover this. will update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #985: feat:add authorization-annotation the ingress resource

2022-04-26 Thread GitBox
AlinsRan opened a new pull request, #985: URL: https://github.com/apache/apisix-ingress-controller/pull/985 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ### What this PR does / why we need i

[GitHub] [apisix] spacewander opened a new issue, #6940: feat: As a user, I want to only change uri args or headers when hiding credentials

2022-04-26 Thread GitBox
spacewander opened a new issue, #6940: URL: https://github.com/apache/apisix/issues/6940 ### Description See https://github.com/apache/apisix/blob/dbe7eeebba06229d4a8df75263f2a78301cc1ca0/apisix/plugins/key-auth.lua#L117 Currently, both uri args and headers will be changed. -- T

[apisix-helm-chart] branch master updated: chore: Add namespace for apisix-ingress-controller (#274)

2022-04-26 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new d86b86c chore: Add namespace for api

[GitHub] [apisix-helm-chart] tokers merged pull request #274: chore: Add namespace for apisix-ingress-controller

2022-04-26 Thread GitBox
tokers merged PR #274: URL: https://github.com/apache/apisix-helm-chart/pull/274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [apisix] tokers commented on issue #6935: help request: how to upgrade apisix to the latest version installed via RPM

2022-04-26 Thread GitBox
tokers commented on issue #6935: URL: https://github.com/apache/apisix/issues/6935#issuecomment-1110424621 > In principle, you can update by specifying the latest version. You can try it in the test environment. Use RPM package for `2.13.1`. -- This is an automated message from the

[GitHub] [apisix-website] SkyeYoung commented on pull request #1056: docs: update the Chinese Documentation style guide

2022-04-26 Thread GitBox
SkyeYoung commented on PR #1056: URL: https://github.com/apache/apisix-website/pull/1056#issuecomment-1110422754 > I think the question that yilin mentioned really needs to be considered, but at the same time, the official website still needs a Chinese version "style guide". If the underlyi

[GitHub] [apisix] spacewander opened a new issue, #6939: feat: As a user, I want to check the subordinate relationship in the Admin API

2022-04-26 Thread GitBox
spacewander opened a new issue, #6939: URL: https://github.com/apache/apisix/issues/6939 ### Description See https://github.com/apache/apisix/blob/dbe7eeebba06229d4a8df75263f2a78301cc1ca0/apisix/stream/router/ip_port.lua#L82 We need to check the subordinate relationship in the

[GitHub] [apisix] tokers commented on pull request #6686: feat(plugin-redirect): set redirect server port when enable http_to_https

2022-04-26 Thread GitBox
tokers commented on PR #6686: URL: https://github.com/apache/apisix/pull/6686#issuecomment-1110413092 > Thanks, that really change the rule, but on the other hand, even if we remove this limitation, all configurations set before can still be applied successfully in the new version.

[GitHub] [apisix] angeld287 commented on issue #4095: bug: cors() does not work after modifying

2022-04-26 Thread GitBox
angeld287 commented on issue #4095: URL: https://github.com/apache/apisix/issues/4095#issuecomment-1110035212 In my case the problem was that I addes the mothod `GET` in the Route so the `CORS` continued showing the origin cors error even if i added `GET` in the "allow_methods" cors propert

[GitHub] [apisix] angeld287 commented on issue #5637: request help: the official cors plugin is not effective and universal, here is my improved code

2022-04-26 Thread GitBox
angeld287 commented on issue #5637: URL: https://github.com/apache/apisix/issues/5637#issuecomment-1110033715 In my case the problem was that I addes the mothod GET in the Route so the CORS continued showing the origin cors error even if i added "GET" in the "allow_methods" cors property. S

[GitHub] [apisix] angeld287 commented on issue #6533: request help: Apisix deployed on rancher, but not stable

2022-04-26 Thread GitBox
angeld287 commented on issue #6533: URL: https://github.com/apache/apisix/issues/6533#issuecomment-1110030247 In my case the problem was that I addes the mothod GET in the Route so the CORS continued showing the origin cors error even if i added "GET" in the "allow_methods" cors property. S

[GitHub] [apisix-go-plugin-runner] Chever-John commented on issue #78: request help: Improve the README document.

2022-04-26 Thread GitBox
Chever-John commented on issue #78: URL: https://github.com/apache/apisix-go-plugin-runner/issues/78#issuecomment-1109995475 Hi, we have improved the README document~ #80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] tzssangglass opened a new issue, #6938: request help: does APISIX support Server-sent events protocol?

2022-04-26 Thread GitBox
tzssangglass opened a new issue, #6938: URL: https://github.com/apache/apisix/issues/6938 ### Discussed in https://github.com/apache/apisix/discussions/6930 Originally posted by **lrodriguez14** April 26, 2022 Does Apache Apisix support SSE(Server Sent Events)? -- This is

[GitHub] [apisix] tzssangglass commented on pull request #6934: fix(balancer): Use default priority when setting upstream doesn't specify priority

2022-04-26 Thread GitBox
tzssangglass commented on PR #6934: URL: https://github.com/apache/apisix/pull/6934#issuecomment-1109885097 hi @zhendongcmss we need test cases to cover this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix] tzssangglass commented on issue #6935: help request: how to upgrade apisix to the latest version installed via RPM

2022-04-26 Thread GitBox
tzssangglass commented on issue #6935: URL: https://github.com/apache/apisix/issues/6935#issuecomment-1109869171 In principle, you can update by specifying the latest version. You can try it in the test environment. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] JohnnyQianP opened a new issue, #6936: help request: v2.13.1 there is no public-api plugin when used jwt-auth plugin

2022-04-26 Thread GitBox
JohnnyQianP opened a new issue, #6936: URL: https://github.com/apache/apisix/issues/6936 ### Description ![image](https://user-images.githubusercontent.com/14548092/165303756-21b8edb5-21ac-4ca3-8fc3-064c8049b1c8.png) Port 32253 is the apisix-admin service ``` # curl -X PUT 'h

[GitHub] [apisix] kwanhur commented on pull request #6686: feat(plugin-redirect): set redirect server port when enable http_to_https

2022-04-26 Thread GitBox
kwanhur commented on PR #6686: URL: https://github.com/apache/apisix/pull/6686#issuecomment-1109758203 [test case 21](https://github.com/apache/apisix/blob/master/t/plugin/redirect.t#L487) shows the incompatibility https://github.com/apache/apisix/blob/dbe7eeebba06229d4a8df75263f2a78301

[apisix] branch master updated: docs: update "General" Plugins (#6886)

2022-04-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new dbe7eeebb docs: update "General" Plugins (#

[GitHub] [apisix] spacewander merged pull request #6886: docs: update "General" Plugins

2022-04-26 Thread GitBox
spacewander merged PR #6886: URL: https://github.com/apache/apisix/pull/6886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: chore(stream): there is no reusable api_ctx (#6933)

2022-04-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 68485f3a6 chore(stream): there is no reusab

[GitHub] [apisix] spacewander merged pull request #6933: chore(stream): there is no reusable api_ctx

2022-04-26 Thread GitBox
spacewander merged PR #6933: URL: https://github.com/apache/apisix/pull/6933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #6911: docs: update "Security" docs

2022-04-26 Thread GitBox
navendu-pottekkat commented on code in PR #6911: URL: https://github.com/apache/apisix/pull/6911#discussion_r858644205 ## docs/en/latest/plugins/referer-restriction.md: ## @@ -23,24 +29,27 @@ title: referer-restriction ## Description -The `referer-restriction` can restrict

[GitHub] [apisix] yzeng25 commented on a diff in pull request #6911: docs: update "Security" docs

2022-04-26 Thread GitBox
yzeng25 commented on code in PR #6911: URL: https://github.com/apache/apisix/pull/6911#discussion_r858623219 ## docs/en/latest/plugins/consumer-restriction.md: ## @@ -23,29 +29,36 @@ title: consumer-restriction ## Description -The `consumer-restriction` makes corresponding

[GitHub] [apisix-website] yzeng25 commented on pull request #1056: docs: update the Chinese Documentation style guide

2022-04-26 Thread GitBox
yzeng25 commented on PR #1056: URL: https://github.com/apache/apisix-website/pull/1056#issuecomment-1109702524 > > Another thought: Is it a really urgent thing to do? I see discussions of changing the website from Docusaurus to Hexo or Hugo in June. How much of this article is applicable af

[GitHub] [apisix] navendu-pottekkat commented on a diff in pull request #6929: docs: update "Getting started" guide

2022-04-26 Thread GitBox
navendu-pottekkat commented on code in PR #6929: URL: https://github.com/apache/apisix/pull/6929#discussion_r858593928 ## docs/en/latest/getting-started.md: ## @@ -177,15 +198,13 @@ This response indicates that Apache APISIX is running successfully. } ``` -## Step 2: Create

[GitHub] [apisix] github-actions[bot] commented on issue #4210: request help: Is there a more readable and detailed process for Tengine to replace OpenResty?

2022-04-26 Thread GitBox
github-actions[bot] commented on issue #4210: URL: https://github.com/apache/apisix/issues/4210#issuecomment-1109608909 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simp

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
SylviaBABY commented on code in PR #6736: URL: https://github.com/apache/apisix/pull/6736#discussion_r858486199 ## docs/zh/latest/FAQ.md: ## @@ -21,73 +21,100 @@ title: 常见问题 # --> -## 为什么要做 API 网关?不是已经有其他的开源网关了吗? +## 为什么我们需要一个新的 API 网关?不是已经有其他的开源网关了吗? -微服务领域对 API 网关有新的需求:更

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
SylviaBABY commented on code in PR #6736: URL: https://github.com/apache/apisix/pull/6736#discussion_r858485240 ## docs/zh/latest/FAQ.md: ## @@ -21,73 +21,100 @@ title: 常见问题 # --> -## 为什么要做 API 网关?不是已经有其他的开源网关了吗? +## 为什么我们需要一个新的 API 网关?不是已经有其他的开源网关了吗? -微服务领域对 API 网关有新的需求:更

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
SylviaBABY commented on code in PR #6736: URL: https://github.com/apache/apisix/pull/6736#discussion_r858484879 ## docs/zh/latest/FAQ.md: ## @@ -534,35 +558,38 @@ HTTP/1.1 200 OK } ``` -## 如何解决 `unable to get local issuer certificate` 错误 +## 我应该如何解决 `unable to get local issu

[GitHub] [apisix-helm-chart] m33li5 opened a new pull request, #275: feat: upgrade APISIX dashboard to 2.11.0

2022-04-26 Thread GitBox
m33li5 opened a new pull request, #275: URL: https://github.com/apache/apisix-helm-chart/pull/275 Related issue: https://github.com/apache/apisix-helm-chart/issues/267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] tokers commented on issue #5654: bug: URI encoding issue

2022-04-26 Thread GitBox
tokers commented on issue #5654: URL: https://github.com/apache/apisix/issues/5654#issuecomment-1109554406 > > `<` `>` are not reserved characters so they should be decoded, if you want to reserve `%3C` and `%3E`, encoding them twice before sending requests to APISIX. > > That's to say,

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
SylviaBABY commented on code in PR #6736: URL: https://github.com/apache/apisix/pull/6736#discussion_r858481331 ## docs/zh/latest/FAQ.md: ## @@ -534,35 +558,38 @@ HTTP/1.1 200 OK } ``` -## 如何解决 `unable to get local issuer certificate` 错误 +## 我应该如何解决 `unable to get local issu

[GitHub] [apisix] hf400159 commented on a diff in pull request #6929: docs: update "Getting started" guide

2022-04-26 Thread GitBox
hf400159 commented on code in PR #6929: URL: https://github.com/apache/apisix/pull/6929#discussion_r858477067 ## docs/en/latest/getting-started.md: ## @@ -177,15 +198,13 @@ This response indicates that Apache APISIX is running successfully. } ``` -## Step 2: Create a Route

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
SylviaBABY commented on code in PR #6736: URL: https://github.com/apache/apisix/pull/6736#discussion_r858476871 ## docs/zh/latest/FAQ.md: ## @@ -257,72 +277,72 @@ Apache APISIX 的插件支持热加载。 - 9445 ``` -2.重启抑或 reload APISIX +2. 重启或者重新加载 APISIX。 -## APISIX 利用 etcd 如

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #6736: docs: sync Chinese version FAQ docs

2022-04-26 Thread GitBox
SylviaBABY commented on code in PR #6736: URL: https://github.com/apache/apisix/pull/6736#discussion_r858475435 ## docs/zh/latest/FAQ.md: ## @@ -257,72 +277,72 @@ Apache APISIX 的插件支持热加载。 - 9445 ``` -2.重启抑或 reload APISIX +2. 重启或者重新加载 APISIX。 -## APISIX 利用 etcd 如

  1   2   >