[apisix-website] branch asf-site updated (0bf3024572f -> 92a82229963)

2022-05-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git discard 0bf3024572f deploy: a6ce812037d58165ff071fb9530dbf3342aa40f0 new 92a82229963 deploy: 39b7d1c5bf3744

[apisix-website] branch master updated: feat: added case studies (#1074)

2022-05-08 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 39b7d1c5bf3 feat: added case studies

[GitHub] [apisix-website] juzhiyuan merged pull request #1074: feat: added case studies

2022-05-08 Thread GitBox
juzhiyuan merged PR #1074: URL: https://github.com/apache/apisix-website/pull/1074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[apisix-website] branch feat-add-case-studies updated (cf872a36d96 -> d53bc7a4d5a)

2022-05-08 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-add-case-studies in repository https://gitbox.apache.org/repos/asf/apisix-website.git from cf872a36d96 feat: added case studies add d53bc7a4d5a feat: added case studies No new r

[GitHub] [apisix] spacewander commented on a diff in pull request #6960: feat(xRPC): support log filter

2022-05-08 Thread GitBox
spacewander commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r867668615 ## t/xrpc/apisix/stream/xrpc/protocols/pingpong/init.lua: ## @@ -76,6 +76,12 @@ local function to_int32(p, idx) end +local function init_ctx_fileds(ctx) +--

[GitHub] [apisix] helloxubo closed issue #6992: help request: The apisix log client IP is not a real IP.

2022-05-08 Thread GitBox
helloxubo closed issue #6992: help request: The apisix log client IP is not a real IP. URL: https://github.com/apache/apisix/issues/6992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix] helloxubo closed issue #6990: request help:How to write the Apisix log to ES?

2022-05-08 Thread GitBox
helloxubo closed issue #6990: request help:How to write the Apisix log to ES? URL: https://github.com/apache/apisix/issues/6990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-website] netlify[bot] commented on pull request #1074: feat: added case studies

2022-05-08 Thread GitBox
netlify[bot] commented on PR #1074: URL: https://github.com/apache/apisix-website/pull/1074#issuecomment-1120689765 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | cf872a36

[GitHub] [apisix-website] juzhiyuan opened a new pull request, #1074: feat: added case studies

2022-05-08 Thread GitBox
juzhiyuan opened a new pull request, #1074: URL: https://github.com/apache/apisix-website/pull/1074 **Changes** Put Case Studies in a first-level directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[apisix-website] 01/01: feat: added case studies

2022-05-08 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch feat-add-case-studies in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit cf872a36d96a3da1a10dbb8e1744a7364387c447 Author: juzhiyuan AuthorDate: Mon May 9 14:14:15 2022

[apisix-website] branch feat-add-case-studies created (now cf872a36d96)

2022-05-08 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-add-case-studies in repository https://gitbox.apache.org/repos/asf/apisix-website.git at cf872a36d96 feat: added case studies This branch includes the following new commits:

[GitHub] [apisix] prajith-nair opened a new issue, #7008: bug:

2022-05-08 Thread GitBox
prajith-nair opened a new issue, #7008: URL: https://github.com/apache/apisix/issues/7008 ### Current Behavior **apisix_conf/config.yaml** `# # Licensed to the Apache Software Foundation (ASF) under one or more # contributor license agreements. See the NOTICE file distrib

[GitHub] [apisix] spacewander commented on a diff in pull request #6968: feat: support hook response body for ext-plugin

2022-05-08 Thread GitBox
spacewander commented on code in PR #6968: URL: https://github.com/apache/apisix/pull/6968#discussion_r867643327 ## apisix/plugins/ext-plugin-post-resp.lua: ## @@ -162,7 +162,7 @@ function _M.before_proxy(conf, ctx) if err then core.log.error(err) -return

[apisix] branch master updated: feat(ops): handle real_ip_from CIDR format (#6981)

2022-05-08 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 1b5c1900d feat(ops): handle real_ip_from CI

[GitHub] [apisix] spacewander merged pull request #6981: feat(ops): handle real_ip_from CIDR format

2022-05-08 Thread GitBox
spacewander merged PR #6981: URL: https://github.com/apache/apisix/pull/6981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: feat: upgrade lua-resty-logger-socket to 2.0.1 (#7004)

2022-05-08 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 36c87bc42 feat: upgrade lua-resty-logger-so

[GitHub] [apisix] spacewander merged pull request #7004: feat: upgrade lua-resty-logger-socket to 2.0.1

2022-05-08 Thread GitBox
spacewander merged PR #7004: URL: https://github.com/apache/apisix/pull/7004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander merged pull request #6974: docs: add three Chinese version about Authentication doc

2022-05-08 Thread GitBox
spacewander merged PR #6974: URL: https://github.com/apache/apisix/pull/6974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: docs: add three Chinese version about Authentication doc (#6974)

2022-05-08 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 284feb72f docs: add three Chinese version a

[apisix] branch master updated (0d1280cde -> d74319c2c)

2022-05-08 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from 0d1280cde docs: replace all apisix-openresty to apisix-base (#6998) add d74319c2c docs: upadate Chinese inst

[GitHub] [apisix] spacewander merged pull request #7002: docs: upadate Chinese installation docs

2022-05-08 Thread GitBox
spacewander merged PR #7002: URL: https://github.com/apache/apisix/pull/7002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander commented on pull request #7007: change(opentelemetry): the default network port for OTLP/HTTP is changed to 4318

2022-05-08 Thread GitBox
spacewander commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120656844 > > This port change problem should be covered with test cases > > I think it is not necessary to add test coverage related to the default port, and the success or failure of the

[apisix-website] branch asf-site updated (55fa7e98169 -> 0bf3024572f)

2022-05-08 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git discard 55fa7e98169 deploy: a6ce812037d58165ff071fb9530dbf3342aa40f0 new 0bf3024572f deploy: a6ce812037d581

[GitHub] [apisix-ingress-controller] shendongming commented on issue #1003: bug: plugin_config_name is disappeared

2022-05-08 Thread GitBox
shendongming commented on issue #1003: URL: https://github.com/apache/apisix-ingress-controller/issues/1003#issuecomment-1120613319 apisix helm chart version apisix-0.9.1 docker image: apache/apisix-ingress-controller:1.4.0 -- This is an automated message from the Apache Git Servic

[GitHub] [apisix-ingress-controller] spacewander commented on issue #1004: request help: 关于对wasm的支持

2022-05-08 Thread GitBox
spacewander commented on issue #1004: URL: https://github.com/apache/apisix-ingress-controller/issues/1004#issuecomment-1120612588 Could you rewrite the plugin with `set_root_context`: https://github.com/proxy-wasm/proxy-wasm-rust-sdk/blob/fb7c953adcba19adb79b4e1885cbb532a2fbad22/exa

[GitHub] [apisix] moonming commented on pull request #7007: chore(opentelemetry): the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
moonming commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120603038 > So should this function return an error message? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] soulbird commented on pull request #7007: chore(opentelemetry): the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
soulbird commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120595219 > This port change problem should be covered with test cases I think it is not necessary to add test coverage related to the default port, and the success or failure of the report w

[GitHub] [apisix] soulbird commented on pull request #7007: chore(opentelemetry): the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
soulbird commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120595331 > This port change problem should be covered with test cases I think it is not necessary to add test coverage related to the default port, and the success or failure of the report w

[GitHub] [apisix] tzssangglass commented on a diff in pull request #6960: feat(xRPC): support log filter

2022-05-08 Thread GitBox
tzssangglass commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r867596851 ## apisix/stream/xrpc/runner.lua: ## @@ -70,9 +75,53 @@ local function put_req_ctx(session, ctx) end +local function filter_logger(ctx, logger) +if not logg

[GitHub] [apisix] tzssangglass commented on a diff in pull request #6960: feat(xRPC): support log filter

2022-05-08 Thread GitBox
tzssangglass commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r867596311 ## apisix/stream/xrpc/runner.lua: ## @@ -70,10 +74,54 @@ local function put_req_ctx(session, ctx) end +local function log_filter(session, ctx) +local logger

[GitHub] [apisix] tzssangglass commented on a diff in pull request #6960: feat(xRPC): support log filter

2022-05-08 Thread GitBox
tzssangglass commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r867596226 ## t/xrpc/pingpong2.t: ## @@ -139,3 +151,548 @@ lua tcp socket send timeout: 6 stream lua tcp socket read timeout: 6 --- log_level: debug --- stream_conf_

[GitHub] [apisix-ingress-controller] spacewander commented on issue #1004: request help: 关于对wasm的支持

2022-05-08 Thread GitBox
spacewander commented on issue #1004: URL: https://github.com/apache/apisix-ingress-controller/issues/1004#issuecomment-1120576349 Look like the sdk imports some functions which are not in the [spec](https://github.com/proxy-wasm/spec/tree/master/abi-versions/vNEXT) : https://github.com/pr

[GitHub] [apisix] moonming commented on pull request #7002: docs: upadate Chinese installation docs

2022-05-08 Thread GitBox
moonming commented on PR #7002: URL: https://github.com/apache/apisix/pull/7002#issuecomment-1120560828 > @hf400159 Hi, we can use https://surge.sh/ to publish a preview quickly. 😊 (follow [README Guide](https://github.com/apache/apisix-website#basic), build, then use surge publish)

[GitHub] [apisix] hf400159 commented on pull request #7002: docs: upadate Chinese installation docs

2022-05-08 Thread GitBox
hf400159 commented on PR #7002: URL: https://github.com/apache/apisix/pull/7002#issuecomment-1120558636 ![preview](https://user-images.githubusercontent.com/97138894/167328494-8e9b799f-d097-4376-b61d-76395436c3a1.png) @moonming I have no way to upload to suger because of my network issues

[GitHub] [apisix-ingress-controller] SRCchen commented on issue #1004: request help: 关于对wasm的支持

2022-05-08 Thread GitBox
SRCchen commented on issue #1004: URL: https://github.com/apache/apisix-ingress-controller/issues/1004#issuecomment-1120558391 `proxy_wasm_rust_sdk` version: 0.2 cargo.toml ```toml [package] name = "wasmdemo" version = "0.1.0" edition = "2021" [lib] path = "sr

[GitHub] [apisix] moonming commented on pull request #7007: chore(opentelemetry): the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
moonming commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120557376 This port change problem should be covered with test cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: docs: fix link in certificate management docs (#1007)

2022-05-08 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 795be227 docs: fix link

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #998: docs: Documentation page on certificate management has a broken link to example files

2022-05-08 Thread GitBox
tao12345666333 closed issue #998: docs: Documentation page on certificate management has a broken link to example files URL: https://github.com/apache/apisix-ingress-controller/issues/998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1007: docs: fix link in certificate management docs (#998)

2022-05-08 Thread GitBox
tao12345666333 merged PR #1007: URL: https://github.com/apache/apisix-ingress-controller/pull/1007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [apisix] soulbird commented on pull request #7007: chore(opentelemetry): the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
soulbird commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120551721 > > > > > @soulbird Shall we also update the corresponding test cases? > > > > > Looks like no corresponding test cases need to be updated. > > > > > > > > > Why? No test case

[GitHub] [apisix] moonming commented on pull request #7007: chore(opentelemetry): the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
moonming commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120550537 > > > > @soulbird Shall we also update the corresponding test cases? > > > > Looks like no corresponding test cases need to be updated. > > > > > > Why? No test cases for open

[GitHub] [apisix] soulbird commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
soulbird commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120549098 > > > @soulbird Shall we also update the corresponding test cases? > > > Looks like no corresponding test cases need to be updated. > > Why? No test cases for opentelemetry?

[GitHub] [apisix] soulbird commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
soulbird commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120548785 > opentelemetry In the test cases of opentelemetry, the data is reported to the black hole, and there is no port-related test. Look: https://github.com/apache/apisix/blob/master/t/

[GitHub] [apisix] bzp2010 commented on a diff in pull request #6995: feat: support kafka consumer for pubsub scenario

2022-05-08 Thread GitBox
bzp2010 commented on code in PR #6995: URL: https://github.com/apache/apisix/pull/6995#discussion_r867579674 ## docs/zh/latest/pubsub/kafka.md: ## @@ -0,0 +1,120 @@ +--- +title: Apache Kafka +keywords: + - APISIX + - Pub-Sub + - Kafka +description: This document contains info

[GitHub] [apisix] moonming commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
moonming commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120546546 the title of this PR should add `opentelemetry` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix] moonming commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
moonming commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120545989 > > @soulbird Shall we also update the corresponding test cases? > > Looks like no corresponding test cases need to be updated. Why? No test cases for opentelemetry? --

[GitHub] [apisix] moonming commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
moonming commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120545816 > Why? No test cases for opentelemetry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [apisix] tzssangglass commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
tzssangglass commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120544385 ref: https://github.com/open-telemetry/opentelemetry-specification/pull/1970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] qihaiyan commented on pull request #6949: api-breaker plugin returns default response body

2022-05-08 Thread GitBox
qihaiyan commented on PR #6949: URL: https://github.com/apache/apisix/pull/6949#issuecomment-1120543729 This PR‘s status is ```Changes approved``` current now. Can i still add more commits to this PR to aim at @spacewander 's suggestion? @tzssangglass . > As for this plugin, I would

[GitHub] [apisix] tzssangglass commented on a diff in pull request #6995: feat: support kafka consumer for pubsub scenario

2022-05-08 Thread GitBox
tzssangglass commented on code in PR #6995: URL: https://github.com/apache/apisix/pull/6995#discussion_r867577027 ## docs/zh/latest/pubsub/kafka.md: ## @@ -0,0 +1,120 @@ +--- +title: Apache Kafka +keywords: + - APISIX + - Pub-Sub + - Kafka +description: This document contains

[GitHub] [apisix] nic-chen commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error response

2022-05-08 Thread GitBox
nic-chen commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1120533379 > Thank you team for the quick attention 👍 Updated couple of details, I think `grpc-status-details-bin` is better choice since `grpc-message` is already included Thanks for th

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1007: docs: fix link in certificate management docs (#998)

2022-05-08 Thread GitBox
tao12345666333 commented on PR #1007: URL: https://github.com/apache/apisix-ingress-controller/pull/1007#issuecomment-1120533355 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [apisix] nic-chen commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error response

2022-05-08 Thread GitBox
nic-chen commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1120533149 > @nic-chen can you write a design about this new feature? I'll check it out later. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] soulbird commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
soulbird commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120532356 > @soulbird Shall we also update the corresponding test cases? Looks like no corresponding test cases need to be updated. -- This is an automated message from the Apache Git Service.

[GitHub] [apisix] tokers commented on a diff in pull request #7006: feat(ops): check process running with posix.signal insteadof lsof

2022-05-08 Thread GitBox
tokers commented on code in PR #7006: URL: https://github.com/apache/apisix/pull/7006#discussion_r867570784 ## apisix/cli/ops.lua: ## @@ -728,14 +729,16 @@ local function start(env, ...) local pid = util.read_file(pid_path) pid = tonumber(pid) if pid then -

[GitHub] [apisix] tokers commented on pull request #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
tokers commented on PR #7007: URL: https://github.com/apache/apisix/pull/7007#issuecomment-1120529886 @soulbird Shall we also update the corresponding test cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] bzp2010 commented on pull request #6995: feat: support kafka consumer for pubsub scenario

2022-05-08 Thread GitBox
bzp2010 commented on PR #6995: URL: https://github.com/apache/apisix/pull/6995#issuecomment-1120477351 Information about the pubsub module can be viewed through the description in the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1007: docs: fix link in certificate management docs (#998)

2022-05-08 Thread GitBox
tao12345666333 commented on PR #1007: URL: https://github.com/apache/apisix-ingress-controller/pull/1007#issuecomment-1120445128 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix-ingress-controller] Kowsz opened a new pull request, #1007: docs: fix link in certificate management docs (#998)

2022-05-08 Thread GitBox
Kowsz opened a new pull request, #1007: URL: https://github.com/apache/apisix-ingress-controller/pull/1007 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [x] Documentation ### What this P

[GitHub] [apisix] soulbird opened a new pull request, #7007: chore: the default network port for OTLP/HTTP is 4318

2022-05-08 Thread GitBox
soulbird opened a new pull request, #7007: URL: https://github.com/apache/apisix/pull/7007 ### Description opentelemetry's default network port for OTLP/HTTP is 4318 not 4317. The default network port for OTLP/gRPC is 4317. Fixes # (issue) ### Checklist - [

[GitHub] [apisix] spacewander commented on issue #7005: feat: As a user, I want to make SSL session reusable by id across instances

2022-05-08 Thread GitBox
spacewander commented on issue #7005: URL: https://github.com/apache/apisix/issues/7005#issuecomment-1120419620 It is possible to use session ID with OpenResty, like the https://github.com/openresty/lua-nginx-module#ssl_session_fetch_by_lua_block. But as the session ticket is the modern way

[GitHub] [apisix] kwanhur commented on issue #7005: feat: As a user, I want to make SSL session reusable by id across instances

2022-05-08 Thread GitBox
kwanhur commented on issue #7005: URL: https://github.com/apache/apisix/issues/7005#issuecomment-1120414805 Emm, both ticket and ID can improve SSL session reuse. Here about reusing SSL session by id, just like Apache TrafficServer [SSL Session Reuse Plugin](https://docs.trafficserver.apach

[GitHub] [apisix] kwanhur opened a new pull request, #7006: feat(ops): check process running with posix.signal insteadof lsof

2022-05-08 Thread GitBox
kwanhur opened a new pull request, #7006: URL: https://github.com/apache/apisix/pull/7006 ### Description Partial OS no `lsof` tool, so if use `lsof` to check APISIX running or not will fail. Now send signal none(0) to check via luaposix. * remove shell command `lsof` de

[GitHub] [apisix] spacewander commented on a diff in pull request #6960: feat(xRPC): support log filter

2022-05-08 Thread GitBox
spacewander commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r867484872 ## t/xrpc/pingpong2.t: ## @@ -139,3 +151,548 @@ lua tcp socket send timeout: 6 stream lua tcp socket read timeout: 6 --- log_level: debug --- stream_conf_e

[GitHub] [apisix] spacewander commented on a diff in pull request #6981: feat(ops): handle real_ip_from CIDR format

2022-05-08 Thread GitBox
spacewander commented on code in PR #6981: URL: https://github.com/apache/apisix/pull/6981#discussion_r867483065 ## t/cli/test_validate_config.sh: ## @@ -167,11 +167,79 @@ plugins: nginx_config: http: real_ip_from: -- "127.0.0.2" +- "128.0.0.2" '

[GitHub] [apisix] spacewander commented on a diff in pull request #6960: feat(xRPC): support log filter

2022-05-08 Thread GitBox
spacewander commented on code in PR #6960: URL: https://github.com/apache/apisix/pull/6960#discussion_r867484185 ## apisix/stream/xrpc/runner.lua: ## @@ -70,9 +75,53 @@ local function put_req_ctx(session, ctx) end +local function filter_logger(ctx, logger) +if not logge

[GitHub] [apisix] spacewander commented on a diff in pull request #6968: feat: support hook response body for ext-plugin

2022-05-08 Thread GitBox
spacewander commented on code in PR #6968: URL: https://github.com/apache/apisix/pull/6968#discussion_r867480805 ## apisix/plugins/ext-plugin-post-resp.lua: ## @@ -0,0 +1,172 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license ag

[GitHub] [apisix] spacewander commented on a diff in pull request #6968: feat: support hook response body for ext-plugin

2022-05-08 Thread GitBox
spacewander commented on code in PR #6968: URL: https://github.com/apache/apisix/pull/6968#discussion_r867480639 ## apisix/plugins/ext-plugin/init.lua: ## @@ -682,6 +682,107 @@ local rpc_handlers = { return true end, +nil, -- ignore RPC_EXTRA_INFO, already pr

[GitHub] [apisix-ingress-controller] spacewander commented on issue #1004: request help: 关于对wasm的支持

2022-05-08 Thread GitBox
spacewander commented on issue #1004: URL: https://github.com/apache/apisix-ingress-controller/issues/1004#issuecomment-1120404177 > failed to new instance: unknown import: `env::proxy_continue_stream` has not been defined Can you provide a minimal reproducible example of the rust co

[GitHub] [apisix] SkyeYoung commented on pull request #7002: docs: upadate Chinese installation docs

2022-05-08 Thread GitBox
SkyeYoung commented on PR #7002: URL: https://github.com/apache/apisix/pull/7002#issuecomment-1120404166 @hf400159 Hi, we can use https://surge.sh/ to publish a preview quickly. 😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #86: request help: Can I set multi ext-plugin?

2022-05-08 Thread GitBox
spacewander commented on issue #86: URL: https://github.com/apache/apisix-go-plugin-runner/issues/86#issuecomment-1120404004 No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [apisix-go-plugin-runner] spacewander closed issue #86: request help: Can I set multi ext-plugin?

2022-05-08 Thread GitBox
spacewander closed issue #86: request help: Can I set multi ext-plugin? URL: https://github.com/apache/apisix-go-plugin-runner/issues/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [apisix] spacewander commented on issue #7005: feat: As a user, I want to make SSL session reusable by id across instances

2022-05-08 Thread GitBox
spacewander commented on issue #7005: URL: https://github.com/apache/apisix/issues/7005#issuecomment-1120403290 We need to modify Nginx to rotate SSL tickets so it is safe to reuse the session. See https://github.com/apache/apisix/issues/2638 -- This is an automated message from the Apach

[GitHub] [apisix] spacewander commented on a diff in pull request #6949: api-breaker plugin returns default response body

2022-05-08 Thread GitBox
spacewander commented on code in PR #6949: URL: https://github.com/apache/apisix/pull/6949#discussion_r867478450 ## apisix/plugins/api-breaker.lua: ## @@ -35,6 +35,13 @@ local schema = { minimum = 200, maximum = 599, }, +break_response_

[GitHub] [apisix] moonming commented on pull request #7002: docs: upadate Chinese installation docs

2022-05-08 Thread GitBox
moonming commented on PR #7002: URL: https://github.com/apache/apisix/pull/7002#issuecomment-1120402747 is there a preview link for docs? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[apisix] branch master updated: docs: replace all apisix-openresty to apisix-base (#6998)

2022-05-08 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 0d1280cde docs: replace all apisix-openrest

[GitHub] [apisix] spacewander closed issue #6983: docs: rename apisix-openresty to apisix-base

2022-05-08 Thread GitBox
spacewander closed issue #6983: docs: rename apisix-openresty to apisix-base URL: https://github.com/apache/apisix/issues/6983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [apisix] spacewander merged pull request #6998: docs: replace all apisix-openresty to apisix-base

2022-05-08 Thread GitBox
spacewander merged PR #6998: URL: https://github.com/apache/apisix/pull/6998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] github-actions[bot] commented on pull request #6542: Add stream proxy config item

2022-05-08 Thread GitBox
github-actions[bot] commented on PR #6542: URL: https://github.com/apache/apisix/pull/6542#issuecomment-1120388382 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1006: feat: Add support force-ssl-redirect to ingress translator

2022-05-08 Thread GitBox
tao12345666333 commented on PR #1006: URL: https://github.com/apache/apisix-ingress-controller/pull/1006#issuecomment-1120373481 Thanks for your contribution. I understand that you want to make APISIX Ingress compatible with Ingress NGINX better, right? As you may have noticed

[GitHub] [apisix-ingress-controller] jaysonsantos opened a new pull request, #1006: feat: Add support force-ssl-redirect to ingress translator

2022-05-08 Thread GitBox
jaysonsantos opened a new pull request, #1006: URL: https://github.com/apache/apisix-ingress-controller/pull/1006 ### Type of change: - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches ### What this PR does / why we