[GitHub] [apisix] ZUOXIANGE commented on pull request #6232: feat(discovery): add consul support

2022-05-16 Thread GitBox
ZUOXIANGE commented on PR #6232: URL: https://github.com/apache/apisix/pull/6232#issuecomment-1128486776 Why this pr closed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] starsz opened a new pull request, #7062: feat: upgrade casbin dependency to 1.41.1

2022-05-16 Thread GitBox
starsz opened a new pull request, #7062: URL: https://github.com/apache/apisix/pull/7062 ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new featur

[GitHub] [apisix] spacewander commented on a diff in pull request #7049: feat(ops): allow access admin loopback IP address

2022-05-16 Thread GitBox
spacewander commented on code in PR #7049: URL: https://github.com/apache/apisix/pull/7049#discussion_r874431581 ## t/cli/test_admin.sh: ## @@ -112,6 +112,48 @@ if [ $count -eq 0 ]; then exit 1 fi +echo " Review Comment: Err... Even reverting the feature, the newer a

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874426552 ## apisix/upstream.lua: ## @@ -435,7 +435,7 @@ local function check_upstream_conf(in_dp, conf) end end -if conf.tls then +if conf.tls and conf.tls

[GitHub] [apisix-website] github-actions[bot] commented on pull request #1097: docs: update Chinese sidebar

2022-05-16 Thread GitBox
github-actions[bot] commented on PR #1097: URL: https://github.com/apache/apisix-website/pull/1097#issuecomment-1128467532 🚀 Deployed on https://628340054d931c2f267178fe--apache-apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix-website] SylviaBABY commented on pull request #1094: docs: add Chinese translation about blog-contributing-guide

2022-05-16 Thread GitBox
SylviaBABY commented on PR #1094: URL: https://github.com/apache/apisix-website/pull/1094#issuecomment-1128466024 Others LGTM, thanks for @lawrshen contribution! And also thank @yzeng25 @hf400159 for your patience with this PR ^-^ -- This is an automated message from the Apache Git

[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1094: docs: add Chinese translation about blog-contributing-guide

2022-05-16 Thread GitBox
SylviaBABY commented on code in PR #1094: URL: https://github.com/apache/apisix-website/pull/1094#discussion_r874413368 ## website/i18n/zh/docusaurus-plugin-content-docs/current/blog-contributing-guide.md: ## @@ -0,0 +1,207 @@ +--- +id: blog +title: 博客贡献指南 +keywords: +- API 网关 +

[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1094: docs: add Chinese translation about blog-contributing-guide

2022-05-16 Thread GitBox
SylviaBABY commented on code in PR #1094: URL: https://github.com/apache/apisix-website/pull/1094#discussion_r874413018 ## website/i18n/zh/docusaurus-plugin-content-docs/current/blog-contributing-guide.md: ## @@ -0,0 +1,207 @@ +--- +id: blog +title: 博客贡献指南 +keywords: +- API 网关 +

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874410084 ## apisix/upstream.lua: ## @@ -435,7 +435,7 @@ local function check_upstream_conf(in_dp, conf) end end -if conf.tls then +if conf.tls and conf.tls

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874411087 ## apisix/plugins/kafka-proxy.lua: ## @@ -0,0 +1,63 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874410084 ## apisix/upstream.lua: ## @@ -435,7 +435,7 @@ local function check_upstream_conf(in_dp, conf) end end -if conf.tls then +if conf.tls and conf.tls

[GitHub] [apisix-website] netlify[bot] commented on pull request #1097: docs: update Chinese sidebar

2022-05-16 Thread GitBox
netlify[bot] commented on PR #1097: URL: https://github.com/apache/apisix-website/pull/1097#issuecomment-1128455052 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | b3e542fd

[GitHub] [apisix-website] hf400159 opened a new pull request, #1097: docs: update Chinese sidebar

2022-05-16 Thread GitBox
hf400159 opened a new pull request, #1097: URL: https://github.com/apache/apisix-website/pull/1097 Since the content under general is changed to Chinese, the corresponding sidebar also needs to be changed to Chinese. Screenshots of the change: -- This is an auto

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2452: Turkish Language support added

2022-05-16 Thread GitBox
Baoyuantop commented on PR #2452: URL: https://github.com/apache/apisix-dashboard/pull/2452#issuecomment-1128453559 > @Baoyuantop could you point it the location of missing ones? Cause i checked it but didnt find. They are under `web/src/pages`; for example, there is a locales folder

[GitHub] [apisix-ingress-controller] GhangZh closed issue #1020: request help: ApisixRoute abbreviation does not support

2022-05-16 Thread GitBox
GhangZh closed issue #1020: request help: ApisixRoute abbreviation does not support URL: https://github.com/apache/apisix-ingress-controller/issues/1020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-ingress-controller] GhangZh commented on issue #1020: request help: ApisixRoute abbreviation does not support

2022-05-16 Thread GitBox
GhangZh commented on issue #1020: URL: https://github.com/apache/apisix-ingress-controller/issues/1020#issuecomment-1128451262 > Sure, thanks for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #984: feat: support ApisixPluginConfig v2

2022-05-16 Thread GitBox
tao12345666333 commented on PR #984: URL: https://github.com/apache/apisix-ingress-controller/pull/984#issuecomment-1128449747 @lingsamuel please resolve conflicts. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1018: doc: update "enable-authentication-and-restriction.md" doc, and examples of `jwt-auth` and `wolf-rbac`.

2022-05-16 Thread GitBox
AlinsRan commented on code in PR #1018: URL: https://github.com/apache/apisix-ingress-controller/pull/1018#discussion_r874400858 ## docs/en/latest/practices/enable-authentication-and-restriction.md: ## @@ -27,36 +27,124 @@ Consumers are used for the authentication method contr

[GitHub] [apisix] spacewander commented on a diff in pull request #7006: feat(ops): check process running with posix.signal insteadof lsof

2022-05-16 Thread GitBox
spacewander commented on code in PR #7006: URL: https://github.com/apache/apisix/pull/7006#discussion_r874400558 ## t/cli/test_main.sh: ## @@ -706,6 +706,16 @@ fi ./bin/apisix stop echo "pass: ignore stale nginx.pid" +# check running when run repeatedly Review Comment: W

[GitHub] [apisix-ingress-controller] AlinsRan commented on a diff in pull request #1018: doc: update "enable-authentication-and-restriction.md" doc, and examples of `jwt-auth` and `wolf-rbac`.

2022-05-16 Thread GitBox
AlinsRan commented on code in PR #1018: URL: https://github.com/apache/apisix-ingress-controller/pull/1018#discussion_r874399839 ## docs/en/latest/practices/enable-authentication-and-restriction.md: ## @@ -314,10 +516,10 @@ EOF **Example usage** -Requests from jack1: +* Re

[GitHub] [apisix] spacewander commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
spacewander commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874397296 ## apisix/plugins/kafka-proxy.lua: ## @@ -0,0 +1,63 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements.

[GitHub] [apisix] spacewander commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
spacewander commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874393154 ## apisix/upstream.lua: ## @@ -435,7 +435,7 @@ local function check_upstream_conf(in_dp, conf) end end -if conf.tls then +if conf.tls and conf

[apisix] branch master updated: feat(xrpc): register variable redis_cmd_line (#7041)

2022-05-16 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2e4950177 feat(xrpc): register variable red

[GitHub] [apisix] spacewander merged pull request #7041: feat(xrpc): register variable redis_cmd_line

2022-05-16 Thread GitBox
spacewander merged PR #7041: URL: https://github.com/apache/apisix/pull/7041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix-dashboard] jwrookie commented on a diff in pull request #2421: fix: create upstream error when pass host is node and nodes without port

2022-05-16 Thread GitBox
jwrookie commented on code in PR #2421: URL: https://github.com/apache/apisix-dashboard/pull/2421#discussion_r874390535 ## api/internal/core/entity/format.go: ## @@ -17,17 +17,23 @@ package entity import ( - "net" + "errors" "strconv" + "strings"

[GitHub] [apisix] artemus717 opened a new issue, #7061: Is there any plugin can support saml2 auth ?

2022-05-16 Thread GitBox
artemus717 opened a new issue, #7061: URL: https://github.com/apache/apisix/issues/7061 ### Description I want to use saml2 protocal as an auth method. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2421: fix: create upstream error when pass host is node and nodes without port

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #2421: URL: https://github.com/apache/apisix-dashboard/pull/2421#discussion_r874379186 ## api/internal/core/entity/format.go: ## @@ -17,17 +17,23 @@ package entity import ( - "net" + "errors" "strconv" + "strings"

[apisix-website] branch asf-site updated (04786a17980 -> d408c3c7ea5)

2022-05-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git discard 04786a17980 deploy: 8205a75c42114552bbc04509f32f37b07c2bd314 new d408c3c7ea5 deploy: 8205a75c421145

[apisix] branch dependabot/github_actions/actions/setup-node-3.2.0 created (now 9e3cd6c7f)

2022-05-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-node-3.2.0 in repository https://gitbox.apache.org/repos/asf/apisix.git at 9e3cd6c7f build(deps): bump actions/setup-node from 3.1.1 to 3.2.0 N

[GitHub] [apisix] dependabot[bot] opened a new pull request, #7060: build(deps): bump actions/setup-node from 3.1.1 to 3.2.0

2022-05-16 Thread GitBox
dependabot[bot] opened a new pull request, #7060: URL: https://github.com/apache/apisix/pull/7060 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.1.1 to 3.2.0. Release notes Sourced from https://github.com/actions/setup-node/releases";>actions/setup-node's

[GitHub] [apisix-dashboard] jwrookie commented on a diff in pull request #2421: fix: create upstream error when pass host is node and nodes without port

2022-05-16 Thread GitBox
jwrookie commented on code in PR #2421: URL: https://github.com/apache/apisix-dashboard/pull/2421#discussion_r874349477 ## api/internal/core/entity/format.go: ## @@ -17,17 +17,23 @@ package entity import ( - "net" + "errors" "strconv" + "strings"

[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2421: fix: create upstream error when pass host is node and nodes without port

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #2421: URL: https://github.com/apache/apisix-dashboard/pull/2421#discussion_r874345460 ## api/internal/core/entity/format.go: ## @@ -17,17 +17,23 @@ package entity import ( - "net" + "errors" "strconv" + "strings"

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1020: request help: ApisixRoute abbreviation does not support

2022-05-16 Thread GitBox
tao12345666333 commented on issue #1020: URL: https://github.com/apache/apisix-ingress-controller/issues/1020#issuecomment-1128383352 OK. So can we consider this issue to be resolved? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[apisix] branch release/2.14 updated (dee97448b -> 84ad80248)

2022-05-16 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/2.14 in repository https://gitbox.apache.org/repos/asf/apisix.git discard dee97448b feat: release 2.14.0 add 84ad80248 feat: release 2.14.0 This update added new revisions aft

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874342533 ## apisix/plugins/kafka-proxy.lua: ## @@ -0,0 +1,63 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See

[GitHub] [apisix] tzssangglass commented on issue #7056: help request: is there any way to get the upstream error in the plugin?

2022-05-16 Thread GitBox
tzssangglass commented on issue #7056: URL: https://github.com/apache/apisix/issues/7056#issuecomment-1128378138 you can use this plugin: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/response-rewrite.md the config maybe: ```json {

[GitHub] [apisix] bzp2010 opened a new pull request, #7059: docs: add pubsub develop example for kafka

2022-05-16 Thread GitBox
bzp2010 opened a new pull request, #7059: URL: https://github.com/apache/apisix/pull/7059 ### Description Add pubsub develop documentation example for Apache Kafka. ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explain

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
tzssangglass commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r874332677 ## apisix/plugins/kafka-proxy.lua: ## @@ -0,0 +1,63 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements.

[GitHub] [apisix] tzssangglass commented on pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
tzssangglass commented on PR #7046: URL: https://github.com/apache/apisix/pull/7046#issuecomment-1128375401 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [apisix] bzp2010 opened a new pull request, #7058: feat: add default handler for pubsub ping command

2022-05-16 Thread GitBox
bzp2010 opened a new pull request, #7058: URL: https://github.com/apache/apisix/pull/7058 ### Description Add the default ping handler, which will be overridden when the user re-calls the on function to set the `cmd_ping` handler. There are already test cases for `cmd_ping` in the or

[GitHub] [apisix] soulbird commented on issue #7056: help request: is there any way to get the upstream error in the plugin?

2022-05-16 Thread GitBox
soulbird commented on issue #7056: URL: https://github.com/apache/apisix/issues/7056#issuecomment-1128369854 It looks like you can only get a 502 status code in Apache APISIX. Maybe you can use [get_logs](https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/errlog.md#get_logs) f

[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1094: docs: add Chinese translation about blog-contributing-guide

2022-05-16 Thread GitBox
yzeng25 commented on code in PR #1094: URL: https://github.com/apache/apisix-website/pull/1094#discussion_r874321442 ## website/i18n/zh/docusaurus-plugin-content-docs/current/blog-contributing-guide.md: ## @@ -0,0 +1,198 @@ +--- +id: blog +title: 博客贡献指南 +keywords: +- API 网关 +- A

[GitHub] [apisix-ingress-controller] GhangZh commented on issue #1020: request help: ApisixRoute abbreviation does not support

2022-05-16 Thread GitBox
GhangZh commented on issue #1020: URL: https://github.com/apache/apisix-ingress-controller/issues/1020#issuecomment-1128361589 Thanks I found the reason there is a renamed ar ![K8P8xtaExp](https://user-images.githubusercontent.com/92301646/168721020-b1819ec8-8652-406b-ad1f-a701a370f45f.j

[GitHub] [apisix-docker] VioletZhouECE commented on issue #300: Redesign the document architecture of apisix-docker

2022-05-16 Thread GitBox
VioletZhouECE commented on issue #300: URL: https://github.com/apache/apisix-docker/issues/300#issuecomment-1128360345 It seems like apisix and apisix dashboard are in two different places: https://hub.docker.com/r/apache/apisix, https://hub.docker.com/r/apache/apisix-dashboard, but they sh

[GitHub] [apisix-website] SylviaBABY commented on pull request #1096: docs: add two blogs

2022-05-16 Thread GitBox
SylviaBABY commented on PR #1096: URL: https://github.com/apache/apisix-website/pull/1096#issuecomment-1128358693 No big problem, mainly some paragraphs with empty lines. Others LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix] spacewander opened a new pull request, #7057: feat: release 2.14.0

2022-05-16 Thread GitBox
spacewander opened a new pull request, #7057: URL: https://github.com/apache/apisix/pull/7057 Signed-off-by: spacewander ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have

[apisix] branch release/2.14 created (now dee97448b)

2022-05-16 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch release/2.14 in repository https://gitbox.apache.org/repos/asf/apisix.git at dee97448b feat: release 2.14.0 This branch includes the following new commits: new dee97448b feat: r

[apisix] 01/01: feat: release 2.14.0

2022-05-16 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch release/2.14 in repository https://gitbox.apache.org/repos/asf/apisix.git commit dee97448b756ffa0a3b88697704a5dcbfa48bd84 Author: spacewander AuthorDate: Tue May 17 11:08:16 2022 +0800

[GitHub] [apisix-ingress-controller] GhangZh commented on issue #1020: request help: ApisixRoute abbreviation does not support

2022-05-16 Thread GitBox
GhangZh commented on issue #1020: URL: https://github.com/apache/apisix-ingress-controller/issues/1020#issuecomment-1128357743 > kubectl get ar -A -v 12 ```bash ☁️ ~ kt get ar -v 12 -n ingress-apisix I0517 11:06:53.840653 55222 loader.go:372] Config loaded from file: config/t

[GitHub] [apisix] tzssangglass commented on pull request #7006: feat(ops): check process running with posix.signal insteadof lsof

2022-05-16 Thread GitBox
tzssangglass commented on PR #7006: URL: https://github.com/apache/apisix/pull/7006#issuecomment-1128357292 > Had merged. Plz rerun [this action](https://github.com/apache/apisix/runs/6448958745?check_suite_focus=true). done -- This is an automated message from the Apache Git Servi

[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1096: docs: add two blogs

2022-05-16 Thread GitBox
SylviaBABY commented on code in PR #1096: URL: https://github.com/apache/apisix-website/pull/1096#discussion_r874319105 ## website/blog/2022/04/29/interview-juzhiyuan-apache-member.md: ## @@ -0,0 +1,167 @@ +--- +title: "Interview with JU Zhiyuan: Becoming One of the 918 ASF Memb

[GitHub] [apisix] tzssangglass commented on issue #7042: bug: Obvious memory leak when the weight sum of all nodes in the upstream of the chash type is large

2022-05-16 Thread GitBox
tzssangglass commented on issue #7042: URL: https://github.com/apache/apisix/issues/7042#issuecomment-1128355848 > I think we should just gcd the weights and spend the remind effort on another chash implementation like Maglev. My thoughts are similar. The current chash implementation

[GitHub] [apisix-website] yzeng25 commented on pull request #1096: docs: add two blogs

2022-05-16 Thread GitBox
yzeng25 commented on PR #1096: URL: https://github.com/apache/apisix-website/pull/1096#issuecomment-1128352594 This pull request is a newer version of https://github.com/apache/apisix-website/pull/1064, which has been closed due to too much changes in a short period of time. I find s

[GitHub] [apisix] mygrsun opened a new issue, #7056: help request: is there any way to get the upstream error in the plugin?

2022-05-16 Thread GitBox
mygrsun opened a new issue, #7056: URL: https://github.com/apache/apisix/issues/7056 ### Description i want to get the upstream timeout error in the plugin.beacuse i want to sent a json resonse to caller when the upstream is timeout.for example : {"Response":{"RequestId":"123","Er

[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1096: docs: add two blogs

2022-05-16 Thread GitBox
yzeng25 commented on code in PR #1096: URL: https://github.com/apache/apisix-website/pull/1096#discussion_r874313567 ## website/blog/2022/04/29/interview-juzhiyuan-apache-member.md: ## @@ -0,0 +1,167 @@ +--- +title: "Interview with JU Zhiyuan: Becoming One of the 918 ASF Members

[GitHub] [apisix] soulbird commented on a diff in pull request #7041: feat(xrpc): register variable redis_cmd_line

2022-05-16 Thread GitBox
soulbird commented on code in PR #7041: URL: https://github.com/apache/apisix/pull/7041#discussion_r874314583 ## t/xrpc/redis2.t: ## @@ -0,0 +1,201 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file

[GitHub] [apisix-ingress-controller] Horus-K commented on issue #979: request help: crd resource does not display correctly

2022-05-16 Thread GitBox
Horus-K commented on issue #979: URL: https://github.com/apache/apisix-ingress-controller/issues/979#issuecomment-1128349616 I can help you troubleshoot the problem, but I don't know much about crd -- This is an automated message from the Apache Git Service. To respond to the message, ple

[apisix] branch master updated: docs: sync Chinese benchmark doc and add notes on running the benchmark (#7035)

2022-05-16 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 8789cba70 docs: sync Chinese benchmark doc

[GitHub] [apisix] spacewander closed issue #5966: doc: benchmark results is not so good,what is the problem,help

2022-05-16 Thread GitBox
spacewander closed issue #5966: doc: benchmark results is not so good,what is the problem,help URL: https://github.com/apache/apisix/issues/5966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] spacewander merged pull request #7035: docs: sync Chinese benchmark doc and add notes on running the benchmark

2022-05-16 Thread GitBox
spacewander merged PR #7035: URL: https://github.com/apache/apisix/pull/7035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1019: Proposal: Apisix-Ingress-Controller support integrating with service discovery registry

2022-05-16 Thread GitBox
tao12345666333 commented on issue #1019: URL: https://github.com/apache/apisix-ingress-controller/issues/1019#issuecomment-1128332008 SGTM. As I replied on the mailing list: > For now, the APISIX Ingress controller is a control plane component that does not handle static con

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #979: request help: crd resource does not display correctly

2022-05-16 Thread GitBox
tao12345666333 commented on issue #979: URL: https://github.com/apache/apisix-ingress-controller/issues/979#issuecomment-1128330830 @Horus-K This was not included in version 1.4.1. If you're interested, can you help to locate the problem, or submit a PR to fix it? -- This is an a

[GitHub] [apisix-ingress-controller] Horus-K commented on issue #979: request help: crd resource does not display correctly

2022-05-16 Thread GitBox
Horus-K commented on issue #979: URL: https://github.com/apache/apisix-ingress-controller/issues/979#issuecomment-1128325305 @tao12345666333 1.4.1 still cannot display crd resources normally -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] believe1499 commented on issue #2455: MQTT edit

2022-05-16 Thread GitBox
believe1499 commented on issue #2455: URL: https://github.com/apache/apisix-dashboard/issues/2455#issuecomment-1128315595 If there is a apisix cluster, we can only call the admin-api one by one to edit the MQTT related config? -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-ingress-controller] Gallardot commented on issue #1019: Proposal: Apisix-Ingress-Controller support integrating with service discovery registry

2022-05-16 Thread GitBox
Gallardot commented on issue #1019: URL: https://github.com/apache/apisix-ingress-controller/issues/1019#issuecomment-1128308556 > @Gallardot Would you like to submit a proposal to [d...@apisix.apache.org](mailto:d...@apisix.apache.org)? Thanks! @tokers I have sent an email to [d.

[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key

2022-05-16 Thread GitBox
tokers commented on code in PR #285: URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r874277643 ## charts/apisix-dashboard/values.yaml: ## @@ -76,6 +76,7 @@ config: authentication: secert: secert expireTime: 3600 +userCreate: true Review Co

[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #285: feat: Support auto-generate random `admin/view` key

2022-05-16 Thread GitBox
tokers commented on code in PR #285: URL: https://github.com/apache/apisix-helm-chart/pull/285#discussion_r874276587 ## charts/apisix-dashboard/values.yaml: ## @@ -76,6 +76,7 @@ config: authentication: secert: secert expireTime: 3600 +userCreate: true Review Co

[GitHub] [apisix] spacewander commented on issue #7042: bug: Obvious memory leak when the weight sum of all nodes in the upstream of the chash type is large

2022-05-16 Thread GitBox
spacewander commented on issue #7042: URL: https://github.com/apache/apisix/issues/7042#issuecomment-1128297659 After a second thought, I have changed my mind. As the 160 is widely used in several implementations: https://github.com/ultrabug/uhashring https://www.nginx.com/resources/

[GitHub] [apisix] tokers commented on pull request #7006: feat(ops): check process running with posix.signal insteadof lsof

2022-05-16 Thread GitBox
tokers commented on PR #7006: URL: https://github.com/apache/apisix/pull/7006#issuecomment-1128297553 @kwanhur Please make the CI pass, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-dashboard] jwrookie commented on issue #2455: MQTT edit

2022-05-16 Thread GitBox
jwrookie commented on issue #2455: URL: https://github.com/apache/apisix-dashboard/issues/2455#issuecomment-1128296632 As far as I know, `apisix-dashborad` doesn't implement it yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [apisix] spacewander commented on issue #7042: bug: Obvious memory leak when the weight sum of all nodes in the upstream of the chash type is large

2022-05-16 Thread GitBox
spacewander commented on issue #7042: URL: https://github.com/apache/apisix/issues/7042#issuecomment-1128291621 > > 2. find a multiple which can make the min weight >= 1000, instead of a hard-code 1000 multiple > > Not quite sure where this 1000 comes from, please help me to point it

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r87395 ## .github/workflows/centos7-ci.yml: ## @@ -79,6 +79,8 @@ jobs: - name: Run other docker containers for test run: | +# generating SSL certificates f

[GitHub] [apisix] bzp2010 commented on a diff in pull request #7046: feat(pubsub): support kafka tls and sasl/plain auth

2022-05-16 Thread GitBox
bzp2010 commented on code in PR #7046: URL: https://github.com/apache/apisix/pull/7046#discussion_r87395 ## .github/workflows/centos7-ci.yml: ## @@ -79,6 +79,8 @@ jobs: - name: Run other docker containers for test run: | +# generating SSL certificates f

[GitHub] [apisix-website] github-actions[bot] commented on pull request #1096: docs: add two blogs

2022-05-16 Thread GitBox
github-actions[bot] commented on PR #1096: URL: https://github.com/apache/apisix-website/pull/1096#issuecomment-1127806353 🚀 Deployed on https://62826a4d10b2d4462ed2dfef--apache-apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix-website] netlify[bot] commented on pull request #1096: docs: add two blogs

2022-05-16 Thread GitBox
netlify[bot] commented on PR #1096: URL: https://github.com/apache/apisix-website/pull/1096#issuecomment-1127789987 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | 12a2c6ad

[GitHub] [apisix-website] EstelleRao opened a new pull request, #1096: docs: add two blogs

2022-05-16 Thread GitBox
EstelleRao opened a new pull request, #1096: URL: https://github.com/apache/apisix-website/pull/1096 Add two contributor interview blogs both in Chinese and English -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #1004: request help: 关于对wasm的支持

2022-05-16 Thread GitBox
tao12345666333 closed issue #1004: request help: 关于对wasm的支持 URL: https://github.com/apache/apisix-ingress-controller/issues/1004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1004: request help: 关于对wasm的支持

2022-05-16 Thread GitBox
tao12345666333 commented on issue #1004: URL: https://github.com/apache/apisix-ingress-controller/issues/1004#issuecomment-1127758779 we can use https://github.com/api7/wasm-nginx-module/issues/106 for tracking. I will close this one. Thanks all. -- This is an automated message from t

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1021: doc: add the way of changing the admin key into FAQ

2022-05-16 Thread GitBox
tao12345666333 commented on issue #1021: URL: https://github.com/apache/apisix-ingress-controller/issues/1021#issuecomment-1127755130 SGTM. A description of this is included in the configuration file, but it's also good to put it in the FAQ separately, if you are interested please su

[GitHub] [apisix-website] EstelleRao closed pull request #1064: docs: add a contributor interview blog

2022-05-16 Thread GitBox
EstelleRao closed pull request #1064: docs: add a contributor interview blog URL: https://github.com/apache/apisix-website/pull/1064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [apisix] kwanhur commented on a diff in pull request #7049: feat(ops): allow access admin loopback IP address

2022-05-16 Thread GitBox
kwanhur commented on code in PR #7049: URL: https://github.com/apache/apisix/pull/7049#discussion_r873692960 ## t/cli/test_admin.sh: ## @@ -112,6 +112,48 @@ if [ $count -eq 0 ]; then exit 1 fi +echo " Review Comment: Thx. Fixed. -- This is an automated message fr

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1020: request help: ApisixRoute abbreviation does not support

2022-05-16 Thread GitBox
tao12345666333 commented on issue #1020: URL: https://github.com/apache/apisix-ingress-controller/issues/1020#issuecomment-1127638462 Sorry I didn't reproduce ``` tao@moelove:~$ kubectl get ar NAME HOSTS URIS AGE hello-bar

[GitHub] [apisix-helm-chart] tao12345666333 opened a new issue, #289: feat: add admission configuration for APISIX Ingress controller

2022-05-16 Thread GitBox
tao12345666333 opened a new issue, #289: URL: https://github.com/apache/apisix-helm-chart/issues/289 The APISIX Ingress controller project supports Admission configuration, But it is not supported in the current Helm chart, so we need to add this feature Here is a simple exampl

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #251: docs: deploy go runner in apisix Ingress controller

2022-05-16 Thread GitBox
tao12345666333 commented on issue #251: URL: https://github.com/apache/apisix-helm-chart/issues/251#issuecomment-1127626074 Here's a PR to fix this https://github.com/apache/apisix-ingress-controller/pull/994 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #273: APISIX Ingress controller chart need add `metadata.namespace` configuration

2022-05-16 Thread GitBox
tao12345666333 commented on issue #273: URL: https://github.com/apache/apisix-helm-chart/issues/273#issuecomment-1127612648 #274 has been merged. I will close this one. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix-helm-chart] tao12345666333 closed issue #273: APISIX Ingress controller chart need add `metadata.namespace` configuration

2022-05-16 Thread GitBox
tao12345666333 closed issue #273: APISIX Ingress controller chart need add `metadata.namespace` configuration URL: https://github.com/apache/apisix-helm-chart/issues/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1003: bug: plugin_config_name is disappeared

2022-05-16 Thread GitBox
tao12345666333 commented on issue #1003: URL: https://github.com/apache/apisix-ingress-controller/issues/1003#issuecomment-1127607404 New version of Helm chart has been released, please upgrade to the latest Helm chart or modify the configuration in configmap. Thanks -- This is an automa

[apisix-helm-chart] branch master updated: chore: bump APISIX chart version 0.9.4 (#288)

2022-05-16 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 90133a1 chore: bump APISIX chart versio

[GitHub] [apisix-helm-chart] gxthrj merged pull request #288: chore: bump APISIX chart version 0.9.4

2022-05-16 Thread GitBox
gxthrj merged PR #288: URL: https://github.com/apache/apisix-helm-chart/pull/288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [apisix-ingress-controller] Chever-John commented on pull request #994: docs: add "how to use go plugin runner with APISIX Ingress"

2022-05-16 Thread GitBox
Chever-John commented on PR #994: URL: https://github.com/apache/apisix-ingress-controller/pull/994#issuecomment-1127575252 @tao12345666333 Hi, I have finished all the code reviews. Please review again, sir~ -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix] kwanhur commented on pull request #7048: feat(ops): use lua libs to backup config file insteadof shell command

2022-05-16 Thread GitBox
kwanhur commented on PR #7048: URL: https://github.com/apache/apisix/pull/7048#issuecomment-1127558677 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [apisix] kwanhur commented on pull request #7049: feat(ops): allow access admin loopback IP address

2022-05-16 Thread GitBox
kwanhur commented on PR #7049: URL: https://github.com/apache/apisix/pull/7049#issuecomment-1127558445 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [apisix-dashboard] believe1499 opened a new issue, #2455: MQTT edit

2022-05-16 Thread GitBox
believe1499 opened a new issue, #2455: URL: https://github.com/apache/apisix-dashboard/issues/2455 现在MQTT相关的编辑只能通过命令行调用接口的方式吗,可以在dashboard里面进行编辑吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] jwrookie opened a new pull request, #2454: Feat/use customize route prefix

2022-05-16 Thread GitBox
jwrookie opened a new pull request, #2454: URL: https://github.com/apache/apisix-dashboard/pull/2454 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided -

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7041: feat(xrpc): register variable redis_cmd_line

2022-05-16 Thread GitBox
tzssangglass commented on code in PR #7041: URL: https://github.com/apache/apisix/pull/7041#discussion_r873589669 ## apisix/stream/xrpc/protocols/redis/init.lua: ## @@ -31,6 +31,14 @@ local ipairs = ipairs local tonumber = tonumber +core.ctx.register_var("redis_cmd_line", f

[GitHub] [apisix-ingress-controller] Chever-John opened a new issue, #1021: doc: add the way of changing the admin key into FAQ

2022-05-16 Thread GitBox
Chever-John opened a new issue, #1021: URL: https://github.com/apache/apisix-ingress-controller/issues/1021 ## issues description: When I wanted to change the admin key for my Ingress, I found no documentation about this, but the fact that I needed to change two admin keys was hard t

[GitHub] [apisix] tzssangglass commented on issue #7042: bug: Obvious memory leak when the weight sum of all nodes in the upstream of the chash type is large

2022-05-16 Thread GitBox
tzssangglass commented on issue #7042: URL: https://github.com/apache/apisix/issues/7042#issuecomment-1127493781 > 2\. find a multiple which can make the min weight >= 1000, instead of a hard-code 1000 multiple Not quite sure where this 1000 comes from, please help me to point it out.

[GitHub] [apisix] tao12345666333 commented on issue #7052: feat: As a User, I want to be able to use oAuth2 with PKCE

2022-05-16 Thread GitBox
tao12345666333 commented on issue #7052: URL: https://github.com/apache/apisix/issues/7052#issuecomment-1127493532 This is a relatively simple function, just need to upgrade the resty.openidc version that APISIX depends on, and add some adaptations. -- This is an automated message from th

[GitHub] [apisix-ingress-controller] hf400159 commented on a diff in pull request #1018: doc: update "enable-authentication-and-restriction.md" doc, and examples of `jwt-auth` and `wolf-rbac`.

2022-05-16 Thread GitBox
hf400159 commented on code in PR #1018: URL: https://github.com/apache/apisix-ingress-controller/pull/1018#discussion_r873559804 ## docs/en/latest/practices/enable-authentication-and-restriction.md: ## @@ -27,36 +27,124 @@ Consumers are used for the authentication method contr

[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request, #288: chore: bump APISIX chart version 0.9.4

2022-05-16 Thread GitBox
tao12345666333 opened a new pull request, #288: URL: https://github.com/apache/apisix-helm-chart/pull/288 Signed-off-by: Jintao Zhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

  1   2   >