[GitHub] [apisix] navendu-pottekkat opened a new pull request, #7247: docs: update "Loggers" Plugins 3/n

2022-06-13 Thread GitBox
navendu-pottekkat opened a new pull request, #7247: URL: https://github.com/apache/apisix/pull/7247 Signed-off-by: Navendu Pottekkat ### Description Updates the documentation of the "Observability/Loggers" Plugins (2/n). Child PR of #6734 -- This is an automated messa

[GitHub] [apisix] lzxuan commented on issue #7244: help request: subpar performance of apisix in kubernetes

2022-06-13 Thread GitBox
lzxuan commented on issue #7244: URL: https://github.com/apache/apisix/issues/7244#issuecomment-1154757180 @tzssangglass I see, thanks a bunch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] tzssangglass commented on pull request #7240: feat: allow APISIX_PROFILE to be an empty string

2022-06-13 Thread GitBox
tzssangglass commented on PR #7240: URL: https://github.com/apache/apisix/pull/7240#issuecomment-1154751869 > Is there some documentation that can help me to write unit test cases https://github.com/apache/apisix/blob/master/docs/en/latest/internal/testing-framework.md -- This is a

[GitHub] [apisix-dashboard] TridentZZ opened a new issue, #2473: 在dashboard中创建路由,无法在集群中查询到

2022-06-13 Thread GitBox
TridentZZ opened a new issue, #2473: URL: https://github.com/apache/apisix-dashboard/issues/2473 ### Issue description 在dashboard页面上创建的路由无法在集群中通过kubectl get apisixroute -A 查询到,并且没有生效,但通过yaml方式创建的资源可以在dashboard中查看到。 ### Expected behavior 希望能够通过dashboard创建资源并且生效。 ##

[GitHub] [apisix-website] SkyeYoung opened a new pull request, #1152: fix: blog switch logic

2022-06-13 Thread GitBox
SkyeYoung opened a new pull request, #1152: URL: https://github.com/apache/apisix-website/pull/1152 Fixes: #[Add issue number here] Changes: - remove lang switch in blog pages - remove lang detect logic in blog pages Screenshots of the change: -- This is

[GitHub] [apisix-website] netlify[bot] commented on pull request #1152: fix: blog switch logic

2022-06-13 Thread GitBox
netlify[bot] commented on PR #1152: URL: https://github.com/apache/apisix-website/pull/1152#issuecomment-1154713066 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | 4849fb57

[GitHub] [apisix] foxchenlei commented on issue #7202: feat: apisix discovery for kubernetes support multi service_name

2022-06-13 Thread GitBox
foxchenlei commented on issue #7202: URL: https://github.com/apache/apisix/issues/7202#issuecomment-1154674453 ok,I hope it can be realized. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] SkyeYoung commented on pull request #2472: Update deploy-with-docker.md

2022-06-13 Thread GitBox
SkyeYoung commented on PR #2472: URL: https://github.com/apache/apisix-dashboard/pull/2472#issuecomment-1154671692 Pls also revise the description of the PR in English to make it accurate and clear. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix-dashboard] SkyeYoung commented on a diff in pull request #2472: Update deploy-with-docker.md

2022-06-13 Thread GitBox
SkyeYoung commented on code in PR #2472: URL: https://github.com/apache/apisix-dashboard/pull/2472#discussion_r896339131 ## docs/en/latest/deploy-with-docker.md: ## @@ -87,3 +87,5 @@ $ docker stop apisix-dashboard ```sh $ docker build -t apisix-dashboard:$tag . --no-cache=true

[GitHub] [apisix-dashboard] SkyeYoung commented on a diff in pull request #2472: Update deploy-with-docker.md

2022-06-13 Thread GitBox
SkyeYoung commented on code in PR #2472: URL: https://github.com/apache/apisix-dashboard/pull/2472#discussion_r896339131 ## docs/en/latest/deploy-with-docker.md: ## @@ -87,3 +87,5 @@ $ docker stop apisix-dashboard ```sh $ docker build -t apisix-dashboard:$tag . --no-cache=true

[GitHub] [apisix] fairyqb commented on issue #7242: performance : upgrading the luajit the CPU increased by 20% ,QPS performance drop

2022-06-13 Thread GitBox
fairyqb commented on issue #7242: URL: https://github.com/apache/apisix/issues/7242#issuecomment-1154653618 @spacewander @membphis @moonming @tzssangglass @Firstsawyou Is there a better idea? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix-website] netlify[bot] commented on pull request #1151: docs: add 4 blog of APISIX Summit

2022-06-13 Thread GitBox
netlify[bot] commented on PR #1151: URL: https://github.com/apache/apisix-website/pull/1151#issuecomment-1154645666 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | 5a7dfda2

[GitHub] [apisix-website] juzhiyuan closed pull request #1148: feat: remove canvas & add schema

2022-06-13 Thread GitBox
juzhiyuan closed pull request #1148: feat: remove canvas & add schema URL: https://github.com/apache/apisix-website/pull/1148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix-website] juzhiyuan commented on pull request #1148: feat: remove canvas & add schema

2022-06-13 Thread GitBox
juzhiyuan commented on PR #1148: URL: https://github.com/apache/apisix-website/pull/1148#issuecomment-1154645588 Hi @1502shivam-singh, thanks for your explanation, and I agree. > Or if anyone else could contribute in this regard, most welcome. I know @SkyeYoung is also good at

[GitHub] [apisix-website] SylviaBABY opened a new pull request, #1151: docs: add 4 blog of APISIX Summit

2022-06-13 Thread GitBox
SylviaBABY opened a new pull request, #1151: URL: https://github.com/apache/apisix-website/pull/1151 Changes: add 4 blog of APISIX Summit(2 tech blogs+2 user cases) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github

2022-06-13 Thread GitBox
juzhiyuan commented on code in PR #7193: URL: https://github.com/apache/apisix/pull/7193#discussion_r896319977 ## docs/zh/latest/plugins/response-rewrite.md: ## @@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80 如果你在 `access` 阶段执行了 `ngx.exit`,该操作只是中断了请求处理阶段,响应阶段仍然会处理。如果

[apisix-website] branch master updated: chore: disable deploy to netlify github action (#1150)

2022-06-13 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new c3e8baf706d chore: disable deploy to

[GitHub] [apisix-website] juzhiyuan merged pull request #1150: chore: disable deploy to netlify github action

2022-06-13 Thread GitBox
juzhiyuan merged PR #1150: URL: https://github.com/apache/apisix-website/pull/1150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2460: refactor: OpenAPI 3 parse and convert

2022-06-13 Thread GitBox
bzp2010 commented on code in PR #2460: URL: https://github.com/apache/apisix-dashboard/pull/2460#discussion_r896317107 ## api/internal/handler/data_loader/loader/openapi3/import_test.go: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [apisix] sunhao-java commented on pull request #7240: feat: allow APISIX_PROFILE to be an empty string

2022-06-13 Thread GitBox
sunhao-java commented on PR #7240: URL: https://github.com/apache/apisix/pull/7240#issuecomment-1154634459 > we should update docs:https://github.com/apache/apisix/blob/master/docs/en/latest/profile.md, and add test case, like: https://github.com/apache/apisix/blob/master/t/core/profile.t

[apisix-website] branch master updated: fix: video poster and style (#1149)

2022-06-13 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 6b8dee13c33 fix: video poster and sty

[GitHub] [apisix-website] juzhiyuan merged pull request #1149: fix: video poster and style

2022-06-13 Thread GitBox
juzhiyuan merged PR #1149: URL: https://github.com/apache/apisix-website/pull/1149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [apisix] tzssangglass commented on issue #7244: help request: subpar performance of apisix in kubernetes

2022-06-13 Thread GitBox
tzssangglass commented on issue #7244: URL: https://github.com/apache/apisix/issues/7244#issuecomment-1154631985 First of all, the official test benchmark is based on cloud servers, while your test is based on virtualization (k8s or k3s). As a rule of thumb, performance testing in vir

[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2460: refactor: OpenAPI 3 parse and convert

2022-06-13 Thread GitBox
bzp2010 commented on code in PR #2460: URL: https://github.com/apache/apisix-dashboard/pull/2460#discussion_r896308591 ## api/internal/handler/data_loader/loader/openapi3/import.go: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix] spacewander merged pull request #7221: feat(ssl): support get upstream cert from ssl object

2022-06-13 Thread GitBox
spacewander merged PR #7221: URL: https://github.com/apache/apisix/pull/7221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: feat(ssl): support get upstream cert from ssl object (#7221)

2022-06-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 45816272a feat(ssl): support get upstream c

[apisix] branch master updated: chore: validate etcd conf strictly (#7245)

2022-06-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new fc0dc15fc chore: validate etcd conf strictl

[GitHub] [apisix] spacewander merged pull request #7245: chore: validate etcd conf strictly

2022-06-13 Thread GitBox
spacewander merged PR #7245: URL: https://github.com/apache/apisix/pull/7245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: fix(api-response): check response header format (#7238)

2022-06-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 75107ab40 fix(api-response): check response

[GitHub] [apisix] spacewander merged pull request #7238: fix(api-response): check response header format

2022-06-13 Thread GitBox
spacewander merged PR #7238: URL: https://github.com/apache/apisix/pull/7238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander closed issue #7234: bug: plugin api-breaker set response headers occur 500 Internal Error

2022-06-13 Thread GitBox
spacewander closed issue #7234: bug: plugin api-breaker set response headers occur 500 Internal Error URL: https://github.com/apache/apisix/issues/7234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] lzxuan commented on issue #7244: help request: subpar performance of apisix in kubernetes

2022-06-13 Thread GitBox
lzxuan commented on issue #7244: URL: https://github.com/apache/apisix/issues/7244#issuecomment-1154609891 @moonming Thanks for your reply! First off, I belief the performance of APISIX is not degraded for every release and the result at the official benchmark page holds true. I would be ve

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7235: docs: update Chinese opentelemetry docs

2022-06-13 Thread GitBox
SylviaBABY commented on code in PR #7235: URL: https://github.com/apache/apisix/pull/7235#discussion_r896291036 ## docs/zh/latest/plugins/opentelemetry.md: ## @@ -23,42 +23,80 @@ title: opentelemetry ## 描述 -[OpenTelemetry](https://opentelemetry.io/) 提供符合 [OpenTelemetry spe

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7235: docs: update Chinese opentelemetry docs

2022-06-13 Thread GitBox
SylviaBABY commented on code in PR #7235: URL: https://github.com/apache/apisix/pull/7235#discussion_r896290836 ## docs/zh/latest/plugins/opentelemetry.md: ## @@ -23,42 +23,80 @@ title: opentelemetry ## 描述 -[OpenTelemetry](https://opentelemetry.io/) 提供符合 [OpenTelemetry spe

[GitHub] [apisix] moonming commented on issue #7244: help request: subpar performance of apisix in kubernetes

2022-06-13 Thread GitBox
moonming commented on issue #7244: URL: https://github.com/apache/apisix/issues/7244#issuecomment-1154570949 First of all, every major version of Apache APISIX is released, and there will be regressions in performance tests, and there will be no such performance degradation. Therefore, this

[GitHub] [apisix] fairyqb commented on issue #7242: performance : upgrading the luajit the CPU increased by 20% ,QPS performance drop

2022-06-13 Thread GitBox
fairyqb commented on issue #7242: URL: https://github.com/apache/apisix/issues/7242#issuecomment-1154519265 luajit in apisix-2.10.0-0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix] fairyqb commented on issue #7244: help request: subpar performance of apisix in kubernetes

2022-06-13 Thread GitBox
fairyqb commented on issue #7244: URL: https://github.com/apache/apisix/issues/7244#issuecomment-1154518157 @spacewander @membphis @moonming @tzssangglass @Firstsawyou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2468: feat: migrate old OpenAPI implementation to Loader interface

2022-06-13 Thread GitBox
bzp2010 commented on PR #2468: URL: https://github.com/apache/apisix-dashboard/pull/2468#issuecomment-1154182517 > large PR, maybe we could split it into small PRs? for example, at least two, import and export. Hi, @nic-chen. This one PR contains only the old code and tests fo

[GitHub] [apisix] navendu-pottekkat opened a new pull request, #7246: docs: update "Loggers" Plugins 2/n

2022-06-13 Thread GitBox
navendu-pottekkat opened a new pull request, #7246: URL: https://github.com/apache/apisix/pull/7246 Signed-off-by: Navendu Pottekkat ### Description Updates the documentation of the "Observability/Loggers" Plugins (2/n). Child PR of #6734 -- This is an automated messa

[GitHub] [apisix] kwanhur commented on a diff in pull request #7193: docs(response-rewrite): change image source from jsdelivr to github

2022-06-13 Thread GitBox
kwanhur commented on code in PR #7193: URL: https://github.com/apache/apisix/pull/7193#discussion_r895892285 ## docs/zh/latest/plugins/response-rewrite.md: ## @@ -125,7 +125,7 @@ X-Server-balancer_addr: 127.0.0.1:80 如果你在 `access` 阶段执行了 `ngx.exit`,该操作只是中断了请求处理阶段,响应阶段仍然会处理。如果你配

[GitHub] [apisix] starsz commented on issue #7190: Keycloak Authz should support Claim Information Point

2022-06-13 Thread GitBox
starsz commented on issue #7190: URL: https://github.com/apache/apisix/issues/7190#issuecomment-1154028438 > Here is the information about creating a UMA ticket, https://www.keycloak.org/docs/latest/authorization_services/#creating-permission-ticket > > How would ApiSix know what reso

[GitHub] [apisix-dashboard] starsz commented on a diff in pull request #2460: refactor: OpenAPI 3 parse and convert

2022-06-13 Thread GitBox
starsz commented on code in PR #2460: URL: https://github.com/apache/apisix-dashboard/pull/2460#discussion_r895819446 ## api/internal/handler/data_loader/loader/openapi3/import.go: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-dashboard] starsz commented on a diff in pull request #2460: refactor: OpenAPI 3 parse and convert

2022-06-13 Thread GitBox
starsz commented on code in PR #2460: URL: https://github.com/apache/apisix-dashboard/pull/2460#discussion_r895807821 ## api/internal/handler/data_loader/loader/openapi3/import.go: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-dashboard] starsz commented on pull request #2468: feat: migrate old OpenAPI implementation to Loader interface

2022-06-13 Thread GitBox
starsz commented on PR #2468: URL: https://github.com/apache/apisix-dashboard/pull/2468#issuecomment-1154010665 > large PR, maybe we could split it into small PRs? for example, at least two, import and export. Agree +1 -- This is an automated message from the Apache Git Service. T

[GitHub] [apisix] fanchangjifen commented on pull request #7099: init elasticsearch-logger.lua

2022-06-13 Thread GitBox
fanchangjifen commented on PR #7099: URL: https://github.com/apache/apisix/pull/7099#issuecomment-1153925895 The BULK API version has been submitted. In addition to separating data according to newline characters, the id of logs is automatically generated by ES or can be changed to SkyWalki

[GitHub] [apisix] spacewander commented on issue #7242: performance : upgrading the luajit the CPU increased by 20% ,QPS performance drop

2022-06-13 Thread GitBox
spacewander commented on issue #7242: URL: https://github.com/apache/apisix/issues/7242#issuecomment-1153922240 > compared to the old luajit version Which version do you mean `the old luajit`? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] tzssangglass commented on pull request #7240: feat: allow APISIX_PROFILE to be an empty string

2022-06-13 Thread GitBox
tzssangglass commented on PR #7240: URL: https://github.com/apache/apisix/pull/7240#issuecomment-1153912568 we should update docs:https://github.com/apache/apisix/blob/master/docs/en/latest/profile.md, and add test case, like: https://github.com/apache/apisix/blob/master/t/core/profile.t

[GitHub] [apisix-website] github-actions[bot] commented on pull request #1150: chore: disable deploy to netlify github action

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #1150: URL: https://github.com/apache/apisix-website/pull/1150#issuecomment-1153811900 🚀 Deployed on https://62a721ce60f8713644007469--apache-apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix] shuqingzai commented on issue #7239: help request: 插件 request-id 与 opentelemetry 结合

2022-06-13 Thread GitBox
shuqingzai commented on issue #7239: URL: https://github.com/apache/apisix/issues/7239#issuecomment-1153797864 > > maybe we can raise the priority of request-id? what is your option? > > LGTM. @shuqingzai Would you like to work on it? 十分抱歉,我对 `lua` 不是很熟悉。。。 -- This is an auto

[GitHub] [apisix-website] netlify[bot] commented on pull request #1150: chore: disable deploy to netlify github action

2022-06-13 Thread GitBox
netlify[bot] commented on PR #1150: URL: https://github.com/apache/apisix-website/pull/1150#issuecomment-1153795629 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | 2eca9be6

[GitHub] [apisix-website] SkyeYoung opened a new pull request, #1150: chore: disable deploy to netlify github action

2022-06-13 Thread GitBox
SkyeYoung opened a new pull request, #1150: URL: https://github.com/apache/apisix-website/pull/1150 Fixes: #[Add issue number here] Changes: This step is temporarily disabled because this preview is not working for now. Screenshots of the change: -- This i

[GitHub] [apisix-website] LiteSun commented on pull request #1149: fix: video poster and style

2022-06-13 Thread GitBox
LiteSun commented on PR #1149: URL: https://github.com/apache/apisix-website/pull/1149#issuecomment-1153770197 > Screenshots of the change: Any Screenshots of those changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix-ingress-controller] haohello commented on issue #1082: request help: Why does 'the enabling https redirect' redirect to the https scheme with the port 9443?

2022-06-13 Thread GitBox
haohello commented on issue #1082: URL: https://github.com/apache/apisix-ingress-controller/issues/1082#issuecomment-1153743675 ?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix] github-actions[bot] commented on pull request #6673: 动态上游:banlancer.lua -> _M.run() 代码第356行前后,before_proxy 之前,执行ctx.picked_server = server

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #6673: URL: https://github.com/apache/apisix/pull/6673#issuecomment-1153724268 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull

[GitHub] [apisix] github-actions[bot] commented on pull request #6713: fix(batch-requests): read trailers

2022-06-13 Thread GitBox
github-actions[bot] commented on PR #6713: URL: https://github.com/apache/apisix/pull/6713#issuecomment-1153724302 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull

[GitHub] [apisix] spacewander opened a new pull request, #7245: chore: validate etcd conf strictly

2022-06-13 Thread GitBox
spacewander opened a new pull request, #7245: URL: https://github.com/apache/apisix/pull/7245 Signed-off-by: spacewander ### Description Fixes # (issue) ### Checklist - [x] I have explained the need for this PR and the problem it solves - [ ] I have

[GitHub] [apisix-ingress-controller] haohello commented on issue #1082: request help: Why does 'the enabling https redirect' redirect to the https scheme with the port 9443?

2022-06-13 Thread GitBox
haohello commented on issue #1082: URL: https://github.com/apache/apisix-ingress-controller/issues/1082#issuecomment-1153720748 > Please refer to this document to configure APISIX > > https://apisix.apache.org/docs/apisix/plugins/redirect/ > > > Only one of http

[GitHub] [apisix-ingress-controller] haohello commented on issue #1084: request help: http to https redirect

2022-06-13 Thread GitBox
haohello commented on issue #1084: URL: https://github.com/apache/apisix-ingress-controller/issues/1084#issuecomment-1153721978 ?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix] sunhao-java commented on issue #7216: When APISIX_PROFILE is used, no empty judgment is performed, resulting in an unsightly display format of the configuration file name

2022-06-13 Thread GitBox
sunhao-java commented on issue #7216: URL: https://github.com/apache/apisix/issues/7216#issuecomment-1153710810 > > The advantage of this is that when using the docker image, docker will remind the user which environment variables need to be set. > > useful Thanks for your reco

[GitHub] [apisix] sunhao-java commented on issue #7216: When APISIX_PROFILE is used, no empty judgment is performed, resulting in an unsightly display format of the configuration file name

2022-06-13 Thread GitBox
sunhao-java commented on issue #7216: URL: https://github.com/apache/apisix/issues/7216#issuecomment-1153710522 Thanks for your recognition. 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] tzssangglass commented on issue #7216: When APISIX_PROFILE is used, no empty judgment is performed, resulting in an unsightly display format of the configuration file name

2022-06-13 Thread GitBox
tzssangglass commented on issue #7216: URL: https://github.com/apache/apisix/issues/7216#issuecomment-1153707835 > The advantage of this is that when using the docker image, docker will remind the user which environment variables need to be set. useful -- This is an automated messa

[GitHub] [apisix] tzssangglass commented on issue #7100: request help: apisix doesn't support etcd ipv6 endpoints

2022-06-13 Thread GitBox
tzssangglass commented on issue #7100: URL: https://github.com/apache/apisix/issues/7100#issuecomment-1153706828 It looks like the etcd health check feature is not working properly with ipv6. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [apisix] lzxuan opened a new issue, #7244: help request: subpar performance of apisix in kubernetes

2022-06-13 Thread GitBox
lzxuan opened a new issue, #7244: URL: https://github.com/apache/apisix/issues/7244 ### Description Following [this Slack thread](https://the-asf.slack.com/archives/CUC5MN17A/p1653900217440819), where I benchmarked APISIX running on a single-node K3s of version `v1.23.6+k3s1` atop `

[GitHub] [apisix] nic-chen commented on pull request #7229: fix: duplicate X-Forwarded-Proto will be sent as string

2022-06-13 Thread GitBox
nic-chen commented on PR #7229: URL: https://github.com/apache/apisix/pull/7229#issuecomment-1153695520 hi @soulbird could you please backport the change to 2.13 and 2.10 too? thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] sunhao-java commented on issue #7216: When APISIX_PROFILE is used, no empty judgment is performed, resulting in an unsightly display format of the configuration file name

2022-06-13 Thread GitBox
sunhao-java commented on issue #7216: URL: https://github.com/apache/apisix/issues/7216#issuecomment-1153693037 We customized the dockerfile of apisix. ``` ENV \ # The role of the apisix cluster. If dp and cp are not distinguished, the environment variable can be omitted or empt

[GitHub] [apisix-ingress-controller] haohello commented on issue #1082: request help: Why does 'the enabling https redirect' redirect to the https scheme with the port 9443?

2022-06-13 Thread GitBox
haohello commented on issue #1082: URL: https://github.com/apache/apisix-ingress-controller/issues/1082#issuecomment-1153686879 I guess you can add a `Tip me` button in the issue section so that I'm willing to send a few hundred bucks as tips to help speed things up a little. -- This is

[GitHub] [apisix-ingress-controller] haohello commented on issue #1082: request help: Why does 'the enabling https redirect' redirect to the https scheme with the port 9443?

2022-06-13 Thread GitBox
haohello commented on issue #1082: URL: https://github.com/apache/apisix-ingress-controller/issues/1082#issuecomment-1153683821 Why can't you just make this plugin to work with the default 443 https port out of the box? It's too difficult for newcomers like me to figure out how to get it w

[apisix] branch master updated: fix: duplicate X-Forwarded-Proto will be sent as string (#7229)

2022-06-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new eb62ac054 fix: duplicate X-Forwarded-Proto

[GitHub] [apisix] spacewander closed issue #7215: bug: `X-Forwarded-Proto` header should not be set for upstream as a table

2022-06-13 Thread GitBox
spacewander closed issue #7215: bug: `X-Forwarded-Proto` header should not be set for upstream as a table URL: https://github.com/apache/apisix/issues/7215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] spacewander merged pull request #7229: fix: duplicate X-Forwarded-Proto will be sent as string

2022-06-13 Thread GitBox
spacewander merged PR #7229: URL: https://github.com/apache/apisix/pull/7229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: fix: distinguish different upstreams even they have the same addr (#7213)

2022-06-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 932f7b37b fix: distinguish different upstre

[GitHub] [apisix] spacewander merged pull request #7213: fix: distinguish different upstreams even they have the same addr

2022-06-13 Thread GitBox
spacewander merged PR #7213: URL: https://github.com/apache/apisix/pull/7213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix-dashboard] nic-chen commented on pull request #2460: refactor: OpenAPI 3 parse and convert

2022-06-13 Thread GitBox
nic-chen commented on PR #2460: URL: https://github.com/apache/apisix-dashboard/pull/2460#issuecomment-1153619734 will review it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix-dashboard] nic-chen commented on pull request #2468: feat: migrate old OpenAPI implementation to Loader interface

2022-06-13 Thread GitBox
nic-chen commented on PR #2468: URL: https://github.com/apache/apisix-dashboard/pull/2468#issuecomment-1153619312 large PR, maybe we could split it into small PRs? for example, at least two, import and export. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] zhendongcmss commented on issue #7100: request help: apisix doesn't support etcd ipv6 endpoints

2022-06-13 Thread GitBox
zhendongcmss commented on issue #7100: URL: https://github.com/apache/apisix/issues/7100#issuecomment-1153606354 Although it print error logs, getting and setting routes work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] zhendongcmss commented on issue #7100: request help: apisix doesn't support etcd ipv6 endpoints

2022-06-13 Thread GitBox
zhendongcmss commented on issue #7100: URL: https://github.com/apache/apisix/issues/7100#issuecomment-1153604744 I use the latest luasocket SDK, apisix can connect to etcd , but it print the error when it started. I am investigating. ![image](https://user-images.githubuserconten

[GitHub] [apisix] zhendongcmss commented on issue #7100: request help: apisix doesn't support etcd ipv6 endpoints

2022-06-13 Thread GitBox
zhendongcmss commented on issue #7100: URL: https://github.com/apache/apisix/issues/7100#issuecomment-1153601234 update: https://github.com/lunarmodules/luasocket/issues/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] zhendongcmss opened a new pull request, #7243: feat: support etcd ipv6 endpoints

2022-06-13 Thread GitBox
zhendongcmss opened a new pull request, #7243: URL: https://github.com/apache/apisix/pull/7243 ### Description Fixes # (issue) https://github.com/apache/apisix/issues/7100 ### Checklist - [ ] I have explained the need for this PR and the problem it solves -

[GitHub] [apisix] fairyqb commented on issue #7242: performance : upgrading the luajit the CPU increased by 20% ,QPS performance drop

2022-06-13 Thread GitBox
fairyqb commented on issue #7242: URL: https://github.com/apache/apisix/issues/7242#issuecomment-1153590737 > Did you upgrade the version of luajit separately? I suggest you better use the official openresty version that matches luajit After the upgrade of luajie, it is running normal

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1082: request help: Why does 'the enabling https redirect' redirect to the https scheme with the port 9443?

2022-06-13 Thread GitBox
tao12345666333 commented on issue #1082: URL: https://github.com/apache/apisix-ingress-controller/issues/1082#issuecomment-1153584812 Please refer to this document to configure APISIX https://apisix.apache.org/docs/apisix/plugins/redirect/ > Only one of http_to_https, uri and

[GitHub] [apisix-ingress-controller] TridentZZ closed issue #1085: request help: 在dashboard创建资源在集群中搜索不到,但在集群中通过yaml新建apisixroute资源却会在dashboard显示

2022-06-13 Thread GitBox
TridentZZ closed issue #1085: request help: 在dashboard创建资源在集群中搜索不到,但在集群中通过yaml新建apisixroute资源却会在dashboard显示 URL: https://github.com/apache/apisix-ingress-controller/issues/1085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] soulbird commented on a diff in pull request #7221: feat(ssl): support get upstream cert from ssl object

2022-06-13 Thread GitBox
soulbird commented on code in PR #7221: URL: https://github.com/apache/apisix/pull/7221#discussion_r895403864 ## docs/en/latest/admin-api.md: ## @@ -792,7 +792,7 @@ Currently, the response is returned from etcd. | labels | False| Match Rules | Attributes

[GitHub] [apisix-ingress-controller] haohello commented on issue #1082: request help: Why does 'the enabling https redirect' redirect to the https scheme with the port 9443?

2022-06-13 Thread GitBox
haohello commented on issue #1082: URL: https://github.com/apache/apisix-ingress-controller/issues/1082#issuecomment-1153567630 I'm using the latest version of APISIX, obviously this issue still hasn't been resolved yet. -- This is an automated message from the Apache Git Service. To res

[GitHub] [apisix] spacewander commented on a diff in pull request #7221: feat(ssl): support get upstream cert from ssl object

2022-06-13 Thread GitBox
spacewander commented on code in PR #7221: URL: https://github.com/apache/apisix/pull/7221#discussion_r895402815 ## docs/en/latest/admin-api.md: ## @@ -792,7 +792,7 @@ Currently, the response is returned from etcd. | labels | False| Match Rules | Attribut

[GitHub] [apisix] soulbird commented on issue #7242: performance : upgrading the luajit the CPU increased by 20% ,QPS performance drop

2022-06-13 Thread GitBox
soulbird commented on issue #7242: URL: https://github.com/apache/apisix/issues/7242#issuecomment-1153559396 Did you upgrade the version of luajit separately? I suggest you better use the official openresty version that matches luajit -- This is an automated message from the Apache Git Se

[GitHub] [apisix] spacewander commented on pull request #7220: feat: Add support for capturing OIDC refresh tokens

2022-06-13 Thread GitBox
spacewander commented on PR #7220: URL: https://github.com/apache/apisix/pull/7220#issuecomment-1153556464 ``` # x-real-ip: 127.0.0.1 # x-refresh-token: *** # x-userinfo: eyJzdWIiOiJjMTU0YWVjMS01ZmJjLTQyNjktOTZkYS1iMDE4MTNmMWYyYzEiLCJwcmVmZXJyZWRfdXNlcm5hbWUiOiJ0ZWFjaGVyQGdtYWlsLmNv

[GitHub] [apisix-ingress-controller] haohello commented on issue #1084: request help: http to https redirect

2022-06-13 Thread GitBox
haohello commented on issue #1084: URL: https://github.com/apache/apisix-ingress-controller/issues/1084#issuecomment-1153556314 ?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix] fairyqb opened a new issue, #7242: bug: upgrading the luajit the CPU increased by 20% ,QPS performance drop

2022-06-13 Thread GitBox
fairyqb opened a new issue, #7242: URL: https://github.com/apache/apisix/issues/7242 ### Current Behavior client: ab -n1000 -c100 -k http://www.abc.com/ server: aspsix apisix-2.10.0-0 LuaJIT-2.1-20180420 Linux 3.10.0-693.el7.x86_64 #1 SMP Tue Aug 22 21:09:27 UTC

[GitHub] [apisix] spacewander commented on pull request #7231: fix: grpc-transcode request support object array

2022-06-13 Thread GitBox
spacewander commented on PR #7231: URL: https://github.com/apache/apisix/pull/7231#issuecomment-1153551068 Let's make the lint pass with reindex: https://github.com/apache/apisix/runs/6855357196?check_suite_focus=true -- This is an automated message from the Apache Git Service. To respond