[GitHub] [apisix] spacewander commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respon

2022-07-14 Thread GitBox
spacewander commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1185239649 > `grpc-status-details-bin` is encoded with marshalling followed by base64, we need the proto to unmarshall. I have no idea how to upload proto file, and decode it with lua. >

[GitHub] [apisix] ccxhwmy commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
ccxhwmy commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921869205 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the prome

[GitHub] [apisix-java-plugin-runner] MorganArthur commented on issue #165: help request: Java Plugin Runner thorws warning

2022-07-14 Thread GitBox
MorganArthur commented on issue #165: URL: https://github.com/apache/apisix-java-plugin-runner/issues/165#issuecomment-1185236298 /usr/local/apisix-plugin-runner this path is configured by me today,/usr/local/apisix/external_plugin this path was configured by me yesterday. I repackaged the

[GitHub] [apisix] 1renwuruiming commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
1renwuruiming commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185227574 我以什么样的方式来提供route比较合适呢? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [apisix] 1renwuruiming commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
1renwuruiming commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185225693 @juzhiyuan 我需要将后台服务的地址提供给您吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] juzhiyuan commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
juzhiyuan commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185224618 > Also, could you please paste the screenshot and descriptions into this issue? Then more team members could check. 🙏 > > NOTE: Don't forget to erase sensitive content.

[GitHub] [apisix] spacewander commented on issue #7467: feat:As a user, I don't think allowlist and denylist of ua-restriction can be enabled at the same time

2022-07-14 Thread GitBox
spacewander commented on issue #7467: URL: https://github.com/apache/apisix/issues/7467#issuecomment-1185223421 Look like if the allowlist is matched, the denylist will be skipped? The match rule is via regex, so it is possible for a UA to match both allowlist and denylist. -- This is

[GitHub] [apisix] tzssangglass commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
tzssangglass commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185223045 > 我认为这是一个普遍的问题,当你拥有多个请求前缀相似的路由的情况下,新版本的apisix不能很好的转发,你可以模拟这样的场景来进行验证 we have some test cases to cover, see: https://github.com/apache/apisix/blob/master/t/router/radixtree-

[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1212: docs: add prometheus blog

2022-07-14 Thread GitBox
SylviaBABY commented on code in PR #1212: URL: https://github.com/apache/apisix-website/pull/1212#discussion_r921852875 ## website/i18n/zh/docusaurus-plugin-content-blog/2022/07/13/monitor-api-gateway-apisix-with-prometheus.md: ## @@ -0,0 +1,211 @@ +--- +title: "使用 Prometheus 监控

[GitHub] [apisix-website] yzeng25 commented on pull request #1212: docs: add prometheus blog

2022-07-14 Thread GitBox
yzeng25 commented on PR #1212: URL: https://github.com/apache/apisix-website/pull/1212#issuecomment-1185219640 You would need an English markdown file to have the preview ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] spacewander commented on issue #7470: feat: I want to specify xxx.yaml for apisix router config, can apisix start options support this

2022-07-14 Thread GitBox
spacewander commented on issue #7470: URL: https://github.com/apache/apisix/issues/7470#issuecomment-1185218820 We have discussed this before. Using multiple yaml files in the standalone mode is too complex. It would be easier to solve it in an agent which prepares the yaml file. -- Th

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #165: help request: Java Plugin Runner thorws warning

2022-07-14 Thread GitBox
tzssangglass commented on issue #165: URL: https://github.com/apache/apisix-java-plugin-runner/issues/165#issuecomment-1185217450 It looks like you wrote the wrong path. where `apisix-java-plugin-runner.jar`? `/usr/local/apisix-plugin-runner` or `/usr/local/apisix/external_plugin`?

[GitHub] [apisix] 1renwuruiming commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
1renwuruiming commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185216597 我认为这是一个普遍的问题,当你拥有多个请求前缀相似的路由的情况下,新版本的apisix不能很好的转发,你可以模拟这样的场景来进行验证 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix-dashboard] SkyeYoung commented on pull request #2506: feat(plugin): global plugin list in order by state (#2299)

2022-07-14 Thread GitBox
SkyeYoung commented on PR #2506: URL: https://github.com/apache/apisix-dashboard/pull/2506#issuecomment-1185216458 @Wcdaren Any update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] spacewander commented on a diff in pull request #7425: feat: run `apisix init` in directory other than /usr/local/apisix

2022-07-14 Thread GitBox
spacewander commented on code in PR #7425: URL: https://github.com/apache/apisix/pull/7425#discussion_r921849097 ## apisix/cli/apisix.lua: ## @@ -21,11 +21,12 @@ local pkg_path_org = package.path local apisix_home = "/usr/local/apisix" local pkg_cpath = apisix_home .. "/deps/l

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
tzssangglass commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921849211 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the

[GitHub] [apisix-python-plugin-runner] SkyeYoung commented on issue #52: 自定义插件不能使用

2022-07-14 Thread GitBox
SkyeYoung commented on issue #52: URL: https://github.com/apache/apisix-python-plugin-runner/issues/52#issuecomment-1185215735 Can you give me information about the version of APISIX, custom plugins, etc., so that I can help you locate the problem? -- This is an automated message from th

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1114: chore(deps): bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 in /test/e2e

2022-07-14 Thread GitBox
tao12345666333 commented on PR #1114: URL: https://github.com/apache/apisix-ingress-controller/pull/1114#issuecomment-1185215079 wait for CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] tzssangglass commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
tzssangglass commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185214148 > 开会的时候描述过过程了,我不知道还可以怎么描述,是否检查一下版本更新的diff内容更好呢?对比一下2.13.1和之后的版本的路由这边的代码差别,现象是如果只有一个路由,不会出现404的情况,如果出现多个路由,就会无法路由到正确的环境地址 ok, just give me a route for the problem, I will tr

[apisix-ingress-controller] branch dependabot/go_modules/test/e2e/github.com/gorilla/websocket-1.5.0 updated (b8776e17 -> b0408435)

2022-07-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/test/e2e/github.com/gorilla/websocket-1.5.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git omit b8776e17 chore(deps): bump github.c

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1114: chore(deps): bump github.com/gorilla/websocket from 1.4.2 to 1.5.0 in /test/e2e

2022-07-14 Thread GitBox
tao12345666333 commented on PR #1114: URL: https://github.com/apache/apisix-ingress-controller/pull/1114#issuecomment-1185213745 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] tzssangglass commented on issue #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
tzssangglass commented on issue #7468: URL: https://github.com/apache/apisix/issues/7468#issuecomment-1185212787 It seems to be reproducible on this machine, and you can summarize the configuration on this machine into reproducible steps so that I can reproduce it locally to me. -- This

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1159: request help: How to coordinate work between multiple ingress-controller pods.

2022-07-14 Thread GitBox
tao12345666333 commented on issue #1159: URL: https://github.com/apache/apisix-ingress-controller/issues/1159#issuecomment-1185212813 Hi Your description confuses me. Please describe more clearly, including steps to reproduce. In addition, we have not released v1.14 version, p

[GitHub] [apisix] spacewander merged pull request #7465: fix(etcd): check error code in the body

2022-07-14 Thread GitBox
spacewander merged PR #7465: URL: https://github.com/apache/apisix/pull/7465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix-java-plugin-runner] branch main updated: feat: support filter upstream responses (#164)

2022-07-14 Thread tzssangglass
This is an automated email from the ASF dual-hosted git repository. tzssangglass pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/apisix-java-plugin-runner.git The following commit(s) were added to refs/heads/main by this push: new 4f144eb feat: support filt

[apisix] branch master updated (7b6b30f4a -> a04964e2a)

2022-07-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from 7b6b30f4a fix(upstream): http connection was put into https connection pool (#7466) add a04964e2a fix(etcd)

[GitHub] [apisix-java-plugin-runner] tzssangglass closed issue #102: request help: I want to get the upstream response status code。How can I do?

2022-07-14 Thread GitBox
tzssangglass closed issue #102: request help: I want to get the upstream response status code。How can I do? URL: https://github.com/apache/apisix-java-plugin-runner/issues/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [apisix-java-plugin-runner] tzssangglass merged pull request #164: feat: support filter upstream responses

2022-07-14 Thread GitBox
tzssangglass merged PR #164: URL: https://github.com/apache/apisix-java-plugin-runner/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificat

[GitHub] [apisix] tzssangglass commented on issue #7454: clickhouse-logger can't support datetime or date field in clickhouse

2022-07-14 Thread GitBox
tzssangglass commented on issue #7454: URL: https://github.com/apache/apisix/issues/7454#issuecomment-1185210621 > I didn't catch your answer,can you please give me a more information or operation steps? We can add the following code to `clickhouse-logger` to register a custom variab

[GitHub] [apisix] spacewander commented on a diff in pull request #7457: feat(semantic pull request): add action-semantic-pull-request

2022-07-14 Thread GitBox
spacewander commented on code in PR #7457: URL: https://github.com/apache/apisix/pull/7457#discussion_r921843389 ## .github/workflows/semantic.yml: ## @@ -0,0 +1,21 @@ +name: "Lint PR" + +on: + pull_request_target: +types: + - opened + - edited + - synchroniz

[apisix] branch master updated: fix(upstream): http connection was put into https connection pool (#7466)

2022-07-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7b6b30f4a fix(upstream): http connection wa

[GitHub] [apisix] spacewander merged pull request #7466: fix(upstream): http connection was put into https connection pool

2022-07-14 Thread GitBox
spacewander merged PR #7466: URL: https://github.com/apache/apisix/pull/7466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander commented on a diff in pull request #7453: feat: supports dynamic control of whether plugins are running

2022-07-14 Thread GitBox
spacewander commented on code in PR #7453: URL: https://github.com/apache/apisix/pull/7453#discussion_r921840059 ## apisix/plugin.lua: ## @@ -371,6 +375,28 @@ local function trace_plugins_info_for_debug(ctx, plugins) end end +local function meta_filter(plugin_name, plugi

[GitHub] [apisix] lunarwhite commented on a diff in pull request #7456: docs: refactor ua-restriction.md

2022-07-14 Thread GitBox
lunarwhite commented on code in PR #7456: URL: https://github.com/apache/apisix/pull/7456#discussion_r921828660 ## docs/zh/latest/plugins/ua-restriction.md: ## @@ -1,5 +1,11 @@ --- title: ua-restriction +keywords: + - APISIX + - API Gateway + - UA restriction + - ua-restri

[GitHub] [apisix-java-plugin-runner] MorganArthur commented on issue #165: help request: Java Plugin Runner thorws warning

2022-07-14 Thread GitBox
MorganArthur commented on issue #165: URL: https://github.com/apache/apisix-java-plugin-runner/issues/165#issuecomment-1185190116 ![image](https://user-images.githubusercontent.com/24489342/179157093-97e40e4a-a62f-4677-9c62-c62ddd765580.png) 我执行了 chmod 777,restart container again,all

[GitHub] [apisix] wodingyang commented on issue #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
wodingyang commented on issue #7468: URL: https://github.com/apache/apisix/issues/7468#issuecomment-1185185208 ![image](https://user-images.githubusercontent.com/75060224/179155880-22b4c47d-e654-4e69-b80d-a890161001fe.png) 对比了一下3台测试机器,确实从13点45-15点20压测程序可能停了没有日志,但是另外两台机器会生成14点的日志文件并将8-14点

[GitHub] [apisix] wodingyang commented on issue #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
wodingyang commented on issue #7468: URL: https://github.com/apache/apisix/issues/7468#issuecomment-1185179708 我具体查看了下日志,可能是我这边停了一段时间测试程序,没有生成14的日志问题我再跟踪下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[apisix] branch dependabot/github_actions/actions/setup-node-3.4.1 created (now bbfec5286)

2022-07-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/setup-node-3.4.1 in repository https://gitbox.apache.org/repos/asf/apisix.git at bbfec5286 build(deps): bump actions/setup-node from 3.4.0 to 3.4.1 N

[GitHub] [apisix] dependabot[bot] opened a new pull request, #7471: build(deps): bump actions/setup-node from 3.4.0 to 3.4.1

2022-07-14 Thread GitBox
dependabot[bot] opened a new pull request, #7471: URL: https://github.com/apache/apisix/pull/7471 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.4.0 to 3.4.1. Release notes Sourced from https://github.com/actions/setup-node/releases";>actions/setup-node's

[GitHub] [apisix] wodingyang commented on issue #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
wodingyang commented on issue #7468: URL: https://github.com/apache/apisix/issues/7468#issuecomment-1185173697 再补充一下,另两台机器上的实例也在15点19分做了重启,但是并没有丢失数据。为了测试日志问题这3台机器也没有其他应用进程 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] wodingyang commented on issue #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
wodingyang commented on issue #7468: URL: https://github.com/apache/apisix/issues/7468#issuecomment-1185172969 这是在自己测试用服务器上测试的,所以并没有文件大小限制与清理。 补充下: 为了测试该问题用了三台一样环境的服务器并且严格控制了流量,每个实例一分钟平均接收3个请求,所以每个access文件大小基本在130320字节,而根据7月11日20点生成的文件大小判断是丢失了数据的,具体查看 2022-07-11_20-00-00__access.log文件

[GitHub] [apisix] lunarwhite commented on a diff in pull request #7456: docs: refactor ua-restriction.md

2022-07-14 Thread GitBox
lunarwhite commented on code in PR #7456: URL: https://github.com/apache/apisix/pull/7456#discussion_r921807614 ## docs/zh/latest/plugins/ua-restriction.md: ## @@ -23,22 +29,26 @@ title: ua-restriction ## 描述 -`ua-restriction` 可以通过将指定 `User-Agent` 列入白名单或黑名单的方式来限制对服务或接口的访问。 +

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #165: help request: Java Plugin Runner thorws warning

2022-07-14 Thread GitBox
tzssangglass commented on issue #165: URL: https://github.com/apache/apisix-java-plugin-runner/issues/165#issuecomment-1185134946 > 2022/07/14 05:46:45 [error] 58#2945: lua pipe child execvp() failed while executing java (2: No such file or directory) APISIX cannot find the jar file

[GitHub] [apisix] soulbird commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
soulbird commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921778510 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the prom

[GitHub] [apisix] soulbird commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
soulbird commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921778402 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the prom

[GitHub] [apisix] tzssangglass commented on issue #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
tzssangglass commented on issue #7468: URL: https://github.com/apache/apisix/issues/7468#issuecomment-1185134024 Is there a timed task on the instance that will clean up log files larger than xx size? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] tzssangglass commented on issue #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
tzssangglass commented on issue #7468: URL: https://github.com/apache/apisix/issues/7468#issuecomment-1185133483 It is strange, if there is a problem with the log-rotate plugin, all instances should lose log files. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [apisix] wyaow opened a new issue, #7470: feat: I want to specify xxx.yaml for apisix router config, can apisix start options support this

2022-07-14 Thread GitBox
wyaow opened a new issue, #7470: URL: https://github.com/apache/apisix/issues/7470 ### Description Here, i talk about stand alone mode. we all know apisix.yaml is the only one router config file. can we support multi config file. and when we start apisix, we could specify the ro

[GitHub] [apisix] 1renwuruiming commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
1renwuruiming commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185132722 开会的时候描述过过程了,我不知道还可以怎么描述,是否检查一下版本更新的diff内容更好呢?对比一下2.13.1和之后的版本的路由这边的代码差别,现象是如果只有一个路由,不会出现404的情况,如果出现多个路由,就会无法路由到正确的环境地址 -- This is an automated message from the Apache Git Serv

[GitHub] [apisix] tzssangglass commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
tzssangglass commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185131611 Please provide the minimum reproducible steps -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix] wyaow opened a new issue, #7469: How to config load balance in apisix.yam in standalone mode

2022-07-14 Thread GitBox
wyaow opened a new issue, #7469: URL: https://github.com/apache/apisix/issues/7469 ### Description routes: - uri: /hello service_id: 1 services: - id: 1 upstream_id: 2 upstreams: - id: 2 nodes:

[GitHub] [apisix] juzhiyuan commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
juzhiyuan commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185131394 > 看到其他的issue中也有提到这样的现象 Could you please paste those issues here? Then I will cc maintainers to check the difference. -- This is an automated message from the Apache Git Ser

[GitHub] [apisix-docker] tzssangglass commented on issue #332: how to use https and port 9443?

2022-07-14 Thread GitBox
tzssangglass commented on issue #332: URL: https://github.com/apache/apisix-docker/issues/332#issuecomment-1185130884 > failed to find any SSL certificate by SNI: telaga.solu.co.id you need to add an SSL object and set snis as `telaga.solu.co.id`, ref: https://github.com/apache/apisix

[GitHub] [apisix] tzssangglass commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respo

2022-07-14 Thread GitBox
tzssangglass commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1185129856 > @tokers @tzssangglass do you agree with this plan ? I'm not familiar with gRPC, cc @spacewander @bzp2010 -- This is an automated message from the Apache Git Service. T

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a diff in pull request #164: feat: support filter upstream responses

2022-07-14 Thread GitBox
tzssangglass commented on code in PR #164: URL: https://github.com/apache/apisix-java-plugin-runner/pull/164#discussion_r921762922 ## runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/PostResponse.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
tzssangglass commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921761958 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the

[GitHub] [apisix] hushaojun-0801 closed issue #7462: help request: How can one route support two Ou

2022-07-14 Thread GitBox
hushaojun-0801 closed issue #7462: help request: How can one route support two Ou URL: https://github.com/apache/apisix/issues/7462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [apisix] hushaojun-0801 commented on issue #7462: help request: How can one route support two Ou

2022-07-14 Thread GitBox
hushaojun-0801 commented on issue #7462: URL: https://github.com/apache/apisix/issues/7462#issuecomment-1185114724 ok tks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix] tzssangglass commented on issue #7462: help request: How can one route support two Ou

2022-07-14 Thread GitBox
tzssangglass commented on issue #7462: URL: https://github.com/apache/apisix/issues/7462#issuecomment-1185111260 Not supported now, `ou` defined on the router and find consumer based on it, can't define two `ou` on the router. -- This is an automated message from the Apache Git Se

[GitHub] [apisix-ingress-controller] xuminwlt opened a new issue, #1159: request help: How to coordinate work between multiple ingress-controller pods.

2022-07-14 Thread GitBox
xuminwlt opened a new issue, #1159: URL: https://github.com/apache/apisix-ingress-controller/issues/1159 ### Issue description When we tested, a cluster deployed 2 apisix and 2 ingress pods, found that 1 ingress did not work, and stopped 1 ingress pod, the other ingress pod still did

[GitHub] [apisix] wodingyang opened a new issue, #7468: bug: log-rotate切割丢失文件

2022-07-14 Thread GitBox
wodingyang opened a new issue, #7468: URL: https://github.com/apache/apisix/issues/7468 ### Current Behavior 测试环境中开启log-rotate插件,配置如下: plugin_attr: log-rotate: interval: 21600# rotate interval (unit: second) max_kept: 20 # max number of log files will be k

[GitHub] [apisix] 1renwuruiming commented on issue #7449: help request: router dispatch not working as expected

2022-07-14 Thread GitBox
1renwuruiming commented on issue #7449: URL: https://github.com/apache/apisix/issues/7449#issuecomment-1185107210 我降低版本到2.13.1就没有这样的问题了,所以是否是最近几个版本更改了路由的匹配规则导致的呢?看到其他的issue中也有提到这样的现象 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix] soulbird commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
soulbird commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921750872 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the prom

[GitHub] [apisix] soulbird commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
soulbird commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921750872 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the prom

[GitHub] [apisix-java-plugin-runner] soulbird commented on a diff in pull request #164: feat: support filter upstream responses

2022-07-14 Thread GitBox
soulbird commented on code in PR #164: URL: https://github.com/apache/apisix-java-plugin-runner/pull/164#discussion_r921729477 ## runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/PostResponse.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [apisix] juzhiyuan commented on issue #7464: help request: how to publish a http/https website, like Nginx/Apache?

2022-07-14 Thread GitBox
juzhiyuan commented on issue #7464: URL: https://github.com/apache/apisix/issues/7464#issuecomment-1185096417 This question has been asked many times 😄 I will add this to our documentation. For now, the quickest way is `injecting Nginx snippet to APISIX`. Please read https://apisix.apache.

[GitHub] [apisix] tzssangglass commented on issue #7467: feat:As a user, I don't think allowlist and denylist of ua-restriction can be enabled at the same time

2022-07-14 Thread GitBox
tzssangglass commented on issue #7467: URL: https://github.com/apache/apisix/issues/7467#issuecomment-1185089036 What if allowlist and denylist are both on, ua-restriction only uses allowlist, and User-Agents that are not in allowlist are rejected? -- This is an automated message from the

[GitHub] [apisix] ccxhwmy commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
ccxhwmy commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921739567 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the prome

[GitHub] [apisix] caozhi6655 commented on issue #7454: clickhouse-logger can't support datetime or date field in clickhouse

2022-07-14 Thread GitBox
caozhi6655 commented on issue #7454: URL: https://github.com/apache/apisix/issues/7454#issuecomment-1185086293 > I didn't catch your answer,can you please give me a more information or operation steps? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-14 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1185084735 @tokers @tzssangglass do you agree with this plan ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7456: docs: refactor ua-restriction.md

2022-07-14 Thread GitBox
SylviaBABY commented on code in PR #7456: URL: https://github.com/apache/apisix/pull/7456#discussion_r921736120 ## docs/zh/latest/plugins/ua-restriction.md: ## @@ -23,22 +29,26 @@ title: ua-restriction ## 描述 -`ua-restriction` 可以通过将指定 `User-Agent` 列入白名单或黑名单的方式来限制对服务或接口的访问。 +

[GitHub] [apisix-docker] rizkyarmanto commented on issue #332: how to use https and port 9443?

2022-07-14 Thread GitBox
rizkyarmanto commented on issue #332: URL: https://github.com/apache/apisix-docker/issues/332#issuecomment-1185082901 i have configure ssl from dashboard and enable ssl in apisix_conf/config.yaml. what can i do next? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] SylviaBABY commented on a diff in pull request #7455: docs: refactor referer-restriction.md

2022-07-14 Thread GitBox
SylviaBABY commented on code in PR #7455: URL: https://github.com/apache/apisix/pull/7455#discussion_r921734794 ## docs/zh/latest/plugins/referer-restriction.md: ## @@ -65,37 +74,52 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f13 ## 测试插件

[GitHub] [apisix-docker] rizkyarmanto commented on issue #332: how to use https and port 9443?

2022-07-14 Thread GitBox
rizkyarmanto commented on issue #332: URL: https://github.com/apache/apisix-docker/issues/332#issuecomment-1185081866 i use cert from openssl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [apisix-docker] rizkyarmanto commented on issue #332: how to use https and port 9443?

2022-07-14 Thread GitBox
rizkyarmanto commented on issue #332: URL: https://github.com/apache/apisix-docker/issues/332#issuecomment-1185081672 i send https://telaga.solu.co.id:9443/api , but i get error: [error] 47#47: 3033 [lua] radixtree_sni.lua:145: match_and_set(): failed to find any SSL certificate by SNI: tel

[GitHub] [apisix] tzssangglass commented on issue #7464: help request: can APISIX setup to publish a http/https websit, like Nginx/Apache?

2022-07-14 Thread GitBox
tzssangglass commented on issue #7464: URL: https://github.com/apache/apisix/issues/7464#issuecomment-1185081663 we can start by: https://apisix.apache.org/docs/apisix/getting-started/ BTW: APISIX is an API Gateway and it is not recommended to use it with proxy static resources (altho

[GitHub] [apisix] hf400159 commented on a diff in pull request #7456: docs: refactor ua-restriction.md

2022-07-14 Thread GitBox
hf400159 commented on code in PR #7456: URL: https://github.com/apache/apisix/pull/7456#discussion_r921734009 ## docs/zh/latest/plugins/ua-restriction.md: ## @@ -1,5 +1,11 @@ --- title: ua-restriction +keywords: + - APISIX + - API Gateway + - UA restriction + - ua-restrict

[GitHub] [apisix] hf400159 commented on a diff in pull request #7456: docs: refactor ua-restriction.md

2022-07-14 Thread GitBox
hf400159 commented on code in PR #7456: URL: https://github.com/apache/apisix/pull/7456#discussion_r921188538 ## docs/en/latest/plugins/ua-restriction.md: ## @@ -2,7 +2,7 @@ title: ua-restriction keywords: - APISIX - - Plugin + - API Gateway - UA restriction - ua-re

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2524: After add 'Advanced Routing Matching Conditions' of a route,it will appears nothing

2022-07-14 Thread GitBox
Baoyuantop commented on issue #2524: URL: https://github.com/apache/apisix-dashboard/issues/2524#issuecomment-1185080810 It has been fixed in https://github.com/apache/apisix-dashboard/pull/2440 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] Baoyuantop commented on a diff in pull request #2506: feat(plugin): global plugin list in order by state (#2299)

2022-07-14 Thread GitBox
Baoyuantop commented on code in PR #2506: URL: https://github.com/apache/apisix-dashboard/pull/2506#discussion_r921730490 ## web/src/components/Plugin/PluginPage.tsx: ## @@ -87,6 +86,10 @@ const PluginPage: React.FC = ({ }); setTypeList(categoryList); }); + }

[GitHub] [apisix] soulbird commented on a diff in pull request #7412: feat(promethues): add ngx.shared.DICT status

2022-07-14 Thread GitBox
soulbird commented on code in PR #7412: URL: https://github.com/apache/apisix/pull/7412#discussion_r921727002 ## t/plugin/prometheus.t: ## @@ -632,3 +632,53 @@ GET /apisix/prometheus/metrics qr/apisix_/ --- response_body_unlike eval qr/etcd/ + + + +=== TEST 42: fetch the prom

[GitHub] [apisix] michaelh1355 commented on issue #7464: help request: can APISIX setup to publish a http/https websit, like Nginx/Apache?

2022-07-14 Thread GitBox
michaelh1355 commented on issue #7464: URL: https://github.com/apache/apisix/issues/7464#issuecomment-1185068573 Hi Alex, thank you for your reply quickly. my APISIX and NGINX is running in the same server. as NGINX is running with our website and I am searching how to replace it wi

[GitHub] [apisix-helm-chart] tokers commented on issue #313: help request: Can't enable plugin authz-casdoor

2022-07-14 Thread GitBox
tokers commented on issue #313: URL: https://github.com/apache/apisix-helm-chart/issues/313#issuecomment-1185066205 @tao12345666333 Looks like the `authz-casdoor` plugin was enabled in the `plugins` field. @airclear Could you try to paste the ConfigMap object `apisix` here, that's c

[GitHub] [apisix-dashboard] iori0758 opened a new issue, #2524: After add 'Advanced Routing Matching Conditions' of a route,it will appears nothing

2022-07-14 Thread GitBox
iori0758 opened a new issue, #2524: URL: https://github.com/apache/apisix-dashboard/issues/2524 ### Issue description i want add some routing matching conditions,but it doesn't work, after click confirm button, it displays white page ### Expected behavior save routing ma

[GitHub] [apisix] tokers commented on issue #7467: feat:As a user, I don't think allowlist and denylist of ua-restriction can be enabled at the same time

2022-07-14 Thread GitBox
tokers commented on issue #7467: URL: https://github.com/apache/apisix/issues/7467#issuecomment-1185063430 Fair enough. But if we make `allowlist` and `denylist` exclusive, then this is a broken change. We need to evaluate it. -- This is an automated message from the Apache Git Service. T

[GitHub] [apisix] 840963657 opened a new issue, #7467: feat:As a user, I don't think allowlist and denylist of ua-restriction can be enabled at the same time

2022-07-14 Thread GitBox
840963657 opened a new issue, #7467: URL: https://github.com/apache/apisix/issues/7467 ### Description I found other restriction plugin has a logic:Either one of whitelist or blacklist attribute must be specified。 But in ua-restriction, both allowlist and denylist can be used on th

[GitHub] [apisix] ccxhwmy commented on issue #7164: help request: Alternatives to Semantic Pull Requests

2022-07-14 Thread GitBox
ccxhwmy commented on issue #7164: URL: https://github.com/apache/apisix/issues/7164#issuecomment-1185043656 > @ccxhwmy submodle is more suitable. I found that doing `git clone` in the github workflows still works, Would you tell me why `git submodule` is more suitable? I want to learn

[GitHub] [apisix] ccxhwmy commented on a diff in pull request #7457: feat(semantic pull request): add action-semantic-pull-request

2022-07-14 Thread GitBox
ccxhwmy commented on code in PR #7457: URL: https://github.com/apache/apisix/pull/7457#discussion_r921696990 ## .github/workflows/semantic.yml: ## @@ -0,0 +1,21 @@ +name: "Lint PR" + +on: + pull_request_target: +types: + - opened + - edited + - synchronize +

[GitHub] [apisix-ingress-controller] AlinsRan closed issue #1077: bug: run suit-ingress e2e unstable.

2022-07-14 Thread GitBox
AlinsRan closed issue #1077: bug: run suit-ingress e2e unstable. URL: https://github.com/apache/apisix-ingress-controller/issues/1077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [apisix-ingress-controller] AlinsRan opened a new issue, #1077: bug: run suit-ingress e2e unstable.

2022-07-14 Thread GitBox
AlinsRan opened a new issue, #1077: URL: https://github.com/apache/apisix-ingress-controller/issues/1077 ### Issue description Running e2e on the local machine or CI is particularly unstable and occasionally failed. It is stable for a single use case, but it is mutually exclusive

[GitHub] [apisix] vyvyan2010 commented on issue #6996: feat: As a user, I want to see `grpc-status-details-bin` in response body in case an error, so that I avoid parsing header to read error respons

2022-07-14 Thread GitBox
vyvyan2010 commented on issue #6996: URL: https://github.com/apache/apisix/issues/6996#issuecomment-1184590468 I'm going to add 2 configuration items 1. `cpy_details_to_body`: if true, copy `grpc-status-details-bin` to response body, the one in response header won't be deleted {

[GitHub] [apisix] tzssangglass commented on pull request #7451: docs: improve OpenTelemetry documentation

2022-07-14 Thread GitBox
tzssangglass commented on PR #7451: URL: https://github.com/apache/apisix/pull/7451#issuecomment-1184535940 > may I know currently if it supports Logs and Metrics not support yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] tzssangglass commented on issue #7454: clickhouse-logger can't support datetime or date field in clickhouse

2022-07-14 Thread GitBox
tzssangglass commented on issue #7454: URL: https://github.com/apache/apisix/issues/7454#issuecomment-1184534058 > It must match strictly i think,and there is no other varible's format is like `2000-01-01 12:00:00` Then you can modify the format of the regular extraction. AFAIK, the c

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #918: feat: support stream route plugin

2022-07-14 Thread GitBox
tao12345666333 commented on PR #918: URL: https://github.com/apache/apisix-ingress-controller/pull/918#issuecomment-1184523455 > Sorry I've been a little busy lately, I'll improve this PR in this week. @Belyenochi friendly reminder :smile_cat: -- This is an automated message from

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1158: test: keep namespace when test failed in dev mod

2022-07-14 Thread GitBox
tao12345666333 commented on PR #1158: URL: https://github.com/apache/apisix-ingress-controller/pull/1158#issuecomment-1184520406 LGTM also cc @AlinsRan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1157: bug: `resolveGranularity` should be considered in upstream id generation

2022-07-14 Thread GitBox
tao12345666333 commented on issue #1157: URL: https://github.com/apache/apisix-ingress-controller/issues/1157#issuecomment-1184516337 If we want to fix this problem, we must design to the regeneration of upstream_id. This will be a huge breaking change. When upgrading, users need to

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1158: test: keep namespace when test failed in dev mod

2022-07-14 Thread GitBox
codecov-commenter commented on PR #1158: URL: https://github.com/apache/apisix-ingress-controller/pull/1158#issuecomment-1184483408 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix] hf400159 commented on a diff in pull request #7455: docs: refactor referer-restriction.md

2022-07-14 Thread GitBox
hf400159 commented on code in PR #7455: URL: https://github.com/apache/apisix/pull/7455#discussion_r921187353 ## docs/zh/latest/plugins/referer-restriction.md: ## @@ -23,23 +29,26 @@ title: referer-restriction ## 描述 -`referer-restriction` 插件可以根据 Referer 请求头限制访问。 +`referer-r

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #1151: docs: add more YAML configuration samples

2022-07-14 Thread GitBox
tao12345666333 closed issue #1151: docs: add more YAML configuration samples URL: https://github.com/apache/apisix-ingress-controller/issues/1151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1151: docs: add more YAML configuration samples

2022-07-14 Thread GitBox
tao12345666333 commented on issue #1151: URL: https://github.com/apache/apisix-ingress-controller/issues/1151#issuecomment-1184477788 We can use #1071 for tracking. I will close this one. If you have any other documentation suggestions please add them in #1071 Thanks

  1   2   >