membphis commented on PR #8379:
URL: https://github.com/apache/apisix/pull/8379#issuecomment-1324674372
I like this PR which removed a lot of code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new ab4fe8837 refactor(consumer): expose create
spacewander merged PR #8379:
URL: https://github.com/apache/apisix/pull/8379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@a
spacewander commented on code in PR #8219:
URL: https://github.com/apache/apisix/pull/8219#discussion_r1030109188
##
apisix/admin/init.lua:
##
@@ -15,6 +15,7 @@
-- limitations under the License.
--
local require = require
+local filter = require("apisix.router").filter
Revie
spacewander commented on code in PR #8159:
URL: https://github.com/apache/apisix/pull/8159#discussion_r1030108118
##
apisix/plugins/prometheus/exporter.lua:
##
@@ -80,9 +80,14 @@ local function extra_labels(name, ctx)
for _, kv in ipairs(labels) do
local va
spacewander commented on issue #8381:
URL: https://github.com/apache/apisix/issues/8381#issuecomment-1324653918
We need to modify the code to record the time when we start to count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
soulbird commented on code in PR #8379:
URL: https://github.com/apache/apisix/pull/8379#discussion_r1030099319
##
apisix/plugins/jwt-auth.lua:
##
@@ -435,8 +412,7 @@ function _M.rewrite(conf, ctx)
return 401, {message = "Missing related consumer"}
end
-local
tzssangglass commented on issue #8381:
URL: https://github.com/apache/apisix/issues/8381#issuecomment-1324645779
I think this could be a good first issue. cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
spacewander commented on code in PR #8379:
URL: https://github.com/apache/apisix/pull/8379#discussion_r1030097568
##
apisix/plugins/jwt-auth.lua:
##
@@ -435,8 +412,7 @@ function _M.rewrite(conf, ctx)
return 401, {message = "Missing related consumer"}
end
-loc
spacewander commented on code in PR #8374:
URL: https://github.com/apache/apisix/pull/8374#discussion_r1030093849
##
apisix/init.lua:
##
@@ -724,6 +724,7 @@ local function healthcheck_passive(api_ctx)
port or api_ctx.balancer_port,
tzssangglass commented on code in PR #8374:
URL: https://github.com/apache/apisix/pull/8374#discussion_r1030093285
##
apisix/init.lua:
##
@@ -724,6 +724,7 @@ local function healthcheck_passive(api_ctx)
port or api_ctx.balancer_port,
tzssangglass commented on issue #8376:
URL: https://github.com/apache/apisix/issues/8376#issuecomment-1324637448
> I think the documentation is wrong, about how to develop plug-ins. The
custom plugin should be declared in config-default.yaml, not config.yaml.
The documentation is corr
tzssangglass commented on PR #8379:
URL: https://github.com/apache/apisix/pull/8379#issuecomment-1324635511
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
harmseru opened a new issue, #8381:
URL: https://github.com/apache/apisix/issues/8381
### Description
- limit-count plugin does not communicate the `X-RateLimit-Reset` header
only `X-RateLimit-Remaining` and `X-RateLimit-Limit`
- There are no `X-RateLimit-*` headers communicated on
Fabriceli opened a new pull request, #8380:
URL: https://github.com/apache/apisix/pull/8380
### Description
As I mentioned previously in #8371 , my team submit our `consul` discovery
module
### Checklist
- [x] I have explained the need for this PR and the problem it
soulbird commented on code in PR #8379:
URL: https://github.com/apache/apisix/pull/8379#discussion_r1030056237
##
apisix/consumer.lua:
##
@@ -94,6 +97,26 @@ function _M.consumers()
end
+local function create_consume_cache(consumers_conf, key_attr, consumer_names)
+core.
840963657 commented on code in PR #8374:
URL: https://github.com/apache/apisix/pull/8374#discussion_r1030036297
##
apisix/init.lua:
##
@@ -724,6 +724,7 @@ local function healthcheck_passive(api_ctx)
port or api_ctx.balancer_port,
spacewander commented on code in PR #8379:
URL: https://github.com/apache/apisix/pull/8379#discussion_r1030034730
##
apisix/consumer.lua:
##
@@ -94,6 +97,26 @@ function _M.consumers()
end
+local function create_consume_cache(consumers_conf, key_attr, consumer_names)
+co
scoolor closed issue #8376: request help: custom plugins developed do not take
effect
URL: https://github.com/apache/apisix/issues/8376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
scoolor commented on issue #8376:
URL: https://github.com/apache/apisix/issues/8376#issuecomment-1324552512
I think the documentation is wrong, about how to develop plug-ins. The
custom plugin should be declared in config-default.yaml, not config.yaml. Then
works. @tzssangglass
--
This
soulbird opened a new pull request, #8379:
URL: https://github.com/apache/apisix/pull/8379
### Description
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new feat
kizy008 commented on issue #7839:
URL: https://github.com/apache/apisix/issues/7839#issuecomment-1324503295
您的邮件我已收到，我会尽快给您回复，谢谢！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
from c49be6665 fix(log-rotate): max_kept works on compression files (#8366)
add 6c6b0771f fix(file-loger): use no
spacewander merged PR #7884:
URL: https://github.com/apache/apisix/pull/7884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@a
spacewander closed issue #7839: bug: [file-logger] two log messages mix-output
in one line（两条不同的日志混合在一行输出）
URL: https://github.com/apache/apisix/issues/7839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
spacewander commented on code in PR #8374:
URL: https://github.com/apache/apisix/pull/8374#discussion_r1029990705
##
apisix/init.lua:
##
@@ -724,6 +724,7 @@ local function healthcheck_passive(api_ctx)
port or api_ctx.balancer_port,
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c49be6665 fix(log-rotate): max_kept works o
spacewander merged PR #8366:
URL: https://github.com/apache/apisix/pull/8366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@a
spacewander closed issue #8343: bug: log-rotate max_kept doesn't work if
enable_compression: true
URL: https://github.com/apache/apisix/issues/8343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander opened a new pull request, #8377:
URL: https://github.com/apache/apisix/pull/8377
Signed-off-by: spacewander
### Description
Fixes # (issue)
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [ ] I have
lingsamuel commented on code in PR #1471:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1471#discussion_r1029975960
##
pkg/types/apisix/v1/plugin_types.go:
##
@@ -177,3 +191,46 @@ func (p *Headers) DeepCopy() *Headers {
p.DeepCopyInto(out)
return
scoolor commented on issue #8376:
URL: https://github.com/apache/apisix/issues/8376#issuecomment-1324456316
First of all, thank you for your reply! @tzssangglass
The permissions are as follows:
https://user-images.githubusercontent.com/20853694/203455969-3cea546d-aa50-4223-b911-675
tzssangglass commented on issue #8376:
URL: https://github.com/apache/apisix/issues/8376#issuecomment-1324451013
Are there any other errors in the logs?
Check the permissions of your plugin files.
--
This is an automated message from the Apache Git Service.
To respond to the message
tokers commented on PR #7884:
URL: https://github.com/apache/apisix/pull/7884#issuecomment-1324449830
> > @tokers do you agree with @spacewander ?
> > ```
> > Since the original code doesn't use buffer (it flushes the buffer
immediately), I think we can focus on solving the bug first.
tzssangglass commented on issue #8376:
URL: https://github.com/apache/apisix/issues/8376#issuecomment-1324449207
have you done with
> To enable your plugin, copy this plugin list into conf/config.yaml, and
add your plugin name. For instance:
> ```
> plugins: # copied from config
tokers commented on PR #7884:
URL: https://github.com/apache/apisix/pull/7884#issuecomment-1324449014
> @tokers do you agree with @spacewander ?
>
> ```
> Since the original code doesn't use buffer (it flushes the buffer
immediately), I think we can focus on solving the bug first.
tzssangglass commented on issue #8375:
URL: https://github.com/apache/apisix/issues/8375#issuecomment-1324447220
> there is no interface to find out,
try with:
https://github.com/apache/apisix/blob/master/docs/en/latest/discovery.md#embedded-control-api-for-debugging
--
This is an
scoolor opened a new issue, #8376:
URL: https://github.com/apache/apisix/issues/8376
### Current Behavior
version: 3.0.0
apisix config: apisix_conf/config.yaml
`apisix:
node_listen: 9080 # APISIX listening port
enable_ipv6: false
enable_con
github-actions[bot] closed pull request #910: fix: Fix response error rate
expression on grafana
URL: https://github.com/apache/apisix-ingress-controller/pull/910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
github-actions[bot] commented on PR #910:
URL:
https://github.com/apache/apisix-ingress-controller/pull/910#issuecomment-1324436958
This pull request/issue has been closed due to lack of activity. If you
think that is incorrect, or the pull request requires review, you can revive
the PR at
tao12345666333 commented on issue #1472:
URL:
https://github.com/apache/apisix-ingress-controller/issues/1472#issuecomment-1324435556
SGTM!
This is something that gets overlooked.
we need to implement it.
Are you interested in making it happen?
--
This is an automated mes
This is an automated email from the ASF dual-hosted git repository.
yilinzeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 1aa4dc9952e docs: add Tencent Bluekin
yzeng25 merged PR #1413:
URL: https://github.com/apache/apisix-website/pull/1413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
This is an automated email from the ASF dual-hosted git repository.
young pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-website.git
The following commit(s) were added to refs/heads/master by this push:
new 72bd935c197 chore: update zh poster card
SkyeYoung merged PR #1419:
URL: https://github.com/apache/apisix-website/pull/1419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
DengYongJie666 closed issue #400: 请求帮助：apisix-dashboard
无法连接外部etcd，url解析错误，导致连接超时
URL: https://github.com/apache/apisix-helm-chart/issues/400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
DengYongJie666 commented on issue #400:
URL:
https://github.com/apache/apisix-helm-chart/issues/400#issuecomment-1324417074
@dyrnq This issue has been resolved and dashboard needs to add certs to
deployment.yaml
--
This is an automated message from the Apache Git Service.
To respond to
tokers commented on issue #8372:
URL: https://github.com/apache/apisix/issues/8372#issuecomment-1324415337
> > > When I tried to use the plugins' traffic-split, it didn't work.
> >
> >
> > Could you share the reason that you still use the traffic-split plugin
even we have a better
marksugar commented on issue #8372:
URL: https://github.com/apache/apisix/issues/8372#issuecomment-1324022355
> > When I tried to use the plugins' traffic-split, it didn't work.
>
> Could you share the reason that you still use the traffic-split plugin
even we have a better way to sup
tao12345666333 commented on issue #395:
URL:
https://github.com/apache/apisix-helm-chart/issues/395#issuecomment-1323826860
let me add this to my TODO list.
I will back tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wolgod opened a new issue, #8375:
URL: https://github.com/apache/apisix/issues/8375
### Description
I use kubernetes service discovery ,i wan’t to get the endpoints from the
apisix，Now apisix get the endpoints from apiserver are stored in the dict,
there is no interface to find out,
netlify[bot] commented on PR #1419:
URL: https://github.com/apache/apisix-website/pull/1419#issuecomment-1323464576
### 👷 Deploy Preview for *apache-apisix*
processing.
| Name | Link |
|-||
|🔨 Latest commit |
0160ef69
reeseliu715 opened a new pull request, #1419:
URL: https://github.com/apache/apisix-website/pull/1419
add poster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
abalage commented on issue #395:
URL:
https://github.com/apache/apisix-helm-chart/issues/395#issuecomment-1323430792
Do you have any estimation about when a fix could be released? It makes
manually editing the ConfigMap after each deploy quite annoying.
Thank you.
--
This is an autom
github-actions[bot] commented on issue #5587:
URL: https://github.com/apache/apisix/issues/5587#issuecomment-1323408962
This issue has been closed due to lack of activity. If you think that is
incorrect, or the issue requires additional review, you can revive the issue at
any time.
--
Th
github-actions[bot] commented on issue #5561:
URL: https://github.com/apache/apisix/issues/5561#issuecomment-1323408854
This issue has been closed due to lack of activity. If you think that is
incorrect, or the issue requires additional review, you can revive the issue at
any time.
--
Th
github-actions[bot] closed issue #5535: Route and Upstream's concepts are mixed
and not clear
URL: https://github.com/apache/apisix/issues/5535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
github-actions[bot] commented on issue #5590:
URL: https://github.com/apache/apisix/issues/5590#issuecomment-1323409010
This issue has been closed due to lack of activity. If you think that is
incorrect, or the issue requires additional review, you can revive the issue at
any time.
--
Th
github-actions[bot] closed issue #5590: request help: cannot configure
ssl_ceipher for a single domain
URL: https://github.com/apache/apisix/issues/5590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] closed issue #5587: request help: lua-resty-healthcheck
support configuration of a minimum number of reserved nodes？
URL: https://github.com/apache/apisix/issues/5587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
github-actions[bot] closed issue #5579: request help: a forward plugin for api
gw
URL: https://github.com/apache/apisix/issues/5579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
github-actions[bot] commented on issue #5579:
URL: https://github.com/apache/apisix/issues/5579#issuecomment-1323408927
This issue has been closed due to lack of activity. If you think that is
incorrect, or the issue requires additional review, you can revive the issue at
any time.
--
Th
github-actions[bot] closed issue #5561: request help: I want to add a new
parameter B to the request based on parameter A, and then customize the
distribution based on parameter B
URL: https://github.com/apache/apisix/issues/5561
--
This is an automated message from the Apache Git Service.
abalage closed issue #396: ingress-controller logs admin token in plaint text
URL: https://github.com/apache/apisix-helm-chart/issues/396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
abalage commented on issue #396:
URL:
https://github.com/apache/apisix-helm-chart/issues/396#issuecomment-1323405323
Thanks for the hint. It makes sense as the logs is created by the ingress
controller not by the helm chart.
--
This is an automated message from the Apache Git Service.
To
abalage opened a new issue, #1472:
URL: https://github.com/apache/apisix-ingress-controller/issues/1472
### Issue description
I have changed the default admin key in apisix and apisix-ingress-controller.
Checking the logs of the ingress controller it logs the new admin token in
pla
840963657 commented on PR #8374:
URL: https://github.com/apache/apisix/pull/8374#issuecomment-1323394002
when resp_status == status, there is no need to perform other loop
operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
xionghanhan commented on issue #8373:
URL: https://github.com/apache/apisix/issues/8373#issuecomment-1323387969
好的，感谢解答疑惑，希望可以越做越好，支持一下哈。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
840963657 opened a new pull request, #8374:
URL: https://github.com/apache/apisix/pull/8374
### Description
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new fea
tokers commented on issue #8373:
URL: https://github.com/apache/apisix/issues/8373#issuecomment-1323380096
The retry feature is not supported yet for grpc @xionghanhan .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tokers commented on issue #8372:
URL: https://github.com/apache/apisix/issues/8372#issuecomment-1323379037
> When I tried to use the plugins' traffic-split, it didn't work.
Could you share the reason that you still use the traffic-split plugin even
we have a better way to support the
tzssangglass commented on issue #8372:
URL: https://github.com/apache/apisix/issues/8372#issuecomment-1323371303
It looks like the yaml configuration is formatted incorrectly rather than
the plugin not taking effect?
--
This is an automated message from the Apache Git Service.
To respond
tzssangglass commented on issue #7862:
URL: https://github.com/apache/apisix/issues/7862#issuecomment-1323368394
ref: https://github.com/apache/apisix/issues/8229#issuecomment-1299698923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
tzssangglass commented on issue #8373:
URL: https://github.com/apache/apisix/issues/8373#issuecomment-1323364286
Maybe we need to support `grpc_next_upstream`, and
`grpc_next_upstream_timeout` ref:
http://nginx.org/en/docs/http/ngx_http_grpc_module.html#grpc_next_upstream_timeout
--
tzssangglass commented on code in PR #8366:
URL: https://github.com/apache/apisix/pull/8366#discussion_r1029035295
##
t/plugin/log-rotate2.t:
##
@@ -173,3 +176,35 @@ plugin_attr:
}
--- response_body
passed
+
+
+
+=== TEST 5: max_kept effective on compression files
+--- ex
75 matches
Mail list logo
