[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437990998 Indeed, there are some challenge for me. I tried to see the code there are consul_sub

[GitHub] [apisix] XFarooqi opened a new pull request, #8900: docs: fix typo and added useful information

2023-02-20 Thread via GitHub
XFarooqi opened a new pull request, #8900: URL: https://github.com/apache/apisix/pull/8900 ### Description Talking about changes, I have removed typos, grammatical mistakes and added relevant details to make this documentation more informative and professional. The motiv

[GitHub] [apisix-helm-chart] marcuskrantz commented on issue #476: feat: Support configuring APISIX admin_key via secret

2023-02-20 Thread via GitHub
marcuskrantz commented on issue #476: URL: https://github.com/apache/apisix-helm-chart/issues/476#issuecomment-1437951510 This is exactly the use case that I have. It would be ideal to: 1) First create the secret. This can either be done manually or through some third-party product l

[GitHub] [apisix-helm-chart] tao12345666333 opened a new issue, #476: feat: Support configuring APISIX admin_key via secret

2023-02-20 Thread via GitHub
tao12345666333 opened a new issue, #476: URL: https://github.com/apache/apisix-helm-chart/issues/476 APISIX has supported the ability to configure via environment variables. https://github.com/apache/apisix/blob/master/conf/config.yaml#L28 For more security and convenience, user

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437923324 So it's a bug, would you like to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [apisix] Inasayang commented on issue #6836: error:failed to find SNI: please check if the clienrequests via IP or uses an outdated protocol.

2023-02-20 Thread via GitHub
Inasayang commented on issue #6836: URL: https://github.com/apache/apisix/issues/6836#issuecomment-1437908676 After setting `fallback_sni`(https://github.com/apache/apisix/blob/master/conf/config-default.yaml#L120), and adding `ssl` through SSL API(https://apisix.apache.org/docs/apisix/adm

[GitHub] [apisix] githubxubin opened a new issue, #8899: How to implement periodic data backup?

2023-02-20 Thread via GitHub
githubxubin opened a new issue, #8899: URL: https://github.com/apache/apisix/issues/8899 ### Description I want to implement ETCD data backup regularly, how should I do? Whether there is documentation or solution!!! ### Environment - APISIX version (run `apisix version`)

[GitHub] [apisix] liufeiguo commented on issue #8868: help request: APISIX Dashboard Configure Active Health Check

2023-02-20 Thread via GitHub
liufeiguo commented on issue #8868: URL: https://github.com/apache/apisix/issues/8868#issuecomment-1437887799 > Try to use the `curl` command first, there are successful use cases in the doc. I have tested that curl and page operation are the same. Now I want to know whether the pass

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1666: ci: add yamllint rules

2023-02-20 Thread via GitHub
tao12345666333 commented on code in PR #1666: URL: https://github.com/apache/apisix-ingress-controller/pull/1666#discussion_r1112562109 ## .yamllint.yml: ## @@ -0,0 +1,49 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreemen

[GitHub] [apisix] Inasayang commented on issue #6836: error:failed to find SNI: please check if the clienrequests via IP or uses an outdated protocol.

2023-02-20 Thread via GitHub
Inasayang commented on issue #6836: URL: https://github.com/apache/apisix/issues/6836#issuecomment-1437882903 If ServerName is an IP address, ClientHello will not contain server_name. https://github.com/golang/go/blob/master/src/crypto/tls/common.go#L635 ![image](https://user-images.git

[GitHub] [apisix-java-plugin-runner] 15003476628 commented on issue #228: request help: request.getUpstreamHeaders java.lang.IndexOutOfBoundsException: null?

2023-02-20 Thread via GitHub
15003476628 commented on issue #228: URL: https://github.com/apache/apisix-java-plugin-runner/issues/228#issuecomment-1437878512 使用 request.getUpstreamHeaders() 时候报的错误 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-java-plugin-runner] 15003476628 commented on issue #228: request help: request.getUpstreamHeaders java.lang.IndexOutOfBoundsException: null?

2023-02-20 Thread via GitHub
15003476628 commented on issue #228: URL: https://github.com/apache/apisix-java-plugin-runner/issues/228#issuecomment-1437877460 ![image](https://user-images.githubusercontent.com/29769061/220254705-a9d92f80-a257-42fa-aa46-a952850a6e97.png) -- This is an automated message from the Ap

[GitHub] [apisix-java-plugin-runner] 15003476628 commented on issue #229: request help: PostResponse.setHead("Content-Type:",application/json;charset=UTF-8) 不生效?

2023-02-20 Thread via GitHub
15003476628 commented on issue #229: URL: https://github.com/apache/apisix-java-plugin-runner/issues/229#issuecomment-1437876425 ![image](https://user-images.githubusercontent.com/29769061/220254462-cf3dbb1b-274e-4007-bb5a-686e9d855069.png) -- This is an automated message from the Ap

[GitHub] [apisix] 0prodigy commented on issue #8880: bug: traffic-split plugin doesn't work with key-auth

2023-02-20 Thread via GitHub
0prodigy commented on issue #8880: URL: https://github.com/apache/apisix/issues/8880#issuecomment-1437871742 But in my case when i use `key-auth` plugin route always respond with upstream set in route not in `traffic-split` when i remove the `key-auth` plugin route return as expected. What

[GitHub] [apisix] Inasayang closed issue #8891: help request: Can apisix register itself to consul?

2023-02-20 Thread via GitHub
Inasayang closed issue #8891: help request: Can apisix register itself to consul? URL: https://github.com/apache/apisix/issues/8891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [apisix] NokoAnubis commented on issue #8800: help request: etcd->http://etcd:2379: failed to parse domain

2023-02-20 Thread via GitHub
NokoAnubis commented on issue #8800: URL: https://github.com/apache/apisix/issues/8800#issuecomment-1437846293 I have this error as well, I am using docker compose I have tried changing the advertised url and I've tried installing from source, I've tried using a newer etcd version but I cou

[GitHub] [apisix] An-DJ opened a new pull request, #8898: feat(cli): support reserved environment variable "APISIX_DEPLOYMENT_E…

2023-02-20 Thread via GitHub
An-DJ opened a new pull request, #8898: URL: https://github.com/apache/apisix/pull/8898 …TCD_HOST" ### Description The user can use env variable "APISIX_DEPLOYMENT_ETCD_HOST" to config the etcd.host. Priority: env var > config.yaml ### Checklist

[GitHub] [apisix] zuiyangqingzhou opened a new pull request, #8897: optimized gzip code logic

2023-02-20 Thread via GitHub
zuiyangqingzhou opened a new pull request, #8897: URL: https://github.com/apache/apisix/pull/8897 ### Description In the gzip plugin, content_type needs to be determined only when types is table, so it would be more appropriate to put it in the table logic,which can improve code perf

[GitHub] [apisix] kellyseeme commented on issue #8892: what is client-control unit

2023-02-20 Thread via GitHub
kellyseeme commented on issue #8892: URL: https://github.com/apache/apisix/issues/8892#issuecomment-1437824390 > @kellyseeme Would you like to update the doc? maybe i can try ,but i dont have experience for this. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] kellyseeme commented on issue #8862: open etcd auth have some problem

2023-02-20 Thread via GitHub
kellyseeme commented on issue #8862: URL: https://github.com/apache/apisix/issues/8862#issuecomment-1437823785 use the admin api of get is no problem,post have ten percent happen of {"error_msg":"etcdserver: invalid auth token"} and there is no requests for the apisix pod. -- This

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8880: bug: traffic-split plugin doesn't work with key-auth

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8880: URL: https://github.com/apache/apisix/issues/8880#issuecomment-1437819727 I test `key-auth` and `traffic-split`, the two plugins could work together, are there any other prlblems? ``` === TEST 1: add consumer with username and plugins ---

[GitHub] [apisix-ingress-controller] mscb402 opened a new pull request, #1680: docs: fix jwtAuth configuration error in documents

2023-02-20 Thread via GitHub
mscb402 opened a new pull request, #1680: URL: https://github.com/apache/apisix-ingress-controller/pull/1680 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [x] Documentation - [ ] Ref

[GitHub] [apisix-java-plugin-runner] nic-chen commented on issue #228: request help: request.getUpstreamHeaders java.lang.IndexOutOfBoundsException: null?

2023-02-20 Thread via GitHub
nic-chen commented on issue #228: URL: https://github.com/apache/apisix-java-plugin-runner/issues/228#issuecomment-1437812648 please provide `Minimal test code / Steps to reproduce the issue` -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [apisix] mscb402 opened a new pull request, #8896: fix: limit count plugin conf parameter undefined error

2023-02-20 Thread via GitHub
mscb402 opened a new pull request, #8896: URL: https://github.com/apache/apisix/pull/8896 ### Description At the `limit-count-local.lua` code, there accept a parameter `conf`, but there doesn't pass it from `init.lua`. And this code doesn't need this conf parameter. I forget to remov

[GitHub] [apisix-website] juzhiyuan commented on issue #740: How about creating a Brand page for Apache APISIX?

2023-02-20 Thread via GitHub
juzhiyuan commented on issue #740: URL: https://github.com/apache/apisix-website/issues/740#issuecomment-1437807782 https://user-images.githubusercontent.com/2106987/220239310-74eef455-4705-43d6-a25d-f03d7ad5d818.png";> It's good for branding and marketing, but I don't have any opinion

[GitHub] [apisix-java-plugin-runner] nic-chen commented on issue #229: request help: PostResponse.setHead("Content-Type:",application/json;charset=UTF-8) 不生效?

2023-02-20 Thread via GitHub
nic-chen commented on issue #229: URL: https://github.com/apache/apisix-java-plugin-runner/issues/229#issuecomment-1437806645 hi @15003476628 could you please provide minimal reproducible steps and code example? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] githubxubin opened a new issue, #8895: system backup and data recovery?

2023-02-20 Thread via GitHub
githubxubin opened a new issue, #8895: URL: https://github.com/apache/apisix/issues/8895 ### Description How does apisix do system backup and data recovery? ### Environment - APISIX version (run `apisix version`): - Operating system (run `uname -a`): - OpenResty / N

[GitHub] [apisix] mscb402 commented on issue #8893: bug: Is there an extra undefined conf parameter here?

2023-02-20 Thread via GitHub
mscb402 commented on issue #8893: URL: https://github.com/apache/apisix/issues/8893#issuecomment-1437781197 Yes you are right, conf parameter is no need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] mscb402 commented on issue #8893: bug: Is there an extra undefined conf parameter here?

2023-02-20 Thread via GitHub
mscb402 commented on issue #8893: URL: https://github.com/apache/apisix/issues/8893#issuecomment-1437781290 I will fix that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] flylan closed issue #8890: bug: Response-rewrite plug-in BUG

2023-02-20 Thread via GitHub
flylan closed issue #8890: bug: Response-rewrite plug-in BUG URL: https://github.com/apache/apisix/issues/8890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [apisix] flylan commented on issue #8890: bug: Response-rewrite plug-in BUG

2023-02-20 Thread via GitHub
flylan commented on issue #8890: URL: https://github.com/apache/apisix/issues/8890#issuecomment-1437779888 > According to your description, the response received by APISIX from the upstream is compressed by gzip, which makes the response-rewrite plugin unable to perform text recognition and

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8885: 502 Bad Gateway bug issue

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8885: URL: https://github.com/apache/apisix/issues/8885#issuecomment-1437779282 The port is not right, use `9180` instead of `9080` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8892: what is client-control unit

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8892: URL: https://github.com/apache/apisix/issues/8892#issuecomment-1437773632 @kellyseeme Would you like to update the doc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander commented on a diff in pull request #8866: feat: use env var instead of plain text for vault token

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8866: URL: https://github.com/apache/apisix/pull/8866#discussion_r1112469413 ## apisix/secret/vault.lua: ## @@ -26,6 +26,7 @@ local norm_path = require("pl.path").normpath local sub= core.string.sub local rfind_char = core.string.rf

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437772210 At this stage,apisix V3.1 (docker.io/apache/apisix:3.1.0-debian) release has another issues , and master have fix 8827. So I use de

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8893: bug: Is there an extra undefined conf parameter here?

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8893: URL: https://github.com/apache/apisix/issues/8893#issuecomment-1437771725 @mscb402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437764236 @dyrnq What you tested is just to prove that the consul works as expect, but If the APISIX will return an unhealthy node? -- This is an automated message from the Apache Gi

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112434518 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name,

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112457447 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name, head

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112451480 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name, head

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437747330 I have some test here I prepare 4 instance nginx here: | ip | port | check

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8891: help request: Can apisix register itself to consul?

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8891: URL: https://github.com/apache/apisix/issues/8891#issuecomment-1437747069 Why do you do this? APISIX is the gateway for all traffic -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] soulbird commented on issue #8890: bug: Response-rewrite plug-in BUG

2023-02-20 Thread via GitHub
soulbird commented on issue #8890: URL: https://github.com/apache/apisix/issues/8890#issuecomment-1437746892 According to your description, the response received by APISIX from the upstream is compressed by gzip, which makes the response-rewrite plugin unable to perform text recognition and

[GitHub] [apisix] beginnerWJC commented on issue #8768: bug: failed to reply RPC_EXTRA_INFO:the max length of data is 16777215 but got 127305012

2023-02-20 Thread via GitHub
beginnerWJC commented on issue #8768: URL: https://github.com/apache/apisix/issues/8768#issuecomment-1437745452 @spacewander If it is a file upload interface,when the request body needs to be overwritten,It is easy to exceed 16M. So i hope expose an environment variable to set it. -- Thi

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112451480 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name, head

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8868: help request: APISIX Dashboard Configure Active Health Check

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8868: URL: https://github.com/apache/apisix/issues/8868#issuecomment-1437743997 Try to use the `curl` command first, there are successful use cases in the doc. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix] spacewander commented on a diff in pull request #8884: feat: handle_extra_info add set req body

2023-02-20 Thread via GitHub
spacewander commented on code in PR #8884: URL: https://github.com/apache/apisix/pull/8884#discussion_r1112449418 ## apisix/plugins/ext-plugin/init.lua: ## @@ -288,7 +288,14 @@ local function handle_extra_info(ctx, input) local res local info_type = req:InfoType() -

[GitHub] [apisix] kellyseeme closed issue #8892: what is client-control unit

2023-02-20 Thread via GitHub
kellyseeme closed issue #8892: what is client-control unit URL: https://github.com/apache/apisix/issues/8892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [apisix] kellyseeme commented on issue #8892: what is client-control unit

2023-02-20 Thread via GitHub
kellyseeme commented on issue #8892: URL: https://github.com/apache/apisix/issues/8892#issuecomment-1437740213 > The unit is bytes, and you can get the answer simply by trying tks,yes,i have try,ask this is to confirm the result,emmm,may be in the docs we can add it , reduce the user

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8889: The health check is not working properly!!!

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on issue #8889: URL: https://github.com/apache/apisix/issues/8889#issuecomment-1437739816 Did you try to send a request, we only start the health check when the upstream is hit by a request. There won't be any health check if an upstream is configured but isn't in

[GitHub] [apisix] spacewander commented on issue #8768: bug: failed to reply RPC_EXTRA_INFO:the max length of data is 16777215 but got 127305012

2023-02-20 Thread via GitHub
spacewander commented on issue #8768: URL: https://github.com/apache/apisix/issues/8768#issuecomment-1437738811 This behavior is intended. The size of length field is 3 bytes: https://github.com/apache/apisix/blob/0ebc9cb85114ed5a389b335e9b8ead7d3fdc17a0/apisix/plugins/ext-plugin/init.lua

[GitHub] [apisix] leslie-tsang commented on a diff in pull request #8849: docs: update doc for guide user to config auth etcd

2023-02-20 Thread via GitHub
leslie-tsang commented on code in PR #8849: URL: https://github.com/apache/apisix/pull/8849#discussion_r1112438377 ## docs/zh/latest/FAQ.md: ## @@ -707,6 +707,21 @@ make GOOS=linux GOARCH=amd64 prefix: "/apisix" ``` +## APISIX 如何配置带认证的 ETCD + +假设您有一个启用身份验证的 ETCD 集群。要访问该集

[GitHub] [apisix] soulbird commented on issue #8892: what is client-control unit

2023-02-20 Thread via GitHub
soulbird commented on issue #8892: URL: https://github.com/apache/apisix/issues/8892#issuecomment-1437728052 The unit is bytes, and you can get the answer simply by trying -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [apisix] Liu-Junlin commented on issue #8648: bug: attempt to index local 'item' (a boolean value)

2023-02-20 Thread via GitHub
Liu-Junlin commented on issue #8648: URL: https://github.com/apache/apisix/issues/8648#issuecomment-1437725235 I often encounter this problem and need to restart apisix server to recover -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-20 Thread via GitHub
monkeyDluffy6017 commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1112434518 ## apisix/core/request.lua: ## @@ -143,14 +143,35 @@ function _M.set_header(ctx, header_name, header_value) end end -function _M.add_header(header_name,

[GitHub] [apisix] spacewander commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
spacewander commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437722320 So the current consul discovery will return an unhealthy node? We assumed that the nodes from the discovery should be healthy if the service discovery has health check support.

[GitHub] [apisix] ecoupal-believe commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)

2023-02-20 Thread via GitHub
ecoupal-believe commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1437354671 Samething on EKS 1.23, not sure how to recover from this, any idea ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-java-plugin-runner] christagger commented on issue #228: request help: request.getUpstreamHeaders java.lang.IndexOutOfBoundsException: null?

2023-02-20 Thread via GitHub
christagger commented on issue #228: URL: https://github.com/apache/apisix-java-plugin-runner/issues/228#issuecomment-1437316294 你好,这个问题解决了吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] shreemaan-abhishek commented on issue #8768: bug: failed to reply RPC_EXTRA_INFO:the max length of data is 16777215 but got 127305012

2023-02-20 Thread via GitHub
shreemaan-abhishek commented on issue #8768: URL: https://github.com/apache/apisix/issues/8768#issuecomment-1437312663 @spacewander I was able to reproduce this issue, I think this is a valid bug and this should be fixed. Waiting for your confirmation. -- This is an automated message from

[GitHub] [apisix-ingress-controller] sakulali commented on a diff in pull request #1666: ci: add yamllint rules

2023-02-20 Thread via GitHub
sakulali commented on code in PR #1666: URL: https://github.com/apache/apisix-ingress-controller/pull/1666#discussion_r1112132242 ## .github/workflows/yamllint-checker.yml: ## @@ -0,0 +1,68 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [apisix-ingress-controller] sakulali commented on a diff in pull request #1666: ci: add yamllint rules

2023-02-20 Thread via GitHub
sakulali commented on code in PR #1666: URL: https://github.com/apache/apisix-ingress-controller/pull/1666#discussion_r1112131086 ## .yamllint.yml: ## @@ -0,0 +1,49 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

[GitHub] [apisix] forestthebug commented on issue #7051: feat: As a user, I want to add support for Knative

2023-02-20 Thread via GitHub
forestthebug commented on issue #7051: URL: https://github.com/apache/apisix/issues/7051#issuecomment-1437237786 Hi, I think till now, there are enough interest in this project. It's great to go on from here @bzp2010 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] ganarajtejasvi commented on issue #8883: help request: upstream rejected request with error 8 while reading response header from upstream

2023-02-20 Thread via GitHub
ganarajtejasvi commented on issue #8883: URL: https://github.com/apache/apisix/issues/8883#issuecomment-1437216681 We managed to fix this by adding the following parameters to our apisix nginx.conf ` http_configuration_snippet: | client_body_buffer_size 2048k; client_h

[GitHub] [apisix] ganarajtejasvi closed issue #8883: help request: upstream rejected request with error 8 while reading response header from upstream

2023-02-20 Thread via GitHub
ganarajtejasvi closed issue #8883: help request: upstream rejected request with error 8 while reading response header from upstream URL: https://github.com/apache/apisix/issues/8883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] shreemaan-abhishek commented on issue #8768: bug: failed to reply RPC_EXTRA_INFO:the max length of data is 16777215 but got 127305012

2023-02-20 Thread via GitHub
shreemaan-abhishek commented on issue #8768: URL: https://github.com/apache/apisix/issues/8768#issuecomment-1437046369 @WVenus @beginnerWJC we were unable to reproduce this bug. I used the information provided by @beginnerWJC The route: ```bash curl "http://127.0.0.1:9180/

[GitHub] [apisix] soulbird commented on pull request #8866: feat: use env var instead of plain text for vault token

2023-02-20 Thread via GitHub
soulbird commented on PR #8866: URL: https://github.com/apache/apisix/pull/8866#issuecomment-1437035212 > > The test cases under t/plugin seem redundant, don't you think? > > I thought the same. But then I thought they would provide better safety from potential nasty bugs in the futur

[GitHub] [apisix-dashboard] creaplus commented on issue #2744: The apisix-dashboard function is unavailable after independent deployment

2023-02-20 Thread via GitHub
creaplus commented on issue #2744: URL: https://github.com/apache/apisix-dashboard/issues/2744#issuecomment-1436994743 > 1. Is there no information in the `error.log` of the dashboard? > 2. Once the dashboard indicates that the resource was created successfully, you can check if the reso

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-02-20 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1436988327 @bzp2010 Cloud you have a look ath this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] shima-park commented on issue #8893: bug: Is there an extra undefined conf parameter here?

2023-02-20 Thread via GitHub
shima-park commented on issue #8893: URL: https://github.com/apache/apisix/issues/8893#issuecomment-1436959090 https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count/limit-count-local.lua#L58 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix] shima-park opened a new issue, #8893: bug: Is there an extra undefined conf parameter here?

2023-02-20 Thread via GitHub
shima-park opened a new issue, #8893: URL: https://github.com/apache/apisix/issues/8893 ### Current Behavior nothing. ### Expected Behavior _No response_ ### Error Logs _No response_ ### Steps to Reproduce 1 ### Environment - APIS

[GitHub] [apisix] kellyseeme opened a new issue, #8892: what is client-control unit

2023-02-20 Thread via GitHub
kellyseeme opened a new issue, #8892: URL: https://github.com/apache/apisix/issues/8892 ### Description https://user-images.githubusercontent.com/535200/220100721-15d53feb-f951-4e8c-b5e5-4b3fe866dad3.png";> in client-control,what unit of max_body_size. ### Environment

[GitHub] [apisix] Inasayang opened a new issue, #8891: help request: Can apisix register itself to consul?

2023-02-20 Thread via GitHub
Inasayang opened a new issue, #8891: URL: https://github.com/apache/apisix/issues/8891 ### Description Can apisix register itself to consul? I don't see any relevant configuration in the docs. ### Environment - APISIX version (run `apisix version`): - Operating

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1436769240 I have noticed that nacos discovery use the query parameter `healthyOnly=true` to filter unhealthy endpoints. But I haven't verified this, just from the perspective of code analys

[GitHub] [apisix] tzssangglass commented on issue #7051: feat: As a user, I want to add support for Knative

2023-02-20 Thread via GitHub
tzssangglass commented on issue #7051: URL: https://github.com/apache/apisix/issues/7051#issuecomment-1436766584 > I want this feature! have fun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[apisix-ingress-controller] branch dependabot/go_modules/golang.org/x/net-0.7.0 updated (c0057c90 -> 3015df0d)

2023-02-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/golang.org/x/net-0.7.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git discard c0057c90 bump golang.org/x/net from 0.5.0 to 0.7.0

[apisix-ingress-controller] branch master updated: chore(deps): bump golang.org/x/net from 0.5.0 to 0.7.0 in /test/e2e (#1677)

2023-02-20 Thread zhangjintao
This is an automated email from the ASF dual-hosted git repository. zhangjintao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 0ff7aca5 chore(deps): bu

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1677: chore(deps): bump golang.org/x/net from 0.5.0 to 0.7.0 in /test/e2e

2023-02-20 Thread via GitHub
tao12345666333 merged PR #1677: URL: https://github.com/apache/apisix-ingress-controller/pull/1677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [apisix] liufeiguo commented on issue #8868: help request: APISIX Dashboard Configure Active Health Check

2023-02-20 Thread via GitHub
liufeiguo commented on issue #8868: URL: https://github.com/apache/apisix/issues/8868#issuecomment-1436706023 > Could you try to use the `curl` command to reproduce the problem? Today, I tested again that the active health check configuration of upstream.checks.active.host host IP mus

[GitHub] [apisix] flylan commented on issue #8890: bug: Response-rewrite plug-in BUG

2023-02-20 Thread via GitHub
flylan commented on issue #8890: URL: https://github.com/apache/apisix/issues/8890#issuecomment-1436704586 I tried to set the upstream as the local nginx-php service, but the problem remained. This plug-in can rewrite the response header normally without garbled code, but it cannot rewrite

[GitHub] [apisix] flylan commented on issue #8890: bug: Response-rewrite plug-in BUG

2023-02-20 Thread via GitHub
flylan commented on issue #8890: URL: https://github.com/apache/apisix/issues/8890#issuecomment-1436700205 I debugged the Response-rewrite plug-in and found the problem in the core. response. hold_ body_ For the chunk method, when I configure the upstream as httpbin, the body data obtained

[GitHub] [apisix] flylan opened a new issue, #8890: bug: Response-rewrite plug-in BUG

2023-02-20 Thread via GitHub
flylan opened a new issue, #8890: URL: https://github.com/apache/apisix/issues/8890 ### Current Behavior When the upstream service is nginx+php, the plug-in body filters will return garbled code ### Expected Behavior The body can display normally without garbled code

[GitHub] [apisix-docker] github-actions[bot] commented on issue #373: restart docker error:[emerg] 1#1: bind() to unix:/usr/local/apisix/conf/config_listen.sock failed (98: Address already in use)

2023-02-20 Thread via GitHub
github-actions[bot] commented on issue #373: URL: https://github.com/apache/apisix-docker/issues/373#issuecomment-1436672253 This issue has been marked as stale due to 30 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please

[apisix-dashboard] branch master updated: fix: plugin config page error (#2739)

2023-02-20 Thread baoyuan
This is an automated email from the ASF dual-hosted git repository. baoyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 9b1f8f019 fix: plugin config page err

[GitHub] [apisix-dashboard] Baoyuantop merged pull request #2739: fix: plugin config page error

2023-02-20 Thread via GitHub
Baoyuantop merged PR #2739: URL: https://github.com/apache/apisix-dashboard/pull/2739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [apisix-dashboard] Baoyuantop closed issue #2732: dashboard return blank pange when edit plugins

2023-02-20 Thread via GitHub
Baoyuantop closed issue #2732: dashboard return blank pange when edit plugins URL: https://github.com/apache/apisix-dashboard/issues/2732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2739: fix: plugin config page error

2023-02-20 Thread via GitHub
Baoyuantop commented on PR #2739: URL: https://github.com/apache/apisix-dashboard/pull/2739#issuecomment-1436619697 > test case needed This error is caused by incompatible resources created in apisix, and there is no DP testing in front-end E2E yet. -- This is an automated message

[GitHub] [apisix] ecoupal-believe commented on issue #6791: bug: openid-connect plugin doesn't redirect after logout

2023-02-20 Thread via GitHub
ecoupal-believe commented on issue #6791: URL: https://github.com/apache/apisix/issues/6791#issuecomment-1436587869 I have the same problem with Cognito: it does not provide end_session_endpoint. Is there news on this ticket ? -- This is an automated message from the Apache Git Service. T

[GitHub] [apisix] githubxubin opened a new issue, #8889: The health check is not working properly!!!

2023-02-20 Thread via GitHub
githubxubin opened a new issue, #8889: URL: https://github.com/apache/apisix/issues/8889 ### Description I configured the active health check and filled in the request path, but the active health check did not send a request to the address, so it could not be used at all. I configure

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2744: The apisix-dashboard function is unavailable after independent deployment

2023-02-20 Thread via GitHub
Baoyuantop commented on issue #2744: URL: https://github.com/apache/apisix-dashboard/issues/2744#issuecomment-1436572961 1. Is there no information in the `error.log` of the dashboard? 2. Once the dashboard indicates that the resource was created successfully, you can check if the resour

[GitHub] [apisix] Qiuqiu0505 commented on a diff in pull request #8869: should be first allow_origins_by_regex

2023-02-20 Thread via GitHub
Qiuqiu0505 commented on code in PR #8869: URL: https://github.com/apache/apisix/pull/8869#discussion_r639646 ## t/plugin/cors.t: ## @@ -927,3 +927,83 @@ Access-Control-Allow-Headers: headr1,headr2 Access-Control-Expose-Headers: ex-headr1,ex-headr2 Access-Control-Max-Age: 5

[GitHub] [apisix] Qiuqiu0505 commented on a diff in pull request #8869: should be first allow_origins_by_regex

2023-02-20 Thread via GitHub
Qiuqiu0505 commented on code in PR #8869: URL: https://github.com/apache/apisix/pull/8869#discussion_r639646 ## t/plugin/cors.t: ## @@ -927,3 +927,83 @@ Access-Control-Allow-Headers: headr1,headr2 Access-Control-Expose-Headers: ex-headr1,ex-headr2 Access-Control-Max-Age: 5

[GitHub] [apisix-helm-chart] sweetpotatoman commented on pull request #469: feat: support multiple ports

2023-02-20 Thread via GitHub
sweetpotatoman commented on PR #469: URL: https://github.com/apache/apisix-helm-chart/pull/469#issuecomment-1436524318 @tao tao brother, need u approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] spacewander opened a new pull request, #8888: fix(proxy-rewrite): escape args part if it's not from user conf

2023-02-20 Thread via GitHub
spacewander opened a new pull request, #: URL: https://github.com/apache/apisix/pull/ ### Description Fixes #8877 ### Checklist - [x] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new featu