[GitHub] [apisix] KID-G commented on pull request #8763: docs: Update getting-started.md

2023-02-26 Thread via GitHub
KID-G commented on PR #8763: URL: https://github.com/apache/apisix/pull/8763#issuecomment-1445859307 > change nginx var link from http to https, avoid browser unsafe tips > > https://user-images.githubusercontent.com/15957047/215955838-3c95b811-aa68-4514-a31b-93bd6f485d05.png";>

[GitHub] [apisix] 2456868764 opened a new pull request, #8951: fix expose api test url

2023-02-26 Thread via GitHub
2456868764 opened a new pull request, #8951: URL: https://github.com/apache/apisix/pull/8951 ### Description fix route testing url in expore-api.md document Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ]

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2661: The node field is lost after the apisix-dashboard submission

2023-02-26 Thread via GitHub
Baoyuantop commented on issue #2661: URL: https://github.com/apache/apisix-dashboard/issues/2661#issuecomment-1445829237 The dashboard does not recognize the metadata field in nodes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [apisix] githubxubin opened a new issue, #8950: docker error.log Permission denied

2023-02-26 Thread via GitHub
githubxubin opened a new issue, #8950: URL: https://github.com/apache/apisix/issues/8950 ### Description when i use docker-compose to build apisix,the apisix:2.15-alpine can not start ,because the error.log no have permission in docker, How do I configure it.(the container can no

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445825627 > > @Fabriceli > > I encountered difficulties. > > I notice the test ci use docker-compose start consul_1 8500 and consul_2 8600 and then they can not access `http://127.0.0.1:30511` wh

[GitHub] [apisix] Fabriceli commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
Fabriceli commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445819466 > @Fabriceli > > I encountered difficulties. > > I notice the test ci use docker-compose start consul_1 8500 and consul_2 8600 and then they can not access `http://127.0.0.1

[GitHub] [apisix] YangChaorix commented on issue #8864: help request: plugins.proxy-rewrite does not work

2023-02-26 Thread via GitHub
YangChaorix commented on issue #8864: URL: https://github.com/apache/apisix/issues/8864#issuecomment-1445803765 https://user-images.githubusercontent.com/24434787/221494886-bf607c60-a7a7-4b5e-a9b5-be732f07ffab.png";> https://user-images.githubusercontent.com/24434787/221495484-4e49

[GitHub] [apisix] kellyseeme commented on issue #8948: IP SSL

2023-02-26 Thread via GitHub
kellyseeme commented on issue #8948: URL: https://github.com/apache/apisix/issues/8948#issuecomment-1445802160 no,must use sni if you use the ssl connections.if you use curl ,you can use curl --resolve 'the dns domain:443:yourapisixip' https://the dns domain:443/ -vvv -- This is an

[GitHub] [apisix] kellyseeme closed issue #8938: how to use vars to match rule

2023-02-26 Thread via GitHub
kellyseeme closed issue #8938: how to use vars to match rule URL: https://github.com/apache/apisix/issues/8938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [apisix] kellyseeme commented on issue #8938: how to use vars to match rule

2023-02-26 Thread via GitHub
kellyseeme commented on issue #8938: URL: https://github.com/apache/apisix/issues/8938#issuecomment-1445800187 yes ,this is dangerous,we want to set some rules to reject the request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2687: bug: dashboard should not support '!' in vars.

2023-02-26 Thread via GitHub
Baoyuantop commented on issue #2687: URL: https://github.com/apache/apisix-dashboard/issues/2687#issuecomment-1445795900 > 1、create route, add vars in route,operator use '!',like this: { "uri": "/*", "name": "test", "methods": [ "GET" ], "vars": [ [ "http_test1", "!", "123" ] ], ... 2、

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445795598 @Fabriceli I encountered difficulties. I notice the test ci use docker-compose start consul_1 8500 and consul_2 8600 and then they cant access `http://127.0.0.1:30511` which re

[GitHub] [apisix] mscb402 commented on pull request #8915: docs: update faq about ssls and client tls andssl_trusted_certificate

2023-02-26 Thread via GitHub
mscb402 commented on PR #8915: URL: https://github.com/apache/apisix/pull/8915#issuecomment-1445793939 @leslie-tsang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2740: 禁用全局插件未使用_meta字段

2023-02-26 Thread via GitHub
Baoyuantop commented on issue #2740: URL: https://github.com/apache/apisix-dashboard/issues/2740#issuecomment-1445787569 This issue may cause the global plugin disabling to fail and needs to be fixed. You can temporarily use the `Delete` Global Plugin. -- This is an automated message fro

[apisix-website] branch master updated: feat: update Slack invitation link (#1513)

2023-02-26 Thread young
This is an automated email from the ASF dual-hosted git repository. young pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 58cfd99940d feat: update Slack invitation

[GitHub] [apisix-website] SkyeYoung merged pull request #1513: feat: update Slack invitation link

2023-02-26 Thread via GitHub
SkyeYoung merged PR #1513: URL: https://github.com/apache/apisix-website/pull/1513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [apisix-website] netlify[bot] commented on pull request #1513: feat: update Slack invitation link

2023-02-26 Thread via GitHub
netlify[bot] commented on PR #1513: URL: https://github.com/apache/apisix-website/pull/1513#issuecomment-1445777401 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |:-:|| |🔨 Latest commit | f2d4327d019a84779f103011635a7f80c1583b

[GitHub] [apisix-website] juzhiyuan opened a new pull request, #1513: feat: update Slack invitation link

2023-02-26 Thread via GitHub
juzhiyuan opened a new pull request, #1513: URL: https://github.com/apache/apisix-website/pull/1513 Update Slack invitation link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[apisix-website] 01/01: feat: update Slack invitation link

2023-02-26 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit f2d4327d019a84779f103011635a7f80c1583b27 Author: 琚致远 / Zhiyuan Ju AuthorDate: Mon Feb 27 14:22:31

[apisix-website] branch juzhiyuan-patch-1 created (now f2d4327d019)

2023-02-26 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git at f2d4327d019 feat: update Slack invitation link This branch includes the following new commits:

[GitHub] [apisix-ingress-controller] dependabot[bot] opened a new pull request, #1691: chore(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2 in /test/e2e

2023-02-26 Thread via GitHub
dependabot[bot] opened a new pull request, #1691: URL: https://github.com/apache/apisix-ingress-controller/pull/1691 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.1 to 1.8.2. Commits https://github.com/stretchr/testify/commit/f36bfe3c337aa95c

[apisix-ingress-controller] branch dependabot/go_modules/test/e2e/github.com/gavv/httpexpect/v2-2.13.0 created (now d7d362e5)

2023-02-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/test/e2e/github.com/gavv/httpexpect/v2-2.13.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git at d7d362e5 chore(deps): bump github

[apisix-ingress-controller] branch dependabot/go_modules/test/e2e/github.com/stretchr/testify-1.8.2 created (now b1a3ed0b)

2023-02-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/test/e2e/github.com/stretchr/testify-1.8.2 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git at b1a3ed0b chore(deps): bump github.co

[GitHub] [apisix-ingress-controller] dependabot[bot] opened a new pull request, #1690: chore(deps): bump github.com/gavv/httpexpect/v2 from 2.12.0 to 2.13.0 in /test/e2e

2023-02-26 Thread via GitHub
dependabot[bot] opened a new pull request, #1690: URL: https://github.com/apache/apisix-ingress-controller/pull/1690 Bumps [github.com/gavv/httpexpect/v2](https://github.com/gavv/httpexpect) from 2.12.0 to 2.13.0. Release notes Sourced from https://github.com/gavv/httpexpect/releas

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1688: chore(deps): bump github.com/gin-gonic/gin from 1.8.2 to 1.9.0

2023-02-26 Thread via GitHub
codecov-commenter commented on PR #1688: URL: https://github.com/apache/apisix-ingress-controller/pull/1688#issuecomment-1445758790 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1688?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1689: chore(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2

2023-02-26 Thread via GitHub
codecov-commenter commented on PR #1689: URL: https://github.com/apache/apisix-ingress-controller/pull/1689#issuecomment-1445758496 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1689?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[apisix-ingress-controller] branch dependabot/go_modules/github.com/stretchr/testify-1.8.2 created (now 1df89bdb)

2023-02-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/github.com/stretchr/testify-1.8.2 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git at 1df89bdb chore(deps): bump github.com/stretch

[GitHub] [apisix-ingress-controller] dependabot[bot] opened a new pull request, #1689: chore(deps): bump github.com/stretchr/testify from 1.8.1 to 1.8.2

2023-02-26 Thread via GitHub
dependabot[bot] opened a new pull request, #1689: URL: https://github.com/apache/apisix-ingress-controller/pull/1689 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.1 to 1.8.2. Commits https://github.com/stretchr/testify/commit/f36bfe3c337aa95c

[apisix-ingress-controller] branch dependabot/go_modules/github.com/gin-gonic/gin-1.9.0 created (now 66e2e431)

2023-02-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/github.com/gin-gonic/gin-1.9.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git at 66e2e431 chore(deps): bump github.com/gin-gonic/

[GitHub] [apisix-ingress-controller] dependabot[bot] opened a new pull request, #1688: chore(deps): bump github.com/gin-gonic/gin from 1.8.2 to 1.9.0

2023-02-26 Thread via GitHub
dependabot[bot] opened a new pull request, #1688: URL: https://github.com/apache/apisix-ingress-controller/pull/1688 Bumps [github.com/gin-gonic/gin](https://github.com/gin-gonic/gin) from 1.8.2 to 1.9.0. Release notes Sourced from https://github.com/gin-gonic/gin/releases";>github

[GitHub] [apisix] mscb402 commented on pull request #8915: docs: update faq about ssls and client tls andssl_trusted_certificate

2023-02-26 Thread via GitHub
mscb402 commented on PR #8915: URL: https://github.com/apache/apisix/pull/8915#issuecomment-1445741022 @tokers @spacewander Could you help me to review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [apisix] Neilblaze commented on pull request #8949: fix: corrected minimum in healthcheck schema

2023-02-26 Thread via GitHub
Neilblaze commented on PR #8949: URL: https://github.com/apache/apisix/pull/8949#issuecomment-1445736895 @spacewander would you mind having a look at the (nginx) err that I'm facing from the CI test? I noticed that it's specifically because of these two : https://github.com/apache/a

[GitHub] [apisix-docker] Neilblaze commented on issue #417: Example containers using old images

2023-02-26 Thread via GitHub
Neilblaze commented on issue #417: URL: https://github.com/apache/apisix-docker/issues/417#issuecomment-1445724196 I'm a bit confused about whether to remove *Prometheus* and other images entirely from the compose file. Would you mind sharing some light on this? cc: @juzhiyuan , @soul

[GitHub] [apisix] Neilblaze opened a new pull request, #8949: fix: corrected minimum in healthcheck schema

2023-02-26 Thread via GitHub
Neilblaze opened a new pull request, #8949: URL: https://github.com/apache/apisix/pull/8949 ### Description It's meaningless to use *zero as the minimum* in [`schema_def.lua`](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf72c7b/apisix/schema_def.lua#L239) w

[GitHub] [apisix] Neilblaze commented on issue #8937: help request: the minimum in healthcheck schema is incorrect

2023-02-26 Thread via GitHub
Neilblaze commented on issue #8937: URL: https://github.com/apache/apisix/issues/8937#issuecomment-1445693452 Gotcha! Thanks for the clarity @spacewander 😄 I'm moving forward with removing `minimum = 0` from [here](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1ef8275932df8bf

[GitHub] [apisix] Neilblaze commented on a diff in pull request #8939: docs: shift workflow plugin to general category

2023-02-26 Thread via GitHub
Neilblaze commented on code in PR #8939: URL: https://github.com/apache/apisix/pull/8939#discussion_r1118275644 ## docs/zh/latest/config.json: ## @@ -56,9 +56,11 @@ "plugins/gzip", "plugins/real-ip", "plugins/server-info", -"plu

[GitHub] [apisix-helm-chart] jinjianming opened a new issue, #485: help request: Data-plane cannot dynamically modify the upstreams address. You need to execute apisix reload to get the latest address

2023-02-26 Thread via GitHub
jinjianming opened a new issue, #485: URL: https://github.com/apache/apisix-helm-chart/issues/485 ### Description 1. At present, I have learned about the coupling architecture through the K8S deployment. When I restart the POD, the data plane service cannot update the latest address,

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445634595 > @Fabriceli there are some test use 8600 which is the first consul DNS port, it can not use to another consul instance(8500), i want to update it to 18500. I see there use docker-com

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445631179 @Fabriceli there are some test use 8600 which is the first consul DNS port, it can not use to another consul instance(8500), i want to update it to 18500. -- This is an automated message

[GitHub] [apisix-helm-chart] jinjianming closed issue #484: help request: data-plane sync control-plane res: null, err: timeout, context: ngx.timer

2023-02-26 Thread via GitHub
jinjianming closed issue #484: help request: data-plane sync control-plane res: null, err: timeout, context: ngx.timer URL: https://github.com/apache/apisix-helm-chart/issues/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-26 Thread via GitHub
monkeyDluffy6017 commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1118240827 ## t/core/request.t: ## @@ -439,3 +439,47 @@ while ($i <= 101) { $s --- response_body 101 + + + +=== TEST 15: add header +--- config +location /t { +

[GitHub] [apisix] GuavaSteven commented on issue #8948: IP SSL

2023-02-26 Thread via GitHub
GuavaSteven commented on issue #8948: URL: https://github.com/apache/apisix/issues/8948#issuecomment-1445604643 custom ssl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] GuavaSteven opened a new issue, #8948: IP SSL

2023-02-26 Thread via GitHub
GuavaSteven opened a new issue, #8948: URL: https://github.com/apache/apisix/issues/8948 ### Description Hello, I have configured my visa. Can I use Ip instead of sni for access? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[apisix] branch dependabot/go_modules/ci/pod/openfunction/function-example/test-uri/golang.org/x/text-0.3.8 updated (a1855f108 -> 4a64ab89f)

2023-02-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/ci/pod/openfunction/function-example/test-uri/golang.org/x/text-0.3.8 in repository https://gitbox.apache.org/repos/asf/apisix.git omit a1855f108 chore(deps): bump

[apisix] branch dependabot/go_modules/ci/pod/openfunction/function-example/test-body/golang.org/x/text-0.3.8 updated (630f6ea46 -> debac884b)

2023-02-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/ci/pod/openfunction/function-example/test-body/golang.org/x/text-0.3.8 in repository https://gitbox.apache.org/repos/asf/apisix.git discard 630f6ea46 chore(deps): bump

[GitHub] [apisix] dependabot[bot] closed pull request #8624: chore(deps): bump actions/checkout from 3.2.0 to 3.3.0

2023-02-26 Thread via GitHub
dependabot[bot] closed pull request #8624: chore(deps): bump actions/checkout from 3.2.0 to 3.3.0 URL: https://github.com/apache/apisix/pull/8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] dependabot[bot] commented on pull request #8624: chore(deps): bump actions/checkout from 3.2.0 to 3.3.0

2023-02-26 Thread via GitHub
dependabot[bot] commented on PR #8624: URL: https://github.com/apache/apisix/pull/8624#issuecomment-1445586657 Looks like actions/checkout is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-helm-chart] jinjianming opened a new issue, #484: help request: data-plane sync control-plane res: null, err: timeout, context: ngx.timer

2023-02-26 Thread via GitHub
jinjianming opened a new issue, #484: URL: https://github.com/apache/apisix-helm-chart/issues/484 Description At present, I have learned about the coupling architecture through the K8S deployment. When I restart the POD, the data plane service cannot update the latest address, resulting

[GitHub] [apisix] jinjianming opened a new issue, #8947: help request: data-plane同步control-plane res: null, err: timeout, context: ngx.timer

2023-02-26 Thread via GitHub
jinjianming opened a new issue, #8947: URL: https://github.com/apache/apisix/issues/8947 ### Description 1. At present, I have learned about the coupling architecture through the K8S deployment. When I restart the POD, the data plane service cannot update the latest address, resultin

[GitHub] [apisix] spacewander commented on issue #8937: help request: the minimum in healthcheck schema is incorrect

2023-02-26 Thread via GitHub
spacewander commented on issue #8937: URL: https://github.com/apache/apisix/issues/8937#issuecomment-1445561147 If you mean the default value in https://github.com/apache/apisix/blob/8d38884a7ac1d08c529e7f8494fa8ea0d01c1872/apisix/schema_def.lua#L263 it is not relative to the topic

[GitHub] [apisix] spacewander commented on issue #6504: feat: As a User, I want to be able to configure the priority of each plugin so I don't need to change the source code

2023-02-26 Thread via GitHub
spacewander commented on issue #6504: URL: https://github.com/apache/apisix/issues/6504#issuecomment-1445558109 Consider solved. Feel free to reopen it if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander closed issue #6504: feat: As a User, I want to be able to configure the priority of each plugin so I don't need to change the source code

2023-02-26 Thread via GitHub
spacewander closed issue #6504: feat: As a User, I want to be able to configure the priority of each plugin so I don't need to change the source code URL: https://github.com/apache/apisix/issues/6504 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] Fabriceli commented on issue #8934: bug: call download file route got error [upstream sent invalid header: "\x20..."]

2023-02-26 Thread via GitHub
Fabriceli commented on issue #8934: URL: https://github.com/apache/apisix/issues/8934#issuecomment-1445557783 > @Fabriceli What did you mean by showing the Nginx changelog? Any control characters or spaces in your response header? Response header can contain space with Nginx version <

[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #468: feat: support v2 version for hpa

2023-02-26 Thread via GitHub
tokers commented on code in PR #468: URL: https://github.com/apache/apisix-helm-chart/pull/468#discussion_r1118204512 ## charts/apisix-ingress-controller/README.md: ## @@ -109,6 +109,7 @@ The same for container level, you need to set: | autoscaling.maxReplicas | int | `100` |

[GitHub] [apisix] spacewander commented on pull request #8942: fix: When allow_origins_by_regex is non-empty, it should be considered first and allow_oriigins don't be considered

2023-02-26 Thread via GitHub
spacewander commented on PR #8942: URL: https://github.com/apache/apisix/pull/8942#issuecomment-1445552703 Please make the CI pass, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #482: feat: Add `gateway.enabled` to adjust in decoupled mode

2023-02-26 Thread via GitHub
tokers commented on code in PR #482: URL: https://github.com/apache/apisix-helm-chart/pull/482#discussion_r1118204113 ## charts/apisix/values.yaml: ## @@ -233,11 +234,13 @@ gateway: enabled: true servicePort: 80 containerPort: 9080 +nodePort: "" Review Commen

[GitHub] [apisix] spacewander commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-26 Thread via GitHub
spacewander commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1118203356 ## apisix/core/request.lua: ## @@ -131,26 +129,41 @@ function _M.set_header(ctx, header_name, header_value) changed = a6_request.is_request_header_set()

[GitHub] [apisix] tokers commented on issue #8934: bug: call download file route got error [upstream sent invalid header: "\x20..."]

2023-02-26 Thread via GitHub
tokers commented on issue #8934: URL: https://github.com/apache/apisix/issues/8934#issuecomment-1445548418 @Fabriceli What did you mean by showing the Nginx changelog? Any control characters or spaces in your response header? -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix-docker] soulbird commented on issue #417: Example containers using old images

2023-02-26 Thread via GitHub
soulbird commented on issue #417: URL: https://github.com/apache/apisix-docker/issues/417#issuecomment-1445547719 I don't think all-in-one has any effect, we can consider deleting it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix] tokers commented on issue #8934: bug: call download file route got error [upstream sent invalid header: "\x20..."]

2023-02-26 Thread via GitHub
tokers commented on issue #8934: URL: https://github.com/apache/apisix/issues/8934#issuecomment-1445546916 > Where did you get this response? It misses the HTTP status code. Ofcourse it cannot be parsed. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix] tokers commented on issue #8938: how to use vars to match rule

2023-02-26 Thread via GitHub
tokers commented on issue #8938: URL: https://github.com/apache/apisix/issues/8938#issuecomment-1445543457 `..` is a dangerous symbol in URI, and APISIX will normalize the URI before the route matching. So actually, the URI used for matching is `/123`, not `/users/../123`. -- This is an

[GitHub] [apisix] spacewander merged pull request #8943: chore(deps): bump golang.org/x/sys from 0.0.0-20211019181941-9d821ace8654 to 0.1.0 in /ci/pod/openfunction/function-example/test-body

2023-02-26 Thread via GitHub
spacewander merged PR #8943: URL: https://github.com/apache/apisix/pull/8943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: chore(deps): bump golang.org/x/sys from 0.0.0-20211019181941-9d821ace8654 to 0.1.0 in /ci/pod/openfunction/function-example/test-body (#8943)

2023-02-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 8d38884a7 chore(deps): bump golang.org/x/sy

[GitHub] [apisix] tokers commented on issue #8931: help request: file descriptor overflow when use request-id plugin nanoid algorithm

2023-02-26 Thread via GitHub
tokers commented on issue #8931: URL: https://github.com/apache/apisix/issues/8931#issuecomment-1445542396 You may try to submit a PR for the lua-resty-nanoid repo, then let's upgrade the dependency in APISIX. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445540720 > > @Fabriceli Help me see what is left unfinished? There are some ci failed. > > Please fix the test cases, there are some test failed. Referenced infos about how to run APISIX test:

[GitHub] [apisix-ingress-controller] github-actions[bot] commented on issue #1252: request help: Configure AWS Certifcate on APISIX Ingress

2023-02-26 Thread via GitHub
github-actions[bot] commented on issue #1252: URL: https://github.com/apache/apisix-ingress-controller/issues/1252#issuecomment-1445540333 This issue has been marked as stale due to 90 days of inactivity. It will be closed in 30 days if no further activity occurs. If this issue is still re

[GitHub] [apisix] spacewander commented on pull request #8941: feat: add redirect_after_logout_uri to the oidc plugin to replace or …

2023-02-26 Thread via GitHub
spacewander commented on PR #8941: URL: https://github.com/apache/apisix/pull/8941#issuecomment-1445539021 @starsz Please take a look when you have free time, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] spacewander commented on a diff in pull request #8939: docs: shift workflow plugin to general category

2023-02-26 Thread via GitHub
spacewander commented on code in PR #8939: URL: https://github.com/apache/apisix/pull/8939#discussion_r1118195145 ## docs/zh/latest/config.json: ## @@ -56,9 +56,11 @@ "plugins/gzip", "plugins/real-ip", "plugins/server-info", -"p

[GitHub] [apisix] spacewander commented on issue #8937: help request: the minimum in healthcheck schema is incorrect

2023-02-26 Thread via GitHub
spacewander commented on issue #8937: URL: https://github.com/apache/apisix/issues/8937#issuecomment-1445536117 > @navendu-pottekkat I'm a bit confused about whether I'm going to break the tests by directly removing [`minimum = 0`](https://github.com/apache/apisix/blob/d3ac217cb26ab731d51f1

[GitHub] [apisix] soulbird commented on issue #7227: help request: is there rpm which can be installed on arm ?

2023-02-26 Thread via GitHub
soulbird commented on issue #7227: URL: https://github.com/apache/apisix/issues/7227#issuecomment-1445535865 see: https://openresty.org/cn/linux-packages.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix] spacewander merged pull request #8930: chore(deps): bump huacnlee/autocorrect-action from 2.6.1 to 2.6.2

2023-02-26 Thread via GitHub
spacewander merged PR #8930: URL: https://github.com/apache/apisix/pull/8930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated (d3ac217cb -> 451bf1caa)

2023-02-26 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from d3ac217cb docs: fix elasticsearch-logger (#8863) add 451bf1caa chore(deps): bump huacnlee/autocorrect-action

[GitHub] [apisix] Fabriceli commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
Fabriceli commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445532142 > @Fabriceli Help me see what is left unfinished? There are some ci failed. Please fix the test cases, there are some test failed. Referenced infos about how to run APISIX test:

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-26 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445496520 @Fabriceli Help me see what is left unfinished? There are some ci failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[apisix-website] branch master updated: chore: add @Gallardot to Team page (#1512)

2023-02-26 Thread yilinzeng
This is an automated email from the ASF dual-hosted git repository. yilinzeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 4e2bb923482 chore: add @Gallardot to

[GitHub] [apisix-website] yzeng25 merged pull request #1512: chore: add @Gallardot to Team page

2023-02-26 Thread via GitHub
yzeng25 merged PR #1512: URL: https://github.com/apache/apisix-website/pull/1512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [apisix] github-actions[bot] closed issue #6309: request help: in apisix, how to use rbac with keycloak?

2023-02-26 Thread via GitHub
github-actions[bot] closed issue #6309: request help: in apisix, how to use rbac with keycloak? URL: https://github.com/apache/apisix/issues/6309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] github-actions[bot] commented on issue #6309: request help: in apisix, how to use rbac with keycloak?

2023-02-26 Thread via GitHub
github-actions[bot] commented on issue #6309: URL: https://github.com/apache/apisix/issues/6309#issuecomment-1445314909 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- Th

[GitHub] [apisix-docker] github-actions[bot] commented on issue #407: Service Temporarily Unavailable

2023-02-26 Thread via GitHub
github-actions[bot] commented on issue #407: URL: https://github.com/apache/apisix-docker/issues/407#issuecomment-1445314720 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -

[GitHub] [apisix-docker] github-actions[bot] closed issue #407: Service Temporarily Unavailable

2023-02-26 Thread via GitHub
github-actions[bot] closed issue #407: Service Temporarily Unavailable URL: https://github.com/apache/apisix-docker/issues/407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [apisix] xinqing123 commented on issue #7227: help request: is there rpm which can be installed on arm ?

2023-02-26 Thread via GitHub
xinqing123 commented on issue #7227: URL: https://github.com/apache/apisix/issues/7227#issuecomment-1445305771 > > > > > 我可以通过构建工具构建,但如果你能在 api7 repo 中提供 centos arm64 rpm 就更好了@spacewander > > > > > > > > > > > > 现在,你可以在centos arm64下安装apisix了: > > > > ```shell > > > > yum inst

[GitHub] [apisix] xinqing123 commented on issue #7227: help request: is there rpm which can be installed on arm ?

2023-02-26 Thread via GitHub
xinqing123 commented on issue #7227: URL: https://github.com/apache/apisix/issues/7227#issuecomment-1445305767 > > > > > 我可以通过构建工具构建,但如果你能在 api7 repo 中提供 centos arm64 rpm 就更好了@spacewander > > > > > > > > > > > > 现在,你可以在centos arm64下安装apisix了: > > > > ```shell > > > > yum inst

[GitHub] [apisix] xinqing123 commented on issue #3360: bug: some cases of http-logger.t failed on arm64 (centos7.6)

2023-02-26 Thread via GitHub
xinqing123 commented on issue #3360: URL: https://github.com/apache/apisix/issues/3360#issuecomment-1445302629 问一下,在aarch怎么安装apisix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [apisix] xinqing123 commented on issue #7227: help request: is there rpm which can be installed on arm ?

2023-02-26 Thread via GitHub
xinqing123 commented on issue #7227: URL: https://github.com/apache/apisix/issues/7227#issuecomment-1445302237 > > > > 我可以通过构建工具构建,但如果你能在 api7 repo 中提供 centos arm64 rpm 就更好了@spacewander > > > > > > > > > 现在,你可以在centos arm64下安装apisix了: > > > ```shell > > > yum install -y http

[GitHub] [apisix] xinqing123 commented on issue #7881: help request: Is apisix worker well on arm64?

2023-02-26 Thread via GitHub
xinqing123 commented on issue #7881: URL: https://github.com/apache/apisix/issues/7881#issuecomment-1445296976 问一下怎么在aarch64上安装 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [apisix] xinqing123 opened a new issue, #8946: help request:

2023-02-26 Thread via GitHub
xinqing123 opened a new issue, #8946: URL: https://github.com/apache/apisix/issues/8946 ### Description apisix如何在aarch64安装,没找到apisix .aarch.rpm文件,现在尝试源码安装,但是源码安装,不知道怎么操作,官网的有点看不懂 ### Environment - APISIX version (run `apisix version`):2.13.1 - Operating system (run `un

[GitHub] [apisix-dashboard] Shivam0500 commented on pull request #2726: chore: update the year in the NOTICE

2023-02-26 Thread via GitHub
Shivam0500 commented on PR #2726: URL: https://github.com/apache/apisix-dashboard/pull/2726#issuecomment-1445295326 hey sorry for late reply my college exams were going on my email is -> shivamaggarwal0...@gmail.com and i am currently learning MERN stack development thank you