[GitHub] [apisix-dashboard] Baoyuantop closed issue #2554: import openapi.yaml 无法识别 x-apisix-service_id

2023-02-27 Thread via GitHub
Baoyuantop closed issue #2554: import openapi.yaml 无法识别 x-apisix-service_id URL: https://github.com/apache/apisix-dashboard/issues/2554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2554: import openapi.yaml 无法识别 x-apisix-service_id

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2554: URL: https://github.com/apache/apisix-dashboard/issues/2554#issuecomment-1447727868 If there is still a problem, please open it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [apisix] artemus717 opened a new issue, #8960: help request: When will next version of apisix will be released ?

2023-02-27 Thread via GitHub
artemus717 opened a new issue, #8960: URL: https://github.com/apache/apisix/issues/8960 ### Description Hi , Team When will next version of apisix will be released ? I want to use body-transformer plugin . ### Environment Hi , Team When will next version of apisix

[GitHub] [apisix-ingress-controller] abhith opened a new pull request, #1695: docs: fix typo in aks deployment guide

2023-02-27 Thread via GitHub
abhith opened a new pull request, #1695: URL: https://github.com/apache/apisix-ingress-controller/pull/1695 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [x] Documentation - [ ] Refa

[GitHub] [apisix-ingress-controller] abhith closed pull request #1694: docs: fix typo in aks(azure) deployment guide

2023-02-27 Thread via GitHub
abhith closed pull request #1694: docs: fix typo in aks(azure) deployment guide URL: https://github.com/apache/apisix-ingress-controller/pull/1694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] abhith opened a new pull request, #1694: docs: fix typo in aks(azure) deployment guide

2023-02-27 Thread via GitHub
abhith opened a new pull request, #1694: URL: https://github.com/apache/apisix-ingress-controller/pull/1694 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [x] Documentation - [ ] Refa

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2606: bug: Stack overflow error when importing an openAPI .yaml file through the APISIX Dashboard

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2606: URL: https://github.com/apache/apisix-dashboard/issues/2606#issuecomment-1447688453 > The 'SystemSchema' contained around 35 parameters, so it was quite large, maybe that was the issue? I also tested with this number of files and found no problems

[GitHub] [apisix] spacewander opened a new pull request, #8959: feat: add degraphql plugin

2023-02-27 Thread via GitHub
spacewander opened a new pull request, #8959: URL: https://github.com/apache/apisix/pull/8959 Thanks for @tzssangglass to provide the inital implementation. Signed-off-by: spacewander ### Description Fixes #8787 ### Checklist - [ ] I have explained

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2355: CRD方式导入的证书无法显示拓展证书的所有域名

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2355: URL: https://github.com/apache/apisix-dashboard/issues/2355#issuecomment-1447674428 Are you using the apisix ingress controller? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] bzp2010 opened a new issue, #8958: Proposal: Advanced LDAP authentication plugin

2023-02-27 Thread via GitHub
bzp2010 opened a new issue, #8958: URL: https://github.com/apache/apisix/issues/8958 # Background Currently APISIX has provided a simple LDAP authentication plugin that supports simple bind functions, but does not support, for example, user groups, for which users have a need. We can

[GitHub] [apisix] mscb402 commented on issue #8955: bug: Cors Plugin not working when request having authorization token

2023-02-27 Thread via GitHub
mscb402 commented on issue #8955: URL: https://github.com/apache/apisix/issues/8955#issuecomment-1447665063 I think you may need to add `withCredentials` to your front-end request. https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials If you are using axios for

[GitHub] [apisix-dashboard] spacewander commented on issue #2476: bug: ssl upgrade display :"Invalid date"

2023-02-27 Thread via GitHub
spacewander commented on issue #2476: URL: https://github.com/apache/apisix-dashboard/issues/2476#issuecomment-1447662487 APISIX doesn't have a certificate expiration time feature. Maybe this feature is totally implemented in the dashboard. -- This is an automated message from the Apache

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2631: data not found by key

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2631: URL: https://github.com/apache/apisix-dashboard/issues/2631#issuecomment-1447653339 Since Dashboard places a cache layer in front of etcd in order to reduce requests to and from etcd, it queries etcd and prints this log when there is no corresponding da

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-27 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447649238 > please check it (**wait** arg) in [lua-resty-consul](https://github.com/hamishforbes/lua-resty-consul), we use this lib to get infos from Consul got it -- This is an automate

[GitHub] [apisix] Fabriceli commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-27 Thread via GitHub
Fabriceli commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447644723 Before push the code, you can run `make lint` and `make license-check` in local to check the code and doc whether fit the code style -- This is an automated message from the Apache Git

[GitHub] [apisix] Fabriceli commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-27 Thread via GitHub
Fabriceli commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447637005 please check it (**timeout** arg) in [lua-resty-consul](https://github.com/hamishforbes/lua-resty-consul), we use this lib to get infos from Consul -- This is an automated message fro

[GitHub] [apisix-dashboard] anldrms commented on pull request #2750: Add search functionality for ID, host, and description fields

2023-02-27 Thread via GitHub
anldrms commented on PR #2750: URL: https://github.com/apache/apisix-dashboard/pull/2750#issuecomment-1447627973 > Please fix this? ![image](https://user-images.githubusercontent.com/48400568/221739276-96e120db-361b-45df-9580-8113b334100c.png) Do you know what causes exactly happened

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2746: Import Open API not importing x-apisix-* custom tags

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2746: URL: https://github.com/apache/apisix-dashboard/issues/2746#issuecomment-1447624730 Hi @giacomoverdi, Can you describe your original requirements in detail? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] dashohoxha opened a new issue, #8957: docs:

2023-02-27 Thread via GitHub
dashohoxha opened a new issue, #8957: URL: https://github.com/apache/apisix/issues/8957 ### Current State The dashboard section of the Getting Started does not explain how to login on the dashboard: https://apisix.apache.org/docs/apisix/getting-started/#using-the-apisix-dashboard

[GitHub] [apisix] AlinsRan commented on a diff in pull request #8901: docs: add the description of config.yaml support environment variables

2023-02-27 Thread via GitHub
AlinsRan commented on code in PR #8901: URL: https://github.com/apache/apisix/pull/8901#discussion_r1119584429 ## docs/zh/latest/admin-api.md: ## @@ -65,6 +65,46 @@ deployment: port: 9180 # Admin API 监听的 端口,必须使用与 node_listen 不同的端口。 ``` +### 使用环境

[GitHub] [apisix] AlinsRan commented on a diff in pull request #8901: docs: add the description of config.yaml support environment variables

2023-02-27 Thread via GitHub
AlinsRan commented on code in PR #8901: URL: https://github.com/apache/apisix/pull/8901#discussion_r1119584788 ## docs/zh/latest/admin-api.md: ## @@ -65,6 +65,46 @@ deployment: port: 9180 # Admin API 监听的 端口,必须使用与 node_listen 不同的端口。 ``` +### 使用环境

[GitHub] [apisix] AlinsRan commented on a diff in pull request #8901: docs: add the description of config.yaml support environment variables

2023-02-27 Thread via GitHub
AlinsRan commented on code in PR #8901: URL: https://github.com/apache/apisix/pull/8901#discussion_r1119583826 ## docs/zh/latest/admin-api.md: ## @@ -65,6 +65,46 @@ deployment: port: 9180 # Admin API 监听的 端口,必须使用与 node_listen 不同的端口。 ``` +### 使用环境

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-27 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447549444 @Fabriceli @spacewander I have fix , but there has a small discussion and uncertainty about a config of ```bash discovery: consul: timeout: wait: 60 ``` t

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2753: Error when importing OpenAPI spec from webui

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2753: URL: https://github.com/apache/apisix-dashboard/issues/2753#issuecomment-1447543581 > The following is the example OpenAPI spec I tested: > https://petstore3.swagger.io/api/v3/openapi.json I tested in the latest version of dashboard and found no

[GitHub] [apisix] jacobslei commented on issue #8945: bug: active healthy check occur error when upstream node is not exist

2023-02-27 Thread via GitHub
jacobslei commented on issue #8945: URL: https://github.com/apache/apisix/issues/8945#issuecomment-1447536157 Added More Error Logs: As the same time, apisix output following error logs every 2 hours: trying to increment a target that is not in the list :172.xx.xx.xx:20020 --

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2358: First click on menu item does not fetch data

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2358: URL: https://github.com/apache/apisix-dashboard/issues/2358#issuecomment-1447520655 This problem is not found in the latest version. If there is still a problem, please open it again. -- This is an automated message from the Apache Git Service. To res

[GitHub] [apisix-dashboard] Baoyuantop closed issue #2358: First click on menu item does not fetch data

2023-02-27 Thread via GitHub
Baoyuantop closed issue #2358: First click on menu item does not fetch data URL: https://github.com/apache/apisix-dashboard/issues/2358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [apisix-ingress-controller] renatomattos2912 opened a new issue, #1693: bug: plugin_config_name is not working in ApisixRoute CRD

2023-02-27 Thread via GitHub
renatomattos2912 opened a new issue, #1693: URL: https://github.com/apache/apisix-ingress-controller/issues/1693 ### Current Behavior When applying CRD for ApisixPluginConfig and ApisixRoute using plugin_config_name field to bound plugins to route, the bound is not being made after a

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #474: bug: apisix control service is not installed on k8s by helm chart

2023-02-27 Thread via GitHub
tao12345666333 commented on issue #474: URL: https://github.com/apache/apisix-helm-chart/issues/474#issuecomment-1447516130 I don't understand what "apisix control service" you refer to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2445: A question about redirect to https with 'lb + apisix'

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2445: URL: https://github.com/apache/apisix-dashboard/issues/2445#issuecomment-1447511342 > SSL cert not be the necessary conditions for http_to_https Dashboard needs to remove this restriction -- This is an automated message from the Apache Git Servi

[GitHub] [apisix-helm-chart] winglight commented on issue #474: bug: apisix control service is not installed on k8s by helm chart

2023-02-27 Thread via GitHub
winglight commented on issue #474: URL: https://github.com/apache/apisix-helm-chart/issues/474#issuecomment-1447503916 > Looks like the Control API options are not exposed in the helm chart. Sure yes, it's confused that there's no any clue in the document. -- This is an automated m

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2449: Add a IPv6 address in upstream nodes->host failed

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2449: URL: https://github.com/apache/apisix-dashboard/issues/2449#issuecomment-1447500482 Our Host should support IPV6 input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] spacewander commented on a diff in pull request #8898: feat(cli): support reserved environment variable "APISIX_DEPLOYMENT_E…

2023-02-27 Thread via GitHub
spacewander commented on code in PR #8898: URL: https://github.com/apache/apisix/pull/8898#discussion_r1119526435 ## t/cli/test_main.sh: ## @@ -211,6 +211,42 @@ fi echo "passed: resolve variables" +# support reserved environment variable APISIX_DEPLOYMENT_ETCD_HOST + +echo

[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2731: feat: support consul discovery

2023-02-27 Thread via GitHub
Baoyuantop commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1447493337 > @bzp2010 @Baoyuantop Could you have a look at this PR? Sorry for the late reply, I will review it later. -- This is an automated message from the Apache Git Service

[apisix] branch master updated: docs: shift workflow plugin to general category (#8939)

2023-02-27 Thread navendu
This is an automated email from the ASF dual-hosted git repository. navendu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 84f34d689 docs: shift workflow plugin to genera

[GitHub] [apisix] navendu-pottekkat closed issue #8422: docs: suggest to put workflow plugin in "general" category

2023-02-27 Thread via GitHub
navendu-pottekkat closed issue #8422: docs: suggest to put workflow plugin in "general" category URL: https://github.com/apache/apisix/issues/8422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] navendu-pottekkat merged pull request #8939: docs: shift workflow plugin to general category

2023-02-27 Thread via GitHub
navendu-pottekkat merged PR #8939: URL: https://github.com/apache/apisix/pull/8939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [apisix-dashboard] Fabriceli commented on pull request #2731: feat: support consul discovery

2023-02-27 Thread via GitHub
Fabriceli commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1447491944 @bzp2010 @Baoyuantop Could you have a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-ingress-controller] AlinsRan commented on issue #1003: bug: plugin_config_name is disappeared

2023-02-27 Thread via GitHub
AlinsRan commented on issue #1003: URL: https://github.com/apache/apisix-ingress-controller/issues/1003#issuecomment-1447489010 Hi @renatomattos2912 I think you can call admin-api to check. I repeat your steps. It works. ```shell apisix@apisix-5659f6c47f-rpsjl:/usr/local/apisix$ cu

[GitHub] [apisix-dashboard] SkyeYoung commented on pull request #2750: Add search functionality for ID, host, and description fields

2023-02-27 Thread via GitHub
SkyeYoung commented on PR #2750: URL: https://github.com/apache/apisix-dashboard/pull/2750#issuecomment-1447480597 Please fix this? ![image](https://user-images.githubusercontent.com/48400568/221739276-96e120db-361b-45df-9580-8113b334100c.png) -- This is an automated message from

[GitHub] [apisix] airstring commented on issue #8190: help request: when limit-count uses redis for full speed limit, changing the count value cannot take effect immediately

2023-02-27 Thread via GitHub
airstring commented on issue #8190: URL: https://github.com/apache/apisix/issues/8190#issuecomment-1447480360 @monkeyDluffy6017 After i modify group and count at the same time, will I have to change all the routes to use the new group ? -- This is an automated message from the Apache Git

[GitHub] [apisix] airstring commented on issue #8190: help request: when limit-count uses redis for full speed limit, changing the count value cannot take effect immediately

2023-02-27 Thread via GitHub
airstring commented on issue #8190: URL: https://github.com/apache/apisix/issues/8190#issuecomment-1447480025 > modify `group` and `count` at the same time After i modify `group` and `count` at the same time, will I have to change all the routes to use the new group ? -- This is a

[GitHub] [apisix] soulbird commented on issue #8944: help request: k8s ingress nginx as a upstream in apisix does not work!

2023-02-27 Thread via GitHub
soulbird commented on issue #8944: URL: https://github.com/apache/apisix/issues/8944#issuecomment-1447475628 Is there any error log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [apisix] soulbird commented on issue #8918: help request: health check monitoring on apisix dashboard

2023-02-27 Thread via GitHub
soulbird commented on issue #8918: URL: https://github.com/apache/apisix/issues/8918#issuecomment-1447472103 Dashboard does not have this function yet, you can check it through the API: https://github.com/apache/apisix/blob/master/docs/en/latest/control-api.md#get-v1healthcheck -- This is

[GitHub] [apisix-docker] juzhiyuan commented on issue #417: Example containers using old images

2023-02-27 Thread via GitHub
juzhiyuan commented on issue #417: URL: https://github.com/apache/apisix-docker/issues/417#issuecomment-1447470395 > , if I want to upgrade them in general, where can I get the latest images that would be used as potential replacement? To confirm: "them" - do you mean Prometheus, APIS

[GitHub] [apisix] yongxiaodong commented on issue #8835: help request: use helm install apisix version 3.1.0 ,ApisixRoute tips 404 Route Not Found

2023-02-27 Thread via GitHub
yongxiaodong commented on issue #8835: URL: https://github.com/apache/apisix/issues/8835#issuecomment-1447467858 > @imgolye Please provide the specific environment information, and paste the APISIX Ingress Controller logs. I encountered the same mistake. My K8S Cluster Version Is 1.2

[GitHub] [apisix] mscb402 commented on a diff in pull request #8915: docs: update faq about ssls and client tls andssl_trusted_certificate

2023-02-27 Thread via GitHub
mscb402 commented on code in PR #8915: URL: https://github.com/apache/apisix/pull/8915#discussion_r1119506932 ## docs/en/latest/FAQ.md: ## @@ -704,6 +704,14 @@ Another solution is to switch to an experimental gRPC-based configuration synchr prefix: "/apisix" ``` +## Wha

[GitHub] [apisix-website] SkyeYoung commented on issue #1505: [Site]: Wrong image

2023-02-27 Thread via GitHub
SkyeYoung commented on issue #1505: URL: https://github.com/apache/apisix-website/issues/1505#issuecomment-1447465740 > @SkyeYoung I'm on it, but would you mind providing me the source of the correct image that I'll be replacing with the current one (for both [`EN`](https://github.com/apac

[GitHub] [apisix] Martinprobu commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)

2023-02-27 Thread via GitHub
Martinprobu commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1447464175 > Is it still valid until now ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] Martinprobu commented on issue #8617: bug: One of the three etcd nodes is broken (once every two weeks)

2023-02-27 Thread via GitHub
Martinprobu commented on issue #8617: URL: https://github.com/apache/apisix/issues/8617#issuecomment-1447464381 > I found a workaround. I installed an external etcd cluster using the latest bitnami chart and set "removeMemberOnContainerTermination" to false. To work persistence must be enab

[GitHub] [apisix] mscb402 commented on a diff in pull request #8915: docs: update faq about ssls and client tls andssl_trusted_certificate

2023-02-27 Thread via GitHub
mscb402 commented on code in PR #8915: URL: https://github.com/apache/apisix/pull/8915#discussion_r1119504596 ## docs/zh/latest/FAQ.md: ## @@ -707,6 +707,14 @@ make GOOS=linux GOARCH=amd64 prefix: "/apisix" ``` +## ssls 和 upstream 配置中的 tls.client_cert 以及 config-default.y

[GitHub] [apisix] mscb402 commented on a diff in pull request #8915: docs: update faq about ssls and client tls andssl_trusted_certificate

2023-02-27 Thread via GitHub
mscb402 commented on code in PR #8915: URL: https://github.com/apache/apisix/pull/8915#discussion_r1119503964 ## docs/en/latest/FAQ.md: ## @@ -704,6 +704,14 @@ Another solution is to switch to an experimental gRPC-based configuration synchr prefix: "/apisix" ``` +## Wha

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-27 Thread via GitHub
dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447458625 > Could you fix the CI: https://github.com/apache/apisix/actions/runs/4280301682/jobs/7470288647? I am in process of this. -- This is an automated message from the Apache Git Servic

[apisix] branch master updated: docs: update doc for guide user to config auth etcd (#8849)

2023-02-27 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 0a9c93e4a docs: update doc for guide user to

[GitHub] [apisix] juzhiyuan merged pull request #8849: docs: update doc for guide user to config auth etcd

2023-02-27 Thread via GitHub
juzhiyuan merged PR #8849: URL: https://github.com/apache/apisix/pull/8849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@api

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #8915: docs: update faq about ssls and client tls andssl_trusted_certificate

2023-02-27 Thread via GitHub
juzhiyuan commented on code in PR #8915: URL: https://github.com/apache/apisix/pull/8915#discussion_r1119493744 ## docs/zh/latest/FAQ.md: ## @@ -707,6 +707,14 @@ make GOOS=linux GOARCH=amd64 prefix: "/apisix" ``` +## ssls 和 upstream 配置中的 tls.client_cert 以及 config-default

[GitHub] [apisix] tokers commented on a diff in pull request #8915: docs: update faq about ssls and client tls andssl_trusted_certificate

2023-02-27 Thread via GitHub
tokers commented on code in PR #8915: URL: https://github.com/apache/apisix/pull/8915#discussion_r1119492247 ## docs/en/latest/FAQ.md: ## @@ -704,6 +704,14 @@ Another solution is to switch to an experimental gRPC-based configuration synchr prefix: "/apisix" ``` +## What

[GitHub] [apisix] An-DJ commented on a diff in pull request #8911: refactor(admin): secrets and ssls

2023-02-27 Thread via GitHub
An-DJ commented on code in PR #8911: URL: https://github.com/apache/apisix/pull/8911#discussion_r1119492536 ## apisix/admin/resource.lua: ## @@ -148,23 +233,36 @@ function _M:put(id, conf, sub_path, args) end -function _M:delete(id) +function _M:delete(id, conf, sub_path)

[GitHub] [apisix] tokers commented on issue #8952: bug: failed to find proto by id in grpc-transcode plugin

2023-02-27 Thread via GitHub
tokers commented on issue #8952: URL: https://github.com/apache/apisix/issues/8952#issuecomment-1447436565 @Baoyuantop I don't think if you pass `1` in the /apisix/admin/protos` endpoint, APISIX will treat it as an integer. So you need to use `"1"` in the Route. -- This is an automated m

[GitHub] [apisix-helm-chart] jinjianming commented on a diff in pull request #482: feat: Add `gateway.enabled` to adjust in decoupled mode

2023-02-27 Thread via GitHub
jinjianming commented on code in PR #482: URL: https://github.com/apache/apisix-helm-chart/pull/482#discussion_r1119489935 ## charts/apisix/values.yaml: ## @@ -233,11 +234,13 @@ gateway: enabled: true servicePort: 80 containerPort: 9080 +nodePort: "" Review C

[GitHub] [apisix] spacewander commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-27 Thread via GitHub
spacewander commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447434695 Could you fix the CI: https://github.com/apache/apisix/actions/runs/4280301682/jobs/7470288647? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix] soulbird commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-27 Thread via GitHub
soulbird commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1119486102 ## t/core/request.t: ## @@ -439,3 +439,47 @@ while ($i <= 101) { $s --- response_body 101 + + + +=== TEST 15: add header +--- config +location /t { +cont

[GitHub] [apisix-helm-chart] tokers commented on issue #474: bug: apisix control service is not installed on k8s by helm chart

2023-02-27 Thread via GitHub
tokers commented on issue #474: URL: https://github.com/apache/apisix-helm-chart/issues/474#issuecomment-1447427862 Looks like the Control API options are not exposed in the helm chart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[apisix] branch master updated: refactor(admin): refactor admin consumers/plugin_metadata (#8820)

2023-02-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7a6dde704 refactor(admin): refactor admin c

[GitHub] [apisix] spacewander merged pull request #8820: refactor(admin): refactor admin consumers/plugin_metadata

2023-02-27 Thread via GitHub
spacewander merged PR #8820: URL: https://github.com/apache/apisix/pull/8820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander commented on a diff in pull request #8911: refactor(admin): secrets and ssls

2023-02-27 Thread via GitHub
spacewander commented on code in PR #8911: URL: https://github.com/apache/apisix/pull/8911#discussion_r1119478611 ## apisix/admin/resource.lua: ## @@ -121,16 +178,44 @@ function _M:put(id, conf, sub_path, args) return 405, {error_msg = "not supported `PUT` method for "

[GitHub] [apisix] youshaojun closed issue #8687: help request: 请问forward-auth插件服务超时状态码默认是403吗, 支持修改吗

2023-02-27 Thread via GitHub
youshaojun closed issue #8687: help request: 请问forward-auth插件服务超时状态码默认是403吗, 支持修改吗 URL: https://github.com/apache/apisix/issues/8687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [apisix] spacewander commented on pull request #8722: feat: Support clickhouse-logger plugin log option of request/response body

2023-02-27 Thread via GitHub
spacewander commented on PR #8722: URL: https://github.com/apache/apisix/pull/8722#issuecomment-1447390028 Let's merge master to solve the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix] soulbird commented on pull request #8722: feat: Support clickhouse-logger plugin log option of request/response body

2023-02-27 Thread via GitHub
soulbird commented on PR #8722: URL: https://github.com/apache/apisix/pull/8722#issuecomment-1447389650 Please resolve the conflicts @pixeldin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-dashboard] Baoyuantop commented on issue #2476: bug: ssl upgrade display :"Invalid date"

2023-02-27 Thread via GitHub
Baoyuantop commented on issue #2476: URL: https://github.com/apache/apisix-dashboard/issues/2476#issuecomment-1447387470 I followed the steps https://apisix.apache.org/docs/apisix/certificate/ to create a certificate resource in APISIX, but APISIX does not have an expiration time in the et

[apisix] branch dependabot/go_modules/ci/pod/openfunction/function-example/test-body/golang.org/x/text-0.3.8 updated (debac884b -> 7e4c0286e)

2023-02-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/ci/pod/openfunction/function-example/test-body/golang.org/x/text-0.3.8 in repository https://gitbox.apache.org/repos/asf/apisix.git omit debac884b chore(deps): bump

[apisix] branch master updated (0866480e7 -> 466fed28c)

2023-02-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git from 0866480e7 chore(ci): quietify the output of wget commands (#8737) add 466fed28c chore(deps): bump golang.org

[GitHub] [apisix] spacewander merged pull request #8925: chore(deps): bump golang.org/x/text from 0.3.7 to 0.3.8 in /ci/pod/openfunction/function-example/test-uri

2023-02-27 Thread via GitHub
spacewander merged PR #8925: URL: https://github.com/apache/apisix/pull/8925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[apisix] branch master updated: chore(ci): quietify the output of wget commands (#8737)

2023-02-27 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 0866480e7 chore(ci): quietify the output of

[GitHub] [apisix] spacewander merged pull request #8737: chore(ci): quietify the output of wget commands

2023-02-27 Thread via GitHub
spacewander merged PR #8737: URL: https://github.com/apache/apisix/pull/8737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix-website] Boburmirzo commented on pull request #1514: docs: add info about community meeting

2023-02-27 Thread via GitHub
Boburmirzo commented on PR #1514: URL: https://github.com/apache/apisix-website/pull/1514#issuecomment-1446995770 > @Boburmirzo @Nas-asira Could you please check this out? It looks great. Thank you for improving this! -- This is an automated message from the Apache Git Service. To r

[GitHub] [apisix-dashboard] todorinskiz commented on pull request #2731: feat: support consul discovery

2023-02-27 Thread via GitHub
todorinskiz commented on PR #2731: URL: https://github.com/apache/apisix-dashboard/pull/2731#issuecomment-1446903675 Thanks @Fabriceli for implementing this! It's funny that a [2000 lines PR](https://github.com/apache/apisix/pull/8380/files) is held up by a 5 line PR :smile: .. Looking

[GitHub] [apisix-helm-chart] coffeebe4code opened a new issue, #487: Bug: Etcd Cluster State After First Install

2023-02-27 Thread via GitHub
coffeebe4code opened a new issue, #487: URL: https://github.com/apache/apisix-helm-chart/issues/487 I would be happy to do a PR for this. There was an issue with deploying the helm chart a second time. After digging, it appeared to be related to a setting in `etcd` configuration. Helm would

[GitHub] [apisix-helm-chart] coffeebe4code opened a new issue, #486: Apisix Helm Questions

2023-02-27 Thread via GitHub
coffeebe4code opened a new issue, #486: URL: https://github.com/apache/apisix-helm-chart/issues/486 First of all, great product very easy to get set up! I'm wondering what the recommendation or purpose behind the `values` for `apisix.kind` being either `Deployment` or `DaemonSet`. My

[GitHub] [apisix-ingress-controller] SakaZhang closed issue #1692: bug: Can not ping k8s svc fqdn

2023-02-27 Thread via GitHub
SakaZhang closed issue #1692: bug: Can not ping k8s svc fqdn URL: https://github.com/apache/apisix-ingress-controller/issues/1692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-ingress-controller] SakaZhang commented on issue #1692: bug: Can not ping k8s svc fqdn

2023-02-27 Thread via GitHub
SakaZhang commented on issue #1692: URL: https://github.com/apache/apisix-ingress-controller/issues/1692#issuecomment-1446712970 check `/etc/hosts` when you are in cloud machine... It's not APISIX problem. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix-ingress-controller] SakaZhang commented on issue #1692: bug: Can not ping k8s svc fqdn

2023-02-27 Thread via GitHub
SakaZhang commented on issue #1692: URL: https://github.com/apache/apisix-ingress-controller/issues/1692#issuecomment-1446703838 see this: https://github.com/coredns/coredns/issues/3982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix] Neilblaze commented on pull request #8951: docs: fix expose api test url

2023-02-27 Thread via GitHub
Neilblaze commented on PR #8951: URL: https://github.com/apache/apisix/pull/8951#issuecomment-1446696571 @2456868764 I think there's already a PR on the same issue: #8730. Feel free to head over there if you want to mention anything. -- This is an automated message from the Apache Git Ser

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1666: ci: add yamllint rules

2023-02-27 Thread via GitHub
tao12345666333 commented on code in PR #1666: URL: https://github.com/apache/apisix-ingress-controller/pull/1666#discussion_r1119025996 ## .yamllint.yml: ## @@ -0,0 +1,49 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreemen

[GitHub] [apisix-ingress-controller] sakulali commented on a diff in pull request #1666: ci: add yamllint rules

2023-02-27 Thread via GitHub
sakulali commented on code in PR #1666: URL: https://github.com/apache/apisix-ingress-controller/pull/1666#discussion_r1118979933 ## .yamllint.yml: ## @@ -0,0 +1,49 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. S

[GitHub] [apisix-helm-chart] coffeebe4code commented on issue #474: bug: apisix control service is not installed on k8s by helm chart

2023-02-27 Thread via GitHub
coffeebe4code commented on issue #474: URL: https://github.com/apache/apisix-helm-chart/issues/474#issuecomment-1446568035 Hello, I just went through an install of the apisix helm chart. And didn't have any issues with this. The admin api will be exposed through the service on port

[GitHub] [apisix] renatomattos2912 opened a new issue, #8956: bug: plugin_config_name is not working in ApisixRoute CRD

2023-02-27 Thread via GitHub
renatomattos2912 opened a new issue, #8956: URL: https://github.com/apache/apisix/issues/8956 ### Current Behavior When applying CRD for ApisixPluginConfig and ApisixRoute using plugin_config_name field to bound plugins to route, the bound is not being made after all, so each CRD is

[GitHub] [apisix] jiangfucheng commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-27 Thread via GitHub
jiangfucheng commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1118781848 ## apisix/core/request.lua: ## @@ -131,26 +129,41 @@ function _M.set_header(ctx, header_name, header_value) changed = a6_request.is_request_header_set()

[GitHub] [apisix] jiangfucheng commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

2023-02-27 Thread via GitHub
jiangfucheng commented on code in PR #8824: URL: https://github.com/apache/apisix/pull/8824#discussion_r1118781474 ## t/core/request.t: ## @@ -439,3 +439,47 @@ while ($i <= 101) { $s --- response_body 101 + + + +=== TEST 15: add header +--- config +location /t { +

[GitHub] [apisix-ingress-controller] renatomattos2912 commented on issue #1003: bug: plugin_config_name is disappeared

2023-02-27 Thread via GitHub
renatomattos2912 commented on issue #1003: URL: https://github.com/apache/apisix-ingress-controller/issues/1003#issuecomment-1446341568 Hi Everyone, im having the same problem, but im running all the latest versions of helm and apisix and ingress controller, so the solution pointed here is

[GitHub] [apisix-helm-chart] jiangfucheng commented on a diff in pull request #468: feat: support v2 version for hpa

2023-02-27 Thread via GitHub
jiangfucheng commented on code in PR #468: URL: https://github.com/apache/apisix-helm-chart/pull/468#discussion_r1118733901 ## charts/apisix-ingress-controller/README.md: ## @@ -109,6 +109,7 @@ The same for container level, you need to set: | autoscaling.maxReplicas | int | `10

[GitHub] [apisix-website] navendu-pottekkat commented on pull request #1514: docs: add info about community meeting

2023-02-27 Thread via GitHub
navendu-pottekkat commented on PR #1514: URL: https://github.com/apache/apisix-website/pull/1514#issuecomment-1446307320 @Boburmirzo @Nas-asira Could you please check this out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix-website] netlify[bot] commented on pull request #1514: docs: add info about community meeting

2023-02-27 Thread via GitHub
netlify[bot] commented on PR #1514: URL: https://github.com/apache/apisix-website/pull/1514#issuecomment-1446304721 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |:-:|| |🔨 Latest commit | 8fd40878722317838a53ca9788920da3ed0721

[GitHub] [apisix-website] navendu-pottekkat opened a new pull request, #1514: docs: add info about community meeting

2023-02-27 Thread via GitHub
navendu-pottekkat opened a new pull request, #1514: URL: https://github.com/apache/apisix-website/pull/1514 Signed-off-by: Navendu Pottekkat Adds info about the community meeting to the events page. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix] Caelebs commented on issue #8950: docker error.log Permission denied

2023-02-27 Thread via GitHub
Caelebs commented on issue #8950: URL: https://github.com/apache/apisix/issues/8950#issuecomment-1446236356 maybe you can try to modify the directory permissions. `chmod 755 ./apisix_log` or you can try to start `docker-compose` as root user? -- This is an automated message from the A

[GitHub] [apisix] spacewander commented on a diff in pull request #8898: feat(cli): support reserved environment variable "APISIX_DEPLOYMENT_E…

2023-02-27 Thread via GitHub
spacewander commented on code in PR #8898: URL: https://github.com/apache/apisix/pull/8898#discussion_r1118636116 ## apisix/cli/ngx_tpl.lua: ## @@ -51,6 +51,9 @@ worker_shutdown_timeout {* worker_shutdown_timeout *}; env APISIX_PROFILE; env PATH; # for searching external plugi

[GitHub] [apisix] Fabriceli commented on issue #8934: bug: call download file route got error [upstream sent invalid header: "\x20..."]

2023-02-27 Thread via GitHub
Fabriceli commented on issue #8934: URL: https://github.com/apache/apisix/issues/8934#issuecomment-1446143236 We fixed it, we found that it was added space in response header by mistake, when we read the source code of the legacy application. -- This is an automated message from the Apac

[GitHub] [apisix] Fabriceli closed issue #8934: bug: call download file route got error [upstream sent invalid header: "\x20..."]

2023-02-27 Thread via GitHub
Fabriceli closed issue #8934: bug: call download file route got error [upstream sent invalid header: "\x20..."] URL: https://github.com/apache/apisix/issues/8934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix] Fabriceli commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

2023-02-27 Thread via GitHub
Fabriceli commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1446115373 cc @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix] jinjianming commented on issue #8947: help request: Data-plane cannot dynamically modify the upstreams address. You need to execute apisix reload to get the latest address

2023-02-27 Thread via GitHub
jinjianming commented on issue #8947: URL: https://github.com/apache/apisix/issues/8947#issuecomment-1446089345 @tokers When the upstream does not change, the first startup can work normally. Once the Upstream changes, the data plane will not be able to load the latest address. What is the

  1   2   >