[GitHub] [apisix-website] netlify[bot] commented on pull request #1471: docs:add four blogs

2023-01-11 Thread GitBox
netlify[bot] commented on PR #1471: URL: https://github.com/apache/apisix-website/pull/1471#issuecomment-1379870104 ### 👷 Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| |🔨 Latest commit | 3a929fc0

[GitHub] [apisix-website] KID-G opened a new pull request, #1471: docs:add four blogs

2023-01-11 Thread GitBox
KID-G opened a new pull request, #1471: URL: https://github.com/apache/apisix-website/pull/1471 Changes: Add four blogs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [apisix] bigbug-dachong opened a new issue, #8664: help request: sourceCode deployment on macOS M1

2023-01-11 Thread GitBox
bigbug-dachong opened a new issue, #8664: URL: https://github.com/apache/apisix/issues/8664 ### Description i have a problem when i start apisix-server by sourceCode-deployment env: macOS M1 refer to: https://apisix.apache.org/zh/docs/apisix/building-apisix/

[GitHub] [apisix] MarkCupitt opened a new issue, #8663: bug: failed to find any SSL certificate by SNI:

2023-01-11 Thread GitBox
MarkCupitt opened a new issue, #8663: URL: https://github.com/apache/apisix/issues/8663 ### Current Behavior This Error occurs: ``` 2023/01/12 06:09:20 [error] 64#64: *426241 [lua] radixtree_sni.lua:170: match_and_set(): failed to find any SSL certificate by SNI: e3.enginee

[GitHub] [apisix-helm-chart] juzhiyuan commented on a diff in pull request #451: docs: added Apache LICENSE

2023-01-11 Thread GitBox
juzhiyuan commented on code in PR #451: URL: https://github.com/apache/apisix-helm-chart/pull/451#discussion_r1067733008 ## LICENSE: ## @@ -0,0 +1,201 @@ + Apache License + Version 2.0, January 2004 +

[GitHub] [apisix-helm-chart] juzhiyuan commented on a diff in pull request #451: docs: added Apache LICENSE

2023-01-11 Thread GitBox
juzhiyuan commented on code in PR #451: URL: https://github.com/apache/apisix-helm-chart/pull/451#discussion_r1067733008 ## LICENSE: ## @@ -0,0 +1,201 @@ + Apache License + Version 2.0, January 2004 +

[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #451: docs: added Apache LICENSE

2023-01-11 Thread GitBox
tao12345666333 commented on code in PR #451: URL: https://github.com/apache/apisix-helm-chart/pull/451#discussion_r1067732848 ## LICENSE: ## @@ -0,0 +1,201 @@ + Apache License + Version 2.0, January 2004 +

[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #451: docs: added Apache LICENSE

2023-01-11 Thread GitBox
tao12345666333 commented on code in PR #451: URL: https://github.com/apache/apisix-helm-chart/pull/451#discussion_r1067731294 ## LICENSE: ## @@ -0,0 +1,201 @@ + Apache License + Version 2.0, January 2004 +

[GitHub] [apisix] spacewander commented on a diff in pull request #8640: feat: stream subsystem support kubernetes service discovery

2023-01-11 Thread GitBox
spacewander commented on code in PR #8640: URL: https://github.com/apache/apisix/pull/8640#discussion_r1067731593 ## ci/linux_openresty_1_19_runner.sh: ## @@ -17,5 +17,5 @@ # -export OPENRESTY_VERSION=1.19.3.2 +export OPENRESTY_VERSION=1.19.9.1 Review Comment: something

[GitHub] [apisix] spacewander commented on a diff in pull request #8640: feat: stream subsystem support kubernetes service discovery

2023-01-11 Thread GitBox
spacewander commented on code in PR #8640: URL: https://github.com/apache/apisix/pull/8640#discussion_r1067729356 ## apisix/discovery/kubernetes/init.lua: ## @@ -331,9 +332,18 @@ local function start_fetch(handle) ngx.timer.at(0, timer_runner) end +local function get_end

[GitHub] [apisix] spacewander commented on issue #8653: bug: encrypt_conf(): failed to get schema for plugin: proxy-rewrite

2023-01-11 Thread GitBox
spacewander commented on issue #8653: URL: https://github.com/apache/apisix/issues/8653#issuecomment-1379845004 > @MarkCupitt First of all, this error message is harmless. It occurs since you don't enable the `apisix.data_encryption.enable` in your `config.yaml`. > > On the other hand

[GitHub] [apisix] spacewander merged pull request #8627: chore: make send_stream_request more clear

2023-01-11 Thread GitBox
spacewander merged PR #8627: URL: https://github.com/apache/apisix/pull/8627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] soulbird commented on pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-11 Thread GitBox
soulbird commented on PR #8660: URL: https://github.com/apache/apisix/pull/8660#issuecomment-1379823150 Should also update doc: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/jwt-auth.md If you are interested, you can update the Chinese documentation at the same

[GitHub] [apisix] soulbird commented on pull request #8660: fix: unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-11 Thread GitBox
soulbird commented on PR #8660: URL: https://github.com/apache/apisix/pull/8660#issuecomment-1379820347 After deleting a configuration, a break change is introduced in APISIX, so the title of the PR should be `change: xxx`, here we change the jwt-auth plugin, so it is best to `change(jwt-au

[GitHub] [apisix] shreemaan-abhishek commented on pull request #8660: fix: unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-11 Thread GitBox
shreemaan-abhishek commented on PR #8660: URL: https://github.com/apache/apisix/pull/8660#issuecomment-1379815228 Can I delete the `apisix/core/vault.lua` file now? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] e1ijah1 opened a new pull request, #8662: docs: fix error link about nacos deployment tutorial

2023-01-11 Thread GitBox
e1ijah1 opened a new pull request, #8662: URL: https://github.com/apache/apisix/pull/8662 fix error link about nacos deployment tutorial ### Description Fixes #8657 ### Checklist - [ ] I have explained the need for this PR and the problem it solves

[GitHub] [apisix] e1ijah1 commented on issue #8657: docs: error link about nacos deployment tutorial in apisix-seed page

2023-01-11 Thread GitBox
e1ijah1 commented on issue #8657: URL: https://github.com/apache/apisix/issues/8657#issuecomment-1379811431 I'd like to help with this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix-ingress-controller] machinly commented on pull request #1588: add ldap-auth authorization method

2023-01-11 Thread GitBox
machinly commented on PR #1588: URL: https://github.com/apache/apisix-ingress-controller/pull/1588#issuecomment-1379794323 > LGTM > > Just remove some modifications related to v2beta3. Thanks for the review. I'm completed removing ldap-auth support for v2beta3. -- This is an

[GitHub] [apisix] spacewander commented on pull request #8623: docs: change the file name to 'create-ssl.py'.If 'ssl.py' is used as …

2023-01-11 Thread GitBox
spacewander commented on PR #8623: URL: https://github.com/apache/apisix/pull/8623#issuecomment-1379756125 LGTM. So `mtls.md` also has the same problem. Would you also fix it in this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] ffjiang666 commented on issue #8591: help request: TCP proxy

2023-01-11 Thread GitBox
ffjiang666 commented on issue #8591: URL: https://github.com/apache/apisix/issues/8591#issuecomment-1379755423 @monkeyDluffy6017 Yes, I really want to locate it and resolve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] An-DJ opened a new pull request, #8661: [WIP]refactor(admin): stream_routes

2023-01-11 Thread GitBox
An-DJ opened a new pull request, #8661: URL: https://github.com/apache/apisix/pull/8661 ### Description Fixes #8569 ### Checklist - [X] I have explained the need for this PR and the problem it solves - [X] I have explained the changes or the new features a

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #891: [DISCUSS] APISIX Ingress's roadmap for 2022

2023-01-11 Thread GitBox
tao12345666333 closed issue #891: [DISCUSS] APISIX Ingress's roadmap for 2022 URL: https://github.com/apache/apisix-ingress-controller/issues/891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #891: [DISCUSS] APISIX Ingress's roadmap for 2022

2023-01-11 Thread GitBox
tao12345666333 commented on issue #891: URL: https://github.com/apache/apisix-ingress-controller/issues/891#issuecomment-1379741389 2022 recap: * We released the v1.4~1.6 version, * star: 390 -> 680 * contributor: 57 -> 100 Thanks all! I will close this one and op

[GitHub] [apisix] soulbird commented on a diff in pull request #8660: feat: use get method from kms module

2023-01-11 Thread GitBox
soulbird commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1067645036 ## apisix/plugins/jwt-auth.lua: ## @@ -252,15 +253,12 @@ end local function get_secret(conf, consumer_name) local secret = conf.secret if conf.vault then Re

[GitHub] [apisix-website] SkyeYoung merged pull request #1470: docs:add release apisix ingress 1.6

2023-01-11 Thread GitBox
SkyeYoung merged PR #1470: URL: https://github.com/apache/apisix-website/pull/1470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [apisix-website] SkyeYoung commented on pull request #1470: docs:add release apisix ingress 1.6

2023-01-11 Thread GitBox
SkyeYoung commented on PR #1470: URL: https://github.com/apache/apisix-website/pull/1470#issuecomment-1379731590 > LGTM,but images in my browser can't see them > @guoqqqi @juzhiyuan Looks weird, why the img src changed? > > current weird src: [static.apiseven.com/apisix-webp/up

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1598: docs: update compatibility with APISIX

2023-01-11 Thread GitBox
codecov-commenter commented on PR #1598: URL: https://github.com/apache/apisix-ingress-controller/pull/1598#issuecomment-1379726869 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1598?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaig

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request, #1598: docs: update compatibility with APISIX

2023-01-11 Thread GitBox
tao12345666333 opened a new pull request, #1598: URL: https://github.com/apache/apisix-ingress-controller/pull/1598 Signed-off-by: Jintao Zhang ### Type of change: - [ ] Documents ### What this PR does / why we need it: ### Pre-submissi

[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8660: feat: use get method from kms module

2023-01-11 Thread GitBox
shreemaan-abhishek opened a new pull request, #8660: URL: https://github.com/apache/apisix/pull/8660 ### Description Fixes #8424 ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the ne

[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #450: chore: release 0.13.0 for APISIX v2

2023-01-11 Thread GitBox
tao12345666333 merged PR #450: URL: https://github.com/apache/apisix-helm-chart/pull/450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8591: help request: TCP proxy

2023-01-11 Thread GitBox
monkeyDluffy6017 commented on issue #8591: URL: https://github.com/apache/apisix/issues/8591#issuecomment-1379711639 I think it's something like network problem, are you interested in locating this problem? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [apisix] ffjiang666 commented on issue #8591: help request: TCP proxy

2023-01-11 Thread GitBox
ffjiang666 commented on issue #8591: URL: https://github.com/apache/apisix/issues/8591#issuecomment-1379707040 @flechter Yeah. I think so too. So, is it a bug in apisix docker version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-dashboard] SkyeYoung commented on issue #2700: The monitoring page needs to be reconfigured

2023-01-11 Thread GitBox
SkyeYoung commented on issue #2700: URL: https://github.com/apache/apisix-dashboard/issues/2700#issuecomment-1379706265 Well, looks like it should be stored in localStorage but not sessionStorage. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] qihaiyan commented on issue #8634: help request: 2.x稳定版和3.x最新版,etcd数据是否兼容

2023-01-11 Thread GitBox
qihaiyan commented on issue #8634: URL: https://github.com/apache/apisix/issues/8634#issuecomment-1379705662 The key ```ssl``` in etcd has been changed to ```ssls``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] swtseaman commented on issue #8654: help request: apisix dashboard grafana不能选择节点

2023-01-11 Thread GitBox
swtseaman commented on issue #8654: URL: https://github.com/apache/apisix/issues/8654#issuecomment-1379702038 产生请求后就有了,谢谢! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [apisix] swtseaman closed issue #8654: help request: apisix dashboard grafana不能选择节点

2023-01-11 Thread GitBox
swtseaman closed issue #8654: help request: apisix dashboard grafana不能选择节点 URL: https://github.com/apache/apisix/issues/8654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix] spacewander commented on issue #8647: bug: ElasticSearch logger not working with error Action/metadata line [1] contains an unknown parameter [_type]

2023-01-11 Thread GitBox
spacewander commented on issue #8647: URL: https://github.com/apache/apisix/issues/8647#issuecomment-1379700422 @An-DJ Would you give it a try? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] ronething commented on issue #8554: bug: discovery/dns cause panic

2023-01-11 Thread GitBox
ronething commented on issue #8554: URL: https://github.com/apache/apisix/issues/8554#issuecomment-1379700098 @caibirdme Hi, as PR https://github.com/apache/apisix/pull/8593 is merged, you can pull master branch in your development environment and try dns service discovery in the stream sub

[GitHub] [apisix] swtseaman commented on issue #8654: help request: apisix dashboard grafana不能选择节点

2023-01-11 Thread GitBox
swtseaman commented on issue #8654: URL: https://github.com/apache/apisix/issues/8654#issuecomment-1379698705 > Make sure you have enable Prometheus plugin in global: ![image](https://user-images.githubusercontent.com/13508022/211763343-830d2ae4-304d-40ef-8e7e-2642fa427619.png)

[GitHub] [apisix-helm-chart] tao12345666333 opened a new pull request, #450: chore: release 0.13.0 for APISIX v2

2023-01-11 Thread GitBox
tao12345666333 opened a new pull request, #450: URL: https://github.com/apache/apisix-helm-chart/pull/450 Signed-off-by: Jintao Zhang #448 0.13 is for APISIX v2.x. If you are using APISIX v3.x, please use v1.x Helm chart. -- This is an automated message from the Apache G

[GitHub] [apisix-ingress-controller] github-actions[bot] commented on pull request #1395: fix: Delete redundant upstream objects

2023-01-11 Thread GitBox
github-actions[bot] commented on PR #1395: URL: https://github.com/apache/apisix-ingress-controller/pull/1395#issuecomment-1379694487 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's inc

[GitHub] [apisix-ingress-controller] github-actions[bot] commented on issue #1305: APISIX ingress controller logs error about OLD ingress configurations

2023-01-11 Thread GitBox
github-actions[bot] commented on issue #1305: URL: https://github.com/apache/apisix-ingress-controller/issues/1305#issuecomment-1379694392 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at

[GitHub] [apisix-ingress-controller] github-actions[bot] closed issue #1305: APISIX ingress controller logs error about OLD ingress configurations

2023-01-11 Thread GitBox
github-actions[bot] closed issue #1305: APISIX ingress controller logs error about OLD ingress configurations URL: https://github.com/apache/apisix-ingress-controller/issues/1305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] tokers commented on issue #8648: bug: attempt to index local 'item' (a boolean value)

2023-01-11 Thread GitBox
tokers commented on issue #8648: URL: https://github.com/apache/apisix/issues/8648#issuecomment-1379692408 > > @cloorc Did you see any error log entries before these kinds of errors? I think this error is not the "primary crime scene". Also, is it possible to print the data in your ETCD?

[GitHub] [apisix-website] SkyeYoung commented on pull request #1470: docs:add release apisix ingress 1.6

2023-01-11 Thread GitBox
SkyeYoung commented on PR #1470: URL: https://github.com/apache/apisix-website/pull/1470#issuecomment-1379691817 @guoqqqi Looks weird, why the img src changed? current weird src: https://static.apiseven.com/apisix-webp/uploads/2023/01/11/ru9yoUrn_blog2.webp but old src looks like:

[GitHub] [apisix] tokers commented on issue #8529: help request: in apisix etcd failed to parse domain

2023-01-11 Thread GitBox
tokers commented on issue #8529: URL: https://github.com/apache/apisix/issues/8529#issuecomment-1379689882 > https://user-images.githubusercontent.com/60866246/211786738-ac52039b-f371-4d06-b77f-ceaa04f894e5.png";> > > DNS server works fine.I found the problem is function _deepcopy(). t

[GitHub] [apisix] spacewander commented on issue #7888: feat: kafka-logger not supports ssl

2023-01-11 Thread GitBox
spacewander commented on issue #7888: URL: https://github.com/apache/apisix/issues/7888#issuecomment-1379689484 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [apisix] spacewander closed issue #7888: feat: kafka-logger not supports ssl

2023-01-11 Thread GitBox
spacewander closed issue #7888: feat: kafka-logger not supports ssl URL: https://github.com/apache/apisix/issues/7888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [apisix] spacewander closed issue #7404: Proposal: support openfunction serverless framework plugin

2023-01-11 Thread GitBox
spacewander closed issue #7404: Proposal: support openfunction serverless framework plugin URL: https://github.com/apache/apisix/issues/7404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [apisix] spacewander commented on issue #7404: Proposal: support openfunction serverless framework plugin

2023-01-11 Thread GitBox
spacewander commented on issue #7404: URL: https://github.com/apache/apisix/issues/7404#issuecomment-1379689143 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [apisix-dashboard] freemankevin commented on issue #2700: The monitoring page needs to be reconfigured

2023-01-11 Thread GitBox
freemankevin commented on issue #2700: URL: https://github.com/apache/apisix-dashboard/issues/2700#issuecomment-1379689094 Frequent configuration is very annoying. This kind of configuration will not change frequently. There is no need to configure it frequently. But how can the browser no

[GitHub] [apisix] spacewander closed issue #8331: help request: I have a question,i used file-logger,18/5000 I want to record that response actually returns the data.

2023-01-11 Thread GitBox
spacewander closed issue #8331: help request: I have a question,i used file-logger,18/5000 I want to record that response actually returns the data. URL: https://github.com/apache/apisix/issues/8331 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-ingress-controller] anhldbk commented on a diff in pull request #1593: docs: update controller to use adminAPIVersion=v3

2023-01-11 Thread GitBox
anhldbk commented on code in PR #1593: URL: https://github.com/apache/apisix-ingress-controller/pull/1593#discussion_r1067607341 ## docs/en/latest/deployments/ack.md: ## @@ -44,14 +44,15 @@ The script below installs APISIX and the ingress controller: helm repo add apisix https

[GitHub] [apisix-docker] soulbird commented on pull request #406: chore: change the user for all-in-one

2023-01-11 Thread GitBox
soulbird commented on PR #406: URL: https://github.com/apache/apisix-docker/pull/406#issuecomment-1379677309 Wouldn't it be better to use `sudo`? can you try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix-docker] soulbird commented on pull request #405: fix: config files overwritten by docker-entrypoint.sh

2023-01-11 Thread GitBox
soulbird commented on PR #405: URL: https://github.com/apache/apisix-docker/pull/405#issuecomment-1379676552 If the configuration related to standalone is not enabled in the `${PREFIX}/conf/config.yaml` file, then setting APISIX_STAND_ALONE will be invalid -- This is an automated message

[GitHub] [apisix] spacewander merged pull request #8593: feat: stream subsystem support dns service discovery

2023-01-11 Thread GitBox
spacewander merged PR #8593: URL: https://github.com/apache/apisix/pull/8593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander merged pull request #8584: feat: stream subsystem support nacos service discovery

2023-01-11 Thread GitBox
spacewander merged PR #8584: URL: https://github.com/apache/apisix/pull/8584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander closed issue #7779: feat: As a user, I want to support service discovery in the stream subsystem

2023-01-11 Thread GitBox
spacewander closed issue #7779: feat: As a user, I want to support service discovery in the stream subsystem URL: https://github.com/apache/apisix/issues/7779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] spacewander closed issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat

2023-01-11 Thread GitBox
spacewander closed issue #8569: feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat URL: https://github.com/apache/apisix/issues/8569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix] spacewander merged pull request #8611: refactor(admin): refactor resource routes

2023-01-11 Thread GitBox
spacewander merged PR #8611: URL: https://github.com/apache/apisix/pull/8611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@a

[GitHub] [apisix] spacewander commented on issue #8650: ./linux-install-openresty.sh: line 35: OPENRESTY_VERSION: unbound variable

2023-01-11 Thread GitBox
spacewander commented on issue #8650: URL: https://github.com/apache/apisix/issues/8650#issuecomment-1379669047 You need to setup the env, like: https://github.com/apache/apisix/blob/cbf2297c86409fe373c5eb70922f58e6f448e41a/.github/workflows/code-lint.yml#L23 BTW, this script is only

[GitHub] [apisix] brentmjohnson commented on issue #4942: allow proxy-rewrite plugin to rewrite x-forwarded-port request header

2023-01-11 Thread GitBox
brentmjohnson commented on issue #4942: URL: https://github.com/apache/apisix/issues/4942#issuecomment-1379650596 Another alternative is to modify the listen ports for apisix to the following: ``` apisix:# universal configurations node_listen: 80# APISIX listening port

[GitHub] [apisix] juzhiyuan commented on issue #8657: docs: error link about nacos deployment tutorial in apisix-seed page

2023-01-11 Thread GitBox
juzhiyuan commented on issue #8657: URL: https://github.com/apache/apisix/issues/8657#issuecomment-1379643087 Thanks for the report! Would you like to update it? You can update it here: https://github.com/apache/apisix/edit/release/3.1/docs/en/latest/discovery/control-plane-service-di

[GitHub] [apisix-docker] juzhiyuan commented on issue #381: Remove separate section for APISIX Docker docs

2023-01-11 Thread GitBox
juzhiyuan commented on issue #381: URL: https://github.com/apache/apisix-docker/issues/381#issuecomment-1379639770 Hi @navendu-pottekkat, > I assumed that the README on Docker Hub was just a copy of the GitHub README, but this is not the same. Where is it coming from? We have o

[GitHub] [apisix] MarkCupitt commented on issue #8653: bug: encrypt_conf(): failed to get schema for plugin: proxy-rewrite

2023-01-11 Thread GitBox
MarkCupitt commented on issue #8653: URL: https://github.com/apache/apisix/issues/8653#issuecomment-1379615498 Ok, thanks .. wil ignore it then .. appreciate the feedback -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] niuguy commented on issue #4942: allow proxy-rewrite plugin to rewrite x-forwarded-port request header

2023-01-11 Thread GitBox
niuguy commented on issue #4942: URL: https://github.com/apache/apisix/issues/4942#issuecomment-1379569298 > For anyone needs workaround: Apply plugin serverless-pre-function to the route config Sample code: > > ```json > "plugins": { > "serverless-pre-function": {

[GitHub] [apisix] flechter commented on issue #8591: help request: TCP proxy

2023-01-11 Thread GitBox
flechter commented on issue #8591: URL: https://github.com/apache/apisix/issues/8591#issuecomment-1378989283 I had the same problem, my apisix was running in docker, so I try to install it on a server without Docker and it's working. So I thing the stream was not workin in docker mode.

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2023-01-11 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1067040193 ## apisix/admin/kms.lua: ## @@ -0,0 +1,203 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NO

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2023-01-11 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1067038996 ## apisix/admin/kms.lua: ## @@ -0,0 +1,203 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NO

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8394: feat(admin): add kms admin api

2023-01-11 Thread GitBox
shreemaan-abhishek commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1067026201 ## apisix/admin/kms.lua: ## @@ -0,0 +1,203 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements.

[GitHub] [apisix] kingluo commented on issue #8655: bug: GRPC transcode can't work with protobuf.Struct

2023-01-11 Thread GitBox
kingluo commented on issue #8655: URL: https://github.com/apache/apisix/issues/8655#issuecomment-1378780874 @gaoxingliang `Struct` is just a `map` with `oneof` value. They are ok in lua-protobuf: https://github.com/starwing/lua-protobuf/blob/master/test.lua#L657 https://github.c

[GitHub] [apisix] ronething commented on a diff in pull request #8640: feat: stream subsystem support kubernetes service discovery

2023-01-11 Thread GitBox
ronething commented on code in PR #8640: URL: https://github.com/apache/apisix/pull/8640#discussion_r1065540614 ## ci/linux_openresty_1_19_runner.sh: ## @@ -17,5 +17,5 @@ # -export OPENRESTY_VERSION=1.19.3.2 +export OPENRESTY_VERSION=1.19.9.1 Review Comment: > We have p

[GitHub] [apisix] nfrankel commented on issue #8167: bug: proxy-rewrite and proxy-mirror do not work together

2023-01-11 Thread GitBox
nfrankel commented on issue #8167: URL: https://github.com/apache/apisix/issues/8167#issuecomment-1378742626 There's no reaction on the Mailing List. Can we proceed please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #1564: [Docs] Add how to enable Plugins in the ApisixRoute#Plugins doc

2023-01-11 Thread GitBox
tao12345666333 closed issue #1564: [Docs] Add how to enable Plugins in the ApisixRoute#Plugins doc URL: https://github.com/apache/apisix-ingress-controller/issues/1564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1596: docs: add note about enabling the Plugin

2023-01-11 Thread GitBox
tao12345666333 merged PR #1596: URL: https://github.com/apache/apisix-ingress-controller/pull/1596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notif

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #394: Remove separate section for APISIX Helm Chart docs

2023-01-11 Thread GitBox
tao12345666333 commented on issue #394: URL: https://github.com/apache/apisix-helm-chart/issues/394#issuecomment-1378741005 OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [apisix-helm-chart] navendu-pottekkat commented on issue #394: Remove separate section for APISIX Helm Chart docs

2023-01-11 Thread GitBox
navendu-pottekkat commented on issue #394: URL: https://github.com/apache/apisix-helm-chart/issues/394#issuecomment-1378733852 Looking through the docs, we can move everything to the respective project documentation. For APISIX Ingress controller, we can move these to notes in the installa

[GitHub] [apisix-docker] navendu-pottekkat commented on issue #381: Remove separate section for APISIX Docker docs

2023-01-11 Thread GitBox
navendu-pottekkat commented on issue #381: URL: https://github.com/apache/apisix-docker/issues/381#issuecomment-1378724141 @juzhiyuan @tokers Looking through the current documentation, I think we can move everything in the APISIX Docker section to the README of this repository. We can have

[GitHub] [apisix-helm-chart] tao12345666333 closed issue #448: DISCUSS: remove 0.12.x release and release new 0.13.x

2023-01-11 Thread GitBox
tao12345666333 closed issue #448: DISCUSS: remove 0.12.x release and release new 0.13.x URL: https://github.com/apache/apisix-helm-chart/issues/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #448: DISCUSS: remove 0.12.x release and release new 0.13.x

2023-01-11 Thread GitBox
tao12345666333 commented on issue #448: URL: https://github.com/apache/apisix-helm-chart/issues/448#issuecomment-1378654512 done I will close this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [apisix] gaoxingliang commented on issue #8647: bug: ElasticSearch logger not working with error Action/metadata line [1] contains an unknown parameter [_type]

2023-01-11 Thread GitBox
gaoxingliang commented on issue #8647: URL: https://github.com/apache/apisix/issues/8647#issuecomment-1378632322 > It is a break change introduced by es 8.0+ due to `removal of mapping types`. > > Ref: https://www.elastic.co/guide/en/elasticsearch/reference/8.0/release-highlights.htm

[GitHub] [apisix] gaoxingliang commented on issue #8655: bug: GRPC transcode can't work with protobuf.Struct

2023-01-11 Thread GitBox
gaoxingliang commented on issue #8655: URL: https://github.com/apache/apisix/issues/8655#issuecomment-1378616586 @kingluo I checked the page: https://github.com/starwing/lua-protobuf#type-mapping It seems not support struct. I created an issue to check how to workaround. https://githu

[GitHub] [apisix-docker] Thereyouare opened a new issue, #407: Service Temporarily Unavailable

2023-01-11 Thread GitBox
Thereyouare opened a new issue, #407: URL: https://github.com/apache/apisix-docker/issues/407 i have a problem.i have a local app that works.but after i deployed it on linux i had problems with 503. the local system is win10,the docker version is 20.10.21, the linux system's docker ve

[GitHub] [apisix] vtychx commented on issue #8529: help request: in apisix etcd failed to parse domain

2023-01-11 Thread GitBox
vtychx commented on issue #8529: URL: https://github.com/apache/apisix/issues/8529#issuecomment-1378586407 @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [apisix] vtychx commented on issue #8529: help request: in apisix etcd failed to parse domain

2023-01-11 Thread GitBox
vtychx commented on issue #8529: URL: https://github.com/apache/apisix/issues/8529#issuecomment-1378583885 https://user-images.githubusercontent.com/60866246/211786738-ac52039b-f371-4d06-b77f-ceaa04f894e5.png";> DNS server works fine.I found the problem is function _deepcopy(). table or

[GitHub] [apisix] cloorc commented on issue #8648: bug: attempt to index local 'item' (a boolean value)

2023-01-11 Thread GitBox
cloorc commented on issue #8648: URL: https://github.com/apache/apisix/issues/8648#issuecomment-1378479485 > @cloorc Did you see any error log entries before these kinds of errors? I think this error is not the "primary crime scene". Also, is it possible to print the data in your ETCD?

[GitHub] [apisix-ingress-controller] AlinsRan commented on pull request #1586: feat: ApisixGlobalRule support global rules

2023-01-11 Thread GitBox
AlinsRan commented on PR #1586: URL: https://github.com/apache/apisix-ingress-controller/pull/1586#issuecomment-1378475217 > Code overall LGTM > > one question, how to deal with conflicts between ApisixGlobalRule and ApisixClusterConfig? There are two conflicts: 1. Construc

[GitHub] [apisix] kingluo commented on issue #8655: bug: GRPC transcode can't work with protobuf.Struct

2023-01-11 Thread GitBox
kingluo commented on issue #8655: URL: https://github.com/apache/apisix/issues/8655#issuecomment-1378460282 @gaoxingliang It seems that there is bug for [lua-protobuf](https://github.com/starwing/lua-protobuf) (used by APISIX) to import file in proto file. When I copy all definitions

[GitHub] [apisix-dashboard] SkyeYoung commented on issue #2576: "Invalid plugin data" when disable plugin

2023-01-11 Thread GitBox
SkyeYoung commented on issue #2576: URL: https://github.com/apache/apisix-dashboard/issues/2576#issuecomment-1378441399 Emmm, which version? (It seems a little late 😅 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] tokers commented on issue #8653: bug: encrypt_conf(): failed to get schema for plugin: proxy-rewrite

2023-01-11 Thread GitBox
tokers commented on issue #8653: URL: https://github.com/apache/apisix/issues/8653#issuecomment-1378437278 @MarkCupitt First of all, this error message is harmless. It occurs since you don't enable the `apisix.data_encryption.enable` in your `config.yaml`. On the other hand, we don't

[GitHub] [apisix] Fabriceli commented on issue #8654: help request: apisix dashboard grafana不能选择节点

2023-01-11 Thread GitBox
Fabriceli commented on issue #8654: URL: https://github.com/apache/apisix/issues/8654#issuecomment-1378431295 Make sure you have enable Prometheus plugin in global: ![image](https://user-images.githubusercontent.com/13508022/211763343-830d2ae4-304d-40ef-8e7e-2642fa427619.png) -- Th

[GitHub] [apisix] tokers commented on issue #8529: help request: in apisix etcd failed to parse domain

2023-01-11 Thread GitBox
tokers commented on issue #8529: URL: https://github.com/apache/apisix/issues/8529#issuecomment-1378424562 This is a known issue, we're still trying to troubleshoot it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [apisix] ependi-buzz commented on issue #8529: help request: in apisix etcd failed to parse domain

2023-01-11 Thread GitBox
ependi-buzz commented on issue #8529: URL: https://github.com/apache/apisix/issues/8529#issuecomment-1378412216 use ip is ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix-dashboard] swtseaman closed issue #2703: 如何添加自定义插件

2023-01-11 Thread GitBox
swtseaman closed issue #2703: 如何添加自定义插件 URL: https://github.com/apache/apisix-dashboard/issues/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix] shreemaan-abhishek commented on issue #8424: Unified apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-11 Thread GitBox
shreemaan-abhishek commented on issue #8424: URL: https://github.com/apache/apisix/issues/8424#issuecomment-1378379967 To be noted: `apisix/admin/kms.lua` has been renamed to s`apisix/admin/secrets.lua`. Ref: PR #8448 -- This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1589: feat: add openid connect auth

2023-01-10 Thread GitBox
tao12345666333 commented on code in PR #1589: URL: https://github.com/apache/apisix-ingress-controller/pull/1589#discussion_r1066656855 ## pkg/kube/apisix/apis/config/v2beta3/types.go: ## @@ -338,11 +338,12 @@ type ApisixConsumerSpec struct { } type ApisixConsumerAuthParame

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1589: feat: add openid connect auth

2023-01-10 Thread GitBox
tao12345666333 commented on PR #1589: URL: https://github.com/apache/apisix-ingress-controller/pull/1589#issuecomment-1378344601 And please check the e2e job errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1596: docs: add note about enabling the Plugin

2023-01-10 Thread GitBox
tao12345666333 commented on code in PR #1596: URL: https://github.com/apache/apisix-ingress-controller/pull/1596#discussion_r1066655829 ## docs/en/latest/concepts/apisix_route.md: ## @@ -178,6 +178,12 @@ spec: APISIX's [80+ Plugins](https://apisix.apache.org/docs/apisix/plu

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1597: docs: add documentation for using APISIX Ingress with Gateway API

2023-01-10 Thread GitBox
tao12345666333 commented on issue #1597: URL: https://github.com/apache/apisix-ingress-controller/issues/1597#issuecomment-1378339930 Thanks. SGTM We also need to mention that APISIX Ingress' support for Gateway API is not yet stable and is currently in the beta stage.

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1588: add ldap-auth authorization method

2023-01-10 Thread GitBox
tao12345666333 commented on PR #1588: URL: https://github.com/apache/apisix-ingress-controller/pull/1588#issuecomment-1378338226 @AlinsRan @lingsamuel PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

<    1   2   3   4   5   6   7   8   9   10   >