[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #200: Error: etcd get failed: context deadline exceeded

2021-12-22 Thread GitBox
tao12345666333 commented on issue #200: URL: https://github.com/apache/apisix-helm-chart/issues/200#issuecomment-999404782 what's your install commands? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix] tokers commented on issue #5877: request help: Plugin mount

2021-12-22 Thread GitBox
tokers commented on issue #5877: URL: https://github.com/apache/apisix/issues/5877#issuecomment-999408267 > For simple request/response is not feasible, I don’t quite understand, can you give me an example, thank you. Please read the https://apisix.apache.org/docs/apisix/architectur

[GitHub] [apisix] tzssangglass opened a new pull request #5886: chore: remove incorrect item type of include req/resp body expr

2021-12-22 Thread GitBox
tzssangglass opened a new pull request #5886: URL: https://github.com/apache/apisix/pull/5886 Signed-off-by: tzssangglass ### What this PR does / why we need it: ### Pre-submission checklist: * [x Did you explain what problem does this PR solve? Or what

[GitHub] [apisix] tokers commented on issue #5878: request help: how to add nodes in upstreams

2021-12-22 Thread GitBox
tokers commented on issue #5878: URL: https://github.com/apache/apisix/issues/5878#issuecomment-999409799 @hushaojun-0801 The error log is self-documented, you should add the `type` field. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] zaunist commented on pull request #2261: feat(route): remove key-auth plugin tip

2021-12-22 Thread GitBox
zaunist commented on pull request #2261: URL: https://github.com/apache/apisix-dashboard/pull/2261#issuecomment-999410165 ![image](https://user-images.githubusercontent.com/38528079/147064113-01c54d11-6078-487b-aba5-21d3212a1fc4.png) -- This is an automated message from the Apache Gi

[GitHub] [apisix] tzssangglass commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
tzssangglass commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-999414574 > but the port of grpc is registered in the metadata, can we specify that the registered http port in the metadata? -- This is an automated message from the Apache Git Se

[GitHub] [apisix] spacewander merged pull request #5880: chore(deps): bump actions/setup-go from 2.1.4 to 2.1.5

2021-12-22 Thread GitBox
spacewander merged pull request #5880: URL: https://github.com/apache/apisix/pull/5880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] Ilqjx commented on issue #5877: request help: Plugin mount

2021-12-22 Thread GitBox
Ilqjx commented on issue #5877: URL: https://github.com/apache/apisix/issues/5877#issuecomment-999419255 Does that mean that most of the plugins use simple request/response to solve the problem, but for some plugins, such as permission control plugins, they need to be inserted at the speci

[GitHub] [apisix] hushaojun-0801 commented on issue #5878: request help: how to add nodes in upstreams

2021-12-22 Thread GitBox
hushaojun-0801 commented on issue #5878: URL: https://github.com/apache/apisix/issues/5878#issuecomment-999420250 srroy,i use 1.2 version not 2.11,i will update now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [apisix] vcqr commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
vcqr commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-999422452 > No, The default method is used when registering -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] hushaojun-0801 closed issue #5878: request help: how to add nodes in upstreams

2021-12-22 Thread GitBox
hushaojun-0801 closed issue #5878: URL: https://github.com/apache/apisix/issues/5878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [apisix-dashboard] github-actions[bot] closed pull request #2139: ci: Cancel pushing image to azure cloud

2021-12-22 Thread GitBox
github-actions[bot] closed pull request #2139: URL: https://github.com/apache/apisix-dashboard/pull/2139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [apisix-dashboard] github-actions[bot] commented on pull request #2139: ci: Cancel pushing image to azure cloud

2021-12-22 Thread GitBox
github-actions[bot] commented on pull request #2139: URL: https://github.com/apache/apisix-dashboard/pull/2139#issuecomment-999447307 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR

[GitHub] [apisix] tzssangglass commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
tzssangglass commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-999447518 you can go to the nacos community and ask if there is a configuration for this -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [apisix-ingress-controller] stone2world commented on issue #769: bug: Unable to reconnect to apisix, when all ep are deleted under svc of apisix

2021-12-22 Thread GitBox
stone2world commented on issue #769: URL: https://github.com/apache/apisix-ingress-controller/issues/769#issuecomment-999454690 ![image](https://user-images.githubusercontent.com/43597843/147076070-06deddf9-5316-495b-8fb0-706a2b062b7c.png) ![image](https://user-images.githubusercontent

[GitHub] [apisix] vcqr commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
vcqr commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-999460064 It is okay to call between spring cloud and use nacos to do service discovery, but apisix is not compatible -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [apisix] danielkocot commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-22 Thread GitBox
danielkocot commented on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-999465979 Hi, sorry for the delay. I removed "remote_addr" but it still does not work 😞. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] w568590301 commented on issue #487: Who is using Apache APISIX?

2021-12-22 Thread GitBox
w568590301 commented on issue #487: URL: https://github.com/apache/apisix/issues/487#issuecomment-999467161 组织机构:明源云链 地点:中国深圳 联系人:liu...@mingyuanyun.com 场景:saas环境统一流量入口 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] gerry-vip commented on issue #5862: request help: ETCD cluster failed to start via Helm

2021-12-22 Thread GitBox
gerry-vip commented on issue #5862: URL: https://github.com/apache/apisix/issues/5862#issuecomment-999478364 @tao12345666333 Thank you for your reply. The issue above missed until I migrated my kubernetes cluster to Cloud ECS, so i doubt the issue occurred due to my local environment via V

[GitHub] [apisix] gerry-vip closed issue #5862: request help: ETCD cluster failed to start via Helm

2021-12-22 Thread GitBox
gerry-vip closed issue #5862: URL: https://github.com/apache/apisix/issues/5862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [apisix] danielkocot removed a comment on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-22 Thread GitBox
danielkocot removed a comment on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-999465979 Hi, sorry for the delay. I removed "remote_addr" but it still does not work 😞. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] danielkocot commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-22 Thread GitBox
danielkocot commented on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-999485955 Hi, sorry for the delay. It works now. But using docker on MacOS the upstream host needs the value `host.docker.internal`. -- This is an automated message from the Apache Gi

[GitHub] [apisix] danielkocot closed issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-22 Thread GitBox
danielkocot closed issue #5802: URL: https://github.com/apache/apisix/issues/5802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix-helm-chart] 0xgui commented on a change in pull request #199: feat: add networkpolicy to apisix helm chart

2021-12-22 Thread GitBox
0xgui commented on a change in pull request #199: URL: https://github.com/apache/apisix-helm-chart/pull/199#discussion_r773806251 ## File path: charts/apisix/templates/networkpolicy.yaml ## @@ -0,0 +1,77 @@ +{{- if .Values.apisix.networkPolicy.enabled }} +{{- $fullName := inclu

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-999516556 I meet a problem. ```sh 2021-12-22T17:18:11+08:00debug ingress/apisix_route.go:312 ApisixRoute add event arrived {"object": {"metadata":{"na

[GitHub] [apisix-ingress-controller] neverCase edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase edited a comment on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-999516556 I meet a problem. ```sh 2021-12-22T17:18:11+08:00debug ingress/apisix_route.go:312 ApisixRoute add event arrived {"object": {"metadat

[GitHub] [apisix] danielkocot opened a new pull request #5888: docs: added some explanations for the usage of the mqtt proxy

2021-12-22 Thread GitBox
danielkocot opened a new pull request #5888: URL: https://github.com/apache/apisix/pull/5888 added some explanations for the usage of the mqtt proxy and removed the remote_addr key from the json example configuration ### What this PR does / why we need it: The PR is needed to make

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2250: feat(route): add append query string to redirect

2021-12-22 Thread GitBox
bzp2010 commented on a change in pull request #2250: URL: https://github.com/apache/apisix-dashboard/pull/2250#discussion_r773830713 ## File path: web/src/pages/Route/components/Step1/MetaView.tsx ## @@ -370,7 +385,7 @@ const MetaView: React.FC = ({ Review comment:

[GitHub] [apisix] tzssangglass commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
tzssangglass commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-999528028 APISIX now supports Nacos 1.x and the CI is based on Nacos 1.4.1, are you using Nacos 2.x? -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [apisix] vcqr commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
vcqr commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-999534912 2.x yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [apisix] spacewander commented on issue #5858: bug: Using proxy-rewrite to overwrite the request header x-forwarded-proto failed

2021-12-22 Thread GitBox
spacewander commented on issue #5858: URL: https://github.com/apache/apisix/issues/5858#issuecomment-999559563 The test can pass in CI & my machine. I also set up an environment and test for it, the proxy-rewrite plugin can change X-Forwarded-Proto from HTTPS to HTTP. -- This is an au

[GitHub] [apisix] spacewander commented on a change in pull request #5888: docs: added some explanations for the usage of the mqtt proxy

2021-12-22 Thread GitBox
spacewander commented on a change in pull request #5888: URL: https://github.com/apache/apisix/pull/5888#discussion_r773875519 ## File path: docs/en/latest/plugins/mqtt-proxy.md ## @@ -23,10 +23,11 @@ title: mqtt-proxy ## Summary -- [**Name**](#name) -- [**Attributes**](#a

[GitHub] [apisix] juzhiyuan commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-22 Thread GitBox
juzhiyuan commented on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-999599231 Glad to know your issue is resolved, if docs need to be updated, kindly submit a PR 😄 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] spacewander opened a new pull request #5889: test: make t/plugin/serverless.t stable

2021-12-22 Thread GitBox
spacewander opened a new pull request #5889: URL: https://github.com/apache/apisix/pull/5889 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what n

[GitHub] [apisix] zuiyangqingzhou opened a new pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-22 Thread GitBox
zuiyangqingzhou opened a new pull request #5890: URL: https://github.com/apache/apisix/pull/5890 In some scenarios, if you modify the origin using proxy_rewrite plugin, the cors will not be handled correctly ### What this PR does / why we need it: ### Pre-submissio

[GitHub] [apisix-dashboard] 1502shivam-singh commented on a change in pull request #2250: feat(route): add append query string to redirect

2021-12-22 Thread GitBox
1502shivam-singh commented on a change in pull request #2250: URL: https://github.com/apache/apisix-dashboard/pull/2250#discussion_r773997152 ## File path: web/src/pages/Route/components/Step1/MetaView.tsx ## @@ -370,7 +385,7 @@ const MetaView: React.FC = ({ Review com

[GitHub] [apisix-dashboard] zaunist commented on a change in pull request #2250: feat(route): add append query string to redirect

2021-12-22 Thread GitBox
zaunist commented on a change in pull request #2250: URL: https://github.com/apache/apisix-dashboard/pull/2250#discussion_r774060547 ## File path: web/src/pages/Route/components/Step1/MetaView.tsx ## @@ -370,7 +385,7 @@ const MetaView: React.FC = ({ Review comment:

[GitHub] [apisix] spacewander commented on a change in pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-22 Thread GitBox
spacewander commented on a change in pull request #5890: URL: https://github.com/apache/apisix/pull/5890#discussion_r774258023 ## File path: apisix/plugins/cors.lua ## @@ -227,14 +227,15 @@ end function _M.rewrite(conf, ctx) +ctx["raw-request-origin"] = core.request.he

[GitHub] [apisix] tzssangglass commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
tzssangglass commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-79326 we need to support nacos 2.x, @vcqr would like to submit a PR to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] tokers commented on a change in pull request #5886: fix(logger): remove incorrect item type of include req/resp body expr

2021-12-22 Thread GitBox
tokers commented on a change in pull request #5886: URL: https://github.com/apache/apisix/pull/5886#discussion_r774265018 ## File path: t/plugin/kafka-logger2.t ## @@ -609,3 +609,35 @@ hello world --- no_error_log eval qr/send data to kafka: \{.*"body":"hello world\\n"/ ---

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #100: refactor: switch from reactor-netty to netty, and support fetching var and body

2021-12-22 Thread GitBox
tzssangglass commented on pull request #100: URL: https://github.com/apache/apisix-java-plugin-runner/pull/100#issuecomment-81878 @dmsolr @nic-6443 @nic-chen is ready for review, PLAT. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander commented on a change in pull request #5874: feat: support send APISIX data to assist decision in OPA plugin

2021-12-22 Thread GitBox
spacewander commented on a change in pull request #5874: URL: https://github.com/apache/apisix/pull/5874#discussion_r774262884 ## File path: ci/pod/docker-compose.yml ## @@ -402,11 +402,14 @@ services: restart: unless-stopped ports: - 8181:8181 -command: ru

[GitHub] [apisix] lizhouyang commented on issue #5834: request help: how to set redirect_uri, when i use openid-connect

2021-12-22 Thread GitBox
lizhouyang commented on issue #5834: URL: https://github.com/apache/apisix/issues/5834#issuecomment-83421 thanks,i think about it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [apisix] lizhouyang closed issue #5834: request help: how to set redirect_uri, when i use openid-connect

2021-12-22 Thread GitBox
lizhouyang closed issue #5834: URL: https://github.com/apache/apisix/issues/5834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [apisix] zuiyangqingzhou commented on a change in pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-22 Thread GitBox
zuiyangqingzhou commented on a change in pull request #5890: URL: https://github.com/apache/apisix/pull/5890#discussion_r774268868 ## File path: apisix/plugins/cors.lua ## @@ -227,14 +227,15 @@ end function _M.rewrite(conf, ctx) +ctx["raw-request-origin"] = core.reques

[GitHub] [apisix] zuiyangqingzhou commented on pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-22 Thread GitBox
zuiyangqingzhou commented on pull request #5890: URL: https://github.com/apache/apisix/pull/5890#issuecomment-86460 > > It seems that all other CORS-related headers also suffer from this change. Sorry, I don't quite understand what you mean, can you list some cases

[GitHub] [apisix] tokers commented on pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-22 Thread GitBox
tokers commented on pull request #5890: URL: https://github.com/apache/apisix/pull/5890#issuecomment-90147 > Headers like `Access-Control-Expose-Methods`, `Access-Control-Max-Age` will also be modified by `proxy-rewrite` plugin, -- This is an automated message from the Apache

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #199: feat: add networkpolicy to apisix helm chart

2021-12-22 Thread GitBox
tokers commented on a change in pull request #199: URL: https://github.com/apache/apisix-helm-chart/pull/199#discussion_r774273764 ## File path: charts/apisix/templates/networkpolicy.yaml ## @@ -0,0 +1,77 @@ +{{- if .Values.apisix.networkPolicy.enabled }} +{{- $fullName := incl

[GitHub] [apisix] zuiyangqingzhou commented on pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-22 Thread GitBox
zuiyangqingzhou commented on pull request #5890: URL: https://github.com/apache/apisix/pull/5890#issuecomment-96496 > > > > Headers like `Access-Control-Expose-Methods`, `Access-Control-Max-Age` will also be modified by `proxy-rewrite` plugin, But `proxy-rewrite` plugin w

[GitHub] [apisix] spacewander commented on a change in pull request #5727: feat: add CSRF plugin

2021-12-22 Thread GitBox
spacewander commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r774270754 ## File path: apisix/plugins/csrf.lua ## @@ -0,0 +1,168 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor l

[GitHub] [apisix] vcqr commented on issue #5815: bug: using nacos for service discovery, no support for spring cloud programs?

2021-12-22 Thread GitBox
vcqr commented on issue #5815: URL: https://github.com/apache/apisix/issues/5815#issuecomment-101288 > we need to support nacos 2.x, @vcqr would like to submit a PR to fix this? @tzssangglass ok -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-101428 ping @tao12345666333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
tao12345666333 commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-113722 let me take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
tao12345666333 commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-115846 @neverCase you can check these steps https://github.com/apache/apisix-ingress-controller/blob/eff92e084dd8794dc10091380aa7cdbcf707c5dd/pkg/ingress/manif

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-116439 > @neverCase you can check these steps > > https://github.com/apache/apisix-ingress-controller/blob/eff92e084dd8794dc10091380aa7cdbcf707c5dd/pkg/ingres

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
tao12345666333 commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-116507 Move L282-L286 to the front of L272. Also, please check other locations in this file at the same time to ensure that the order of execution is as

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-117205 > Move L282-L286 to the front of L272. > > Also, please check other locations in this file at the same time to ensure that the order of execution is as

[GitHub] [apisix] Baoyuantop commented on a change in pull request #5727: feat: add CSRF plugin

2021-12-22 Thread GitBox
Baoyuantop commented on a change in pull request #5727: URL: https://github.com/apache/apisix/pull/5727#discussion_r774296400 ## File path: apisix/plugins/csrf.lua ## @@ -0,0 +1,168 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor li

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
tao12345666333 commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-118774 > I could fix it at the same time. Great! It looks like this is a bug, can you submit a separate PR? Or use a separate commit for the fi

[GitHub] [apisix] xianshun163 commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-22 Thread GitBox
xianshun163 commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-119097 about deploy the nacos: 1、I get tar package from :https://github.com/alibaba/nacos/releases/tag/2.0.1 2、untar the package and goto the bin dir, and run : sh startup.s

[GitHub] [apisix-ingress-controller] neverCase commented on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase commented on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-119172 > > I could fix it at the same time. > > Great! > > It looks like this is a bug, can you submit a separate PR? Or use a separate commit for the

[GitHub] [apisix-ingress-controller] neverCase edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase edited a comment on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-117205 > Move L282-L286 to the front of L272. > > Also, please check other locations in this file at the same time to ensure that the order of executio

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
codecov-commenter edited a comment on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-997183430 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/791?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

[GitHub] [apisix-website] yzeng25 opened a new pull request #820: docs: update Google Cloud Logging doc

2021-12-22 Thread GitBox
yzeng25 opened a new pull request #820: URL: https://github.com/apache/apisix-website/pull/820 Changes: 1. Added links to various plugins 2. Modified translation and typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-website] netlify[bot] commented on pull request #820: docs: update Google Cloud Logging doc

2021-12-22 Thread GitBox
netlify[bot] commented on pull request #820: URL: https://github.com/apache/apisix-website/pull/820#issuecomment-123730 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: cd05c03bbc4f3d7e2bc5661649661e0081f3587b 🔍 Inspect the deploy log: [ht

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #820: docs: update Google Cloud Logging doc

2021-12-22 Thread GitBox
netlify[bot] edited a comment on pull request #820: URL: https://github.com/apache/apisix-website/pull/820#issuecomment-123730 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: cd05c03bbc4f3d7e2bc5661649661e0081f3587b 🔍 Inspect the deploy log:

[GitHub] [apisix] zhouyu0914k opened a new issue #5893: request help: 如何将收到的tcp数据同时转发到多个tcp后端(类似广播,不是负载均衡)

2021-12-22 Thread GitBox
zhouyu0914k opened a new issue #5893: URL: https://github.com/apache/apisix/issues/5893 ### Issue description 只需要转发,不需要处理后端响应。http可以通过 proxy-mirror 实现,tcp的动态代理可以用stream_routes实现,但是不知道如何实现将收到的数据同时转发给多个后端 ### Environment - apisix version (cmd: `apisix version`): 2.11.0

[GitHub] [apisix-python-plugin-runner] membphis commented on issue #37: How can i get request body from this plugin ?

2021-12-22 Thread GitBox
membphis commented on issue #37: URL: https://github.com/apache/apisix-python-plugin-runner/issues/37#issuecomment-172325 ping @shuaijinchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #5893: request help: 如何将收到的tcp数据同时转发到多个tcp后端(类似广播,不是负载均衡)

2021-12-22 Thread GitBox
spacewander commented on issue #5893: URL: https://github.com/apache/apisix/issues/5893#issuecomment-174876 You can write a plugin for it. In this plugin, you can use `ngx.req.socket()` to read the data of client, and forward to multiple backend via `ngx.socket.tcp`. See https://github

[GitHub] [apisix] zhouyu0914k commented on issue #5893: request help: 如何将收到的tcp数据同时转发到多个tcp后端(类似广播,不是负载均衡)

2021-12-22 Thread GitBox
zhouyu0914k commented on issue #5893: URL: https://github.com/apache/apisix/issues/5893#issuecomment-179516 你好,我尝试过在openresty里使用lua脚本实现该功能,遇到了很多问题,我们apisix有交流群吗,我去群里问问 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [apisix-ingress-controller] neverCase edited a comment on pull request #791: feat: add ApisixPluginConfig translator (#638)

2021-12-22 Thread GitBox
neverCase edited a comment on pull request #791: URL: https://github.com/apache/apisix-ingress-controller/pull/791#issuecomment-119172 > > I could fix it at the same time. > > Great! > > It looks like this is a bug, can you submit a separate PR? Or use a separate commit f

[GitHub] [apisix] vcqr opened a new pull request #5894: fix:#5815 upstream support nacos2.xx

2021-12-22 Thread GitBox
vcqr opened a new pull request #5894: URL: https://github.com/apache/apisix/pull/5894 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Hav

[GitHub] [apisix-website] Baoyuantop opened a new pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
Baoyuantop opened a new pull request #821: URL: https://github.com/apache/apisix-website/pull/821 Changes: - remove datadog beta label - add google-cloud-logger plugin Screenshots of the change: ![image](https://user-images.githubusercontent.com/30611190/147199489-e0fb13

[GitHub] [apisix-website] netlify[bot] commented on pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
netlify[bot] commented on pull request #821: URL: https://github.com/apache/apisix-website/pull/821#issuecomment-181422 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: cf4a92b201e477125bd2376fd50cc103698e9cb8 🔍 Inspect the deploy log: [ht

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
netlify[bot] edited a comment on pull request #821: URL: https://github.com/apache/apisix-website/pull/821#issuecomment-181422 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: cf4a92b201e477125bd2376fd50cc103698e9cb8 🔍 Inspect the deploy log:

[GitHub] [apisix] spacewander merged pull request #5867: change: enable HTTP when stream proxy is set and enable_admin is true

2021-12-22 Thread GitBox
spacewander merged pull request #5867: URL: https://github.com/apache/apisix/pull/5867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] spacewander merged pull request #5889: test: make t/plugin/serverless.t stable

2021-12-22 Thread GitBox
spacewander merged pull request #5889: URL: https://github.com/apache/apisix/pull/5889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] spacewander merged pull request #5869: chore(google-cloud-logging): use batch queue default parameters

2021-12-22 Thread GitBox
spacewander merged pull request #5869: URL: https://github.com/apache/apisix/pull/5869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix-website] yzeng25 commented on a change in pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
yzeng25 commented on a change in pull request #821: URL: https://github.com/apache/apisix-website/pull/821#discussion_r774363684 ## File path: website/static/data/plugins.json ## @@ -148,7 +148,11 @@ }, { "name": "datadog", -"description": "Datado

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
netlify[bot] edited a comment on pull request #821: URL: https://github.com/apache/apisix-website/pull/821#issuecomment-181422 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 8853ef7b3cb99ec32f2b74af2958809e741532c9 🔍 Inspect the deploy lo

[GitHub] [apisix-website] Baoyuantop commented on a change in pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
Baoyuantop commented on a change in pull request #821: URL: https://github.com/apache/apisix-website/pull/821#discussion_r774364661 ## File path: website/static/data/plugins.json ## @@ -148,7 +148,11 @@ }, { "name": "datadog", -"description": "Dat

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
netlify[bot] edited a comment on pull request #821: URL: https://github.com/apache/apisix-website/pull/821#issuecomment-181422 ❌ Deploy Preview for *apache-apisix* failed. 🔨 Explore the source changes: 8853ef7b3cb99ec32f2b74af2958809e741532c9 🔍 Inspect the deploy log:

[GitHub] [apisix-dashboard] nimohunter commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0

2021-12-22 Thread GitBox
nimohunter commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-194024 > > Of course that we may miss some route's parameter. > > And we could make sure all parameters that Apache APISIX needs are kept? 😄 I found the swagger.ya

[GitHub] [apisix] tzssangglass commented on a change in pull request #5881: feat(limit-count): allow sharing counter

2021-12-22 Thread GitBox
tzssangglass commented on a change in pull request #5881: URL: https://github.com/apache/apisix/pull/5881#discussion_r774361920 ## File path: t/plugin/limit-count2.t ## @@ -480,11 +448,240 @@ passed ngx.say(json.encode(ress)) } } request -GET /t

[GitHub] [apisix] arabot777 opened a new pull request #5897: Discussions no5833

2021-12-22 Thread GitBox
arabot777 opened a new pull request #5897: URL: https://github.com/apache/apisix/pull/5897 ### What this PR does / why we need it: Add degradation switch for ext-plugin. https://github.com/apache/apisix/discussions/5833 ### Pre-submission checklist: * [x] Did

[GitHub] [apisix] tzssangglass commented on issue #5767: bug: nacos.lua make some duplicate instance

2021-12-22 Thread GitBox
tzssangglass commented on issue #5767: URL: https://github.com/apache/apisix/issues/5767#issuecomment-199551 can you try with nacos 1.4.x , recently we found that the nacos 2.x version is not supported enough. releated to: https://github.com/apache/apisix/pull/5894 -- This is

[GitHub] [apisix] shuaijinchao opened a new issue #5898: proposal: support grpc-web proxy

2021-12-22 Thread GitBox
shuaijinchao opened a new issue #5898: URL: https://github.com/apache/apisix/issues/5898 ### Issue description `gRPC` was originally developed by Google and is a high-performance remote procedure call framework based on `HTTP/2` implementation. But because the browser does not direc

[GitHub] [apisix-docker] ChinaSilence commented on issue #101: Dockerhub support for Dashboard

2021-12-22 Thread GitBox
ChinaSilence commented on issue #101: URL: https://github.com/apache/apisix-docker/issues/101#issuecomment-1000103188 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #2246: [openapi upload error] kin-openapi lastest version is 0.86.0, and our go.mod version is 0.32.0

2021-12-22 Thread GitBox
juzhiyuan commented on issue #2246: URL: https://github.com/apache/apisix-dashboard/issues/2246#issuecomment-1000103519 > Hi @nimohunter, could we schedule a meeting if possible? My WeChat is **JuShaoyao** -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [apisix-dashboard] bzp2010 commented on a change in pull request #2250: feat(route): add append query string to redirect

2021-12-22 Thread GitBox
bzp2010 commented on a change in pull request #2250: URL: https://github.com/apache/apisix-dashboard/pull/2250#discussion_r774375937 ## File path: web/src/pages/Route/components/Step1/MetaView.tsx ## @@ -370,7 +385,7 @@ const MetaView: React.FC = ({ Review comment:

[GitHub] [apisix] tzssangglass commented on a change in pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-22 Thread GitBox
tzssangglass commented on a change in pull request #5890: URL: https://github.com/apache/apisix/pull/5890#discussion_r774377148 ## File path: t/plugin/cors.t ## @@ -927,3 +927,70 @@ Access-Control-Max-Age: Access-Control-Allow-Credentials: --- no_error_log [error] + + + +===

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
netlify[bot] edited a comment on pull request #821: URL: https://github.com/apache/apisix-website/pull/821#issuecomment-181422 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 25561fe6dded33f3550b7a42e8c3ecb386989f59 🔍 Inspect the deploy lo

[GitHub] [apisix] juzhiyuan commented on issue #5893: request help: 如何将收到的tcp数据同时转发到多个tcp后端(类似广播,不是负载均衡)

2021-12-22 Thread GitBox
juzhiyuan commented on issue #5893: URL: https://github.com/apache/apisix/issues/5893#issuecomment-100094 > 你好,我尝试过在openresty里使用lua脚本实现该功能,遇到了很多问题,我们apisix有交流群吗,我去群里问问 Hi @zhouyu0914k, we have an unofficial Apache APISIX WeChat group, add my WeChat **JuShaoyao** and I could invit

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #821: feat: add google-cloud-logger plugin

2021-12-22 Thread GitBox
netlify[bot] edited a comment on pull request #821: URL: https://github.com/apache/apisix-website/pull/821#issuecomment-181422 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 25561fe6dded33f3550b7a42e8c3ecb386989f59 🔍 Inspect the deploy log:

[GitHub] [apisix] Ilqjx commented on issue #5877: request help: Plugin mount

2021-12-23 Thread GitBox
Ilqjx commented on issue #5877: URL: https://github.com/apache/apisix/issues/5877#issuecomment-1000115663 Why a simple request/response is not feasible for plugins written in Lua? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [apisix] zuiyangqingzhou commented on a change in pull request #5890: fix(cors): compatible with scenarios where origin is modified

2021-12-23 Thread GitBox
zuiyangqingzhou commented on a change in pull request #5890: URL: https://github.com/apache/apisix/pull/5890#discussion_r774403967 ## File path: t/plugin/cors.t ## @@ -927,3 +927,70 @@ Access-Control-Max-Age: Access-Control-Allow-Credentials: --- no_error_log [error] + + + +

[GitHub] [apisix] hwy1782 opened a new pull request #5899: docs: update mqtt-proxy.md example

2021-12-23 Thread GitBox
hwy1782 opened a new pull request #5899: URL: https://github.com/apache/apisix/pull/5899 ### What this PR does / why we need it: Fix wrong sample code in line 74 ~ 87 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or

[GitHub] [apisix-dashboard] nic-chen merged pull request #2258: feat: release 2.10.1

2021-12-23 Thread GitBox
nic-chen merged pull request #2258: URL: https://github.com/apache/apisix-dashboard/pull/2258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #2250: feat(route): add append query string to redirect

2021-12-23 Thread GitBox
LiteSun commented on a change in pull request #2250: URL: https://github.com/apache/apisix-dashboard/pull/2250#discussion_r774414467 ## File path: web/src/pages/Route/locales/en-US.ts ## @@ -64,13 +64,17 @@ export default { 'page.route.form.itemLabel.scheme': 'Scheme', 'p

[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #789: feat: Initial support for Gateway API

2021-12-23 Thread GitBox
codecov-commenter edited a comment on pull request #789: URL: https://github.com/apache/apisix-ingress-controller/pull/789#issuecomment-989003366 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/789?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme

<    2   3   4   5   6   7   8   9   10   11   >