Fabriceli commented on PR #8651:
URL: https://github.com/apache/apisix/pull/8651#issuecomment-1421772278
@spacewander Could you request another committer to do the code review for
this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Fabriceli commented on PR #8651:
URL: https://github.com/apache/apisix/pull/8651#issuecomment-1411819128
@tzssangglass could you have a look at this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Fabriceli commented on PR #8651:
URL: https://github.com/apache/apisix/pull/8651#issuecomment-1410044551
> > > [#8651
(comment)](https://github.com/apache/apisix/pull/8651#discussion_r1073064191)
It seems there are still indentation issues. Some places use 8-spaces
indentation instead of 4
Fabriceli commented on PR #8651:
URL: https://github.com/apache/apisix/pull/8651#issuecomment-1408104104
> [#8651
(comment)](https://github.com/apache/apisix/pull/8651#discussion_r1073064191)
It seems there are still indentation issues. Some places use 8-spaces
indentation instead of 4.
Fabriceli commented on PR #8651:
URL: https://github.com/apache/apisix/pull/8651#issuecomment-1397953655
@spacewander Please take a look at this PR, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
