Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1464727518
> I don't know much about this mechanism about events,I dare not move that
piece of code. I'm afraid to fix more bugs.
>
> Can you join and help finish the work together.
I
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1451879256
It can create TWO event to watch the services and update the `all_services`:
```mermaid
flowchart TD
subgraph Event1: watch catalog
A[Start] --> c
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1449632031
> > >
> >
> >
> > we need create some tests for these cases
>
> I am not sure the resty_consul:new code how block two query API, if one
block and wait, how another exec
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1449148547
>
we need create some tests for these cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447644723
Before push the code, you can run `make lint` and `make license-check` in
local to check the code and doc whether fit the code style
--
This is an automated message from the Apache Git
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447637005
please check it (**timeout** arg) in
[lua-resty-consul](https://github.com/hamishforbes/lua-resty-consul), we use
this lib to get infos from Consul
--
This is an automated message fro
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1446115373
cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445819466
> @Fabriceli
>
> I encountered difficulties.
>
> I notice the test ci use docker-compose start consul_1 8500 and consul_2
8600 and then they can not access `http://127.0.0.1
Fabriceli commented on PR #8928:
URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445532142
> @Fabriceli Help me see what is left unfinished? There are some ci failed.
Please fix the test cases, there are some test failed. Referenced infos
about how to run APISIX test:
