[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-26 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r531350211 ## File path: doc/README.md ## @@ -35,6 +35,7 @@ * [Changelog](../CHANGELOG.md) * [Benchmark](benchmark.md) * [Code Style](../CODE_STYLE.md) +* [Deb

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-26 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r531350105 ## File path: apisix/init.lua ## @@ -629,6 +630,24 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-26 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r531302745 ## File path: apisix/init.lua ## @@ -629,6 +630,24 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-26 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r531099546 ## File path: doc/debugging.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/debugging.md) Review comment: added. -

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-26 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r53106 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/upstream-status-5xx.md) + +## `5xx` response status code + +Similar

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530809166 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/upstream-status-5xx.md) + +## `5xx` response status code + +Similar

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530809012 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ +

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530808592 ## File path: doc/zh-cn/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ + + +[English](../upstream-status-5xx.md) + +## `5xx` 响应状态码 + +500、502、503等类似的 `5xx

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530808411 ## File path: apisix/init.lua ## @@ -629,6 +630,13 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530808291 ## File path: t/node/upstream-status-5xx.t ## @@ -0,0 +1,419 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530795262 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/upstream-status-5xx.md) + +## `5xx` response status code + +Similar

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530781876 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ + + +[Chinese](zh-cn/upstream-status-5xx.md) + +## `5xx` response status code + +Similar

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530778235 ## File path: doc/upstream-status-5xx.md ## @@ -0,0 +1,151 @@ +

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530777169 ## File path: apisix/init.lua ## @@ -629,6 +630,13 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530475471 ## File path: apisix/init.lua ## @@ -630,10 +630,11 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530465858 ## File path: apisix/init.lua ## @@ -630,10 +630,11 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-25 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530466136 ## File path: apisix/init.lua ## @@ -630,10 +630,11 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-24 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530093211 ## File path: apisix/init.lua ## @@ -630,10 +630,11 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-24 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r530091095 ## File path: apisix/init.lua ## @@ -630,10 +630,11 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529218125 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529131022 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r529126522 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528718641 ## File path: apisix/init.lua ## @@ -629,6 +630,14 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528708247 ## File path: apisix/init.lua ## @@ -630,7 +630,7 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-23 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528567641 ## File path: t/node/upstream-status-5xx.t ## @@ -0,0 +1,359 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528509391 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528440335 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528351108 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528346159 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528346058 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528345888 ## File path: t/node/upstream-status-5xx.t ## @@ -0,0 +1,165 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528345739 ## File path: t/lib/server.lua ## @@ -365,4 +365,8 @@ function _M.log() end +function _M.server_error() +error("500 Internal Server Error") +e

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2817: feat: How to distinguish whether the 5xx status code (eg 500) comes from upstream or apisix

2020-11-22 Thread GitBox
Firstsawyou commented on a change in pull request #2817: URL: https://github.com/apache/apisix/pull/2817#discussion_r528345712 ## File path: apisix/init.lua ## @@ -629,6 +630,12 @@ end function _M.http_header_filter_phase() core.response.set_header("Server", ver_header)