HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751153534
I really appreciate your explanation. Merry Christmas :candy:
But why don't we use lock before line 100 if it's serial created ?
-
HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751174034
Oh, I mean locking from line 100 to line 104. Sorry about the mistake.
```lua
local cache_obj = fetch_valid_cache(lru_obj, invalid_stale, item_ttl,
HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751306315
It's possible to create the object in function fetch_valid_cache in line 100.
```lua
local function fetch_valid_cache(lru_obj, invalid_stale, item_ttl,
HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751319250
I see. There is need to protect the cache when setting a stale object. In
this way, I also have two questions.
+ Why do we lock the function execution of fetch_valid_cache in line
HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-751556350
OK, I will check that. Thanks for your help.
This is an automated message from the Apache Git Service.
To respond to
HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-757078345
Um?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-757078345
Um?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
HelloBug0 commented on issue #3112:
URL: https://github.com/apache/apisix/issues/3112#issuecomment-765838470
Sorry to replay this later and not make myself clearly.
Yeah, I'm willing to submit a PR, but before that, I want to spend more time
studying APISIX code which is I am doing now.
