[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3472: chore: fix 'make deps'

2021-02-02 Thread GitBox
Yiyiyimu commented on a change in pull request #3472: URL: https://github.com/apache/apisix/pull/3472#discussion_r568295463 ## File path: Makefile ## @@ -55,7 +55,9 @@ help: default .PHONY: deps deps: default ifeq ($(LUAROCKS_VER),luarocks 3.) +ifeq ("$(wildcard ~/.luarocks)

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3472: chore: fix 'make deps'

2021-02-01 Thread GitBox
Yiyiyimu commented on a change in pull request #3472: URL: https://github.com/apache/apisix/pull/3472#discussion_r568362869 ## File path: Makefile ## @@ -55,7 +55,9 @@ help: default .PHONY: deps deps: default ifeq ($(LUAROCKS_VER),luarocks 3.) +ifeq ("$(wildcard ~/.luarocks)

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3472: chore: fix 'make deps'

2021-02-01 Thread GitBox
Yiyiyimu commented on a change in pull request #3472: URL: https://github.com/apache/apisix/pull/3472#discussion_r568295463 ## File path: Makefile ## @@ -55,7 +55,9 @@ help: default .PHONY: deps deps: default ifeq ($(LUAROCKS_VER),luarocks 3.) +ifeq ("$(wildcard ~/.luarocks)

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3472: chore: fix 'make deps'

2021-02-01 Thread GitBox
Yiyiyimu commented on a change in pull request #3472: URL: https://github.com/apache/apisix/pull/3472#discussion_r567746883 ## File path: Makefile ## @@ -55,7 +55,9 @@ help: default .PHONY: deps deps: default ifeq ($(LUAROCKS_VER),luarocks 3.) +ifeq ("$(wildcard ~/.luarocks)

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3472: chore: fix 'make deps'

2021-02-01 Thread GitBox
Yiyiyimu commented on a change in pull request #3472: URL: https://github.com/apache/apisix/pull/3472#discussion_r567709218 ## File path: Makefile ## @@ -55,7 +55,9 @@ help: default .PHONY: deps deps: default ifeq ($(LUAROCKS_VER),luarocks 3.) +ifeq ("$(wildcard ~/.luarocks)