[GitHub] [apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

2020-09-16 Thread GitBox
Yiyiyimu commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-693425041 Close since #2036 is merged This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

2020-08-02 Thread GitBox
Yiyiyimu commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-667651381 > need to support etcd v3 in file : bin/apisix (init_etcd function) Thank you and your work! I have overlooked this part -

[GitHub] [apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

2020-08-01 Thread GitBox
Yiyiyimu commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-667543546 Some difference of v2/v3 being solved: -- | v2 | v3 -- | -- | -- `delete` key not exist | return 404 | return 200, but response body.deleted(num) would become nil

[GitHub] [apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

2020-08-01 Thread GitBox
Yiyiyimu commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-667541535 Feature implemented in this commit: - Change etcd version directly in config.yaml and core.lua would do the job to select etcd.lua and config_etcd.lua of a certain version. Th

[GitHub] [apisix] Yiyiyimu commented on pull request #1943: feature: support etcd v3

2020-07-31 Thread GitBox
Yiyiyimu commented on pull request #1943: URL: https://github.com/apache/apisix/pull/1943#issuecomment-667255004 > @Yiyiyimu etcd v3 support is an urgent need, we should hurry up and complete it as soon as possible. Sure I'll try to provide the minimum working PR ASAP -