Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-693536211
TODO: we need to add doc for etcd migration
This is an automated message from the Apache Git Service.
To
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-693426643
> we could optimize it in another pr
@nic-chen I think we need to release a newer version of lua-resty-etcd,
since the current version would output TONS of logs.
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-69271
Currently the log produced by lua-resty-etcd would show message without
base64 decode. For example
```
2020/09/15 23:18:52 [info] 1964#1964: *2 [lua] v3.lua:284: set(): v3
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-692553222
> > one more thing, we need to check the `etcd` version in `bin/apisix`,
confirm the `etcd` version `>= 3.4` .
>
> we can fix this in a new PR, here is the related issue:
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-689952623
The newly imported lib [base64](https://github.com/iskolbin/lbase64) holds
MIT License and only 200 lines. So I think we could directly use it.
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-688697918
> I added this PR to 2.0 milestone, which due by September 18, 2020
Sure.
It just I need some help in the current problem, which discussed in
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-686846176
Hi @membphis I noticed there are still errrors in your latest commit like
https://github.com/apache/apisix/runs/1046997001#step:6:423, but since there is
no `no_error_log` add
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680966931
@membphis it seems I could not reply to your comment on "etcd v2 version".
The original implementation should directly use the version detection in
lua-resty-etcd, but it is
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680923213
> No, apisix and etcd will not in the same machine.
If they are not on the same machine, could etcdctl installed on apisix's
machine connect to the other machine's etcd?
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-678654583
> I think we can merge this PR at next week.
That would be great!
One more question, which place in doc do you suggest to put the etcd
migration link? Like we
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-674549680
> Use v3 or v2 protocol, their test results should be the same. Because
`etcd` is incrementally notified, most requests are in the `wait` status.
Is there any reason that
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-672564838
**DEBUG HELP NEEDED!!**
Currently there is only one error in test file, which is the last test of
t/plugin/key-auth.t. Normally in etcd v2, it would add 20 consumers and
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-671945683
Currently implemented multi-version support (auto change etcd prefix) in
t/APISIX.pm, worked for most tests. But for test files like
t/admin/stream-routes-disable.t, which
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-671440970
It seems travis ci [passed in my personal
repo](https://travis-ci.com/github/Yiyiyimu/incubator-apisix/builds/179139937),
but github CI failed quite early. I'm a bit confused
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-671412054
TODO:
- [ ] currenly only test v3, **test for both v2 and v3**
- [ ] currently it only support etcd v2 and v3.3+, **do we need to support
other etcd version between these
Yiyiyimu commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-671401256
I make a default benchmark test on my local PC, it seems that deploying etcd
v3 could improve performance quite a lot
|| v3
16 matches
Mail list logo
