Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-692553222
> > one more thing, we need to check the `etcd` version in `bin/apisix`,
confirm the `etcd` version `>= 3.4` .
>
> we can fix this in a new PR, here is the related
Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-689952623
The newly imported lib [base64](https://github.com/iskolbin/lbase64) is used
in `init_etcd` step to encode k/v send to etcd. Lib `base64` holds MIT License
and only 200
Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680966931
@membphis it seems I could not directly reply in your comment on "etcd v2
version".
The original implementation should directly use the version detection in
Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-671412054
TODO:
- [x] currenly only test v3, **test for both v2 and v3**
- [x] currently it only support etcd v2 and v3.3+, **do we need to support
other etcd version between
Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-672564838
Fixed by iterating through watch response.
---
~~DEBUG HELP NEEDED!!~~
Currently there is only one error in test file, which is the last test of
Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-672564838
Fixed by iterating through watch response.
---
**DEBUG HELP NEEDED!!**
Currently there is only one error in test file, which is the last test of
Yiyiyimu edited a comment on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-671440970
It seems travis ci [passed in my personal
repo](https://travis-ci.com/github/Yiyiyimu/incubator-apisix/builds/179139937),
but github CI failed quite early. I'm a bit
