[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r615710553 ## File path: apisix/discovery/nacos.lua ## @@ -182,47 +179,47 @@ local function get_base_uri() end -local function get_page_service(infos, base_uri,

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r615699700 ## File path: apisix/discovery/nacos.lua ## @@ -275,41 +273,33 @@ end function _M.nodes(service_name) -local logged = false Review comment:

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r615650797 ## File path: apisix/discovery/nacos.lua ## @@ -182,47 +179,47 @@ local function get_base_uri() end -local function get_page_service(infos, base_uri,

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r615648329 ## File path: apisix/discovery/nacos.lua ## @@ -275,41 +273,33 @@ end function _M.nodes(service_name) -local logged = false Review comment:

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r610686799 ## File path: .github/workflows/centos7-ci.yml ## @@ -101,6 +101,37 @@ jobs: docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r609647031 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,322 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r609451778 ## File path: .github/workflows/centos7-ci.yml ## @@ -101,6 +101,37 @@ jobs: docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r609449874 ## File path: .github/workflows/centos7-ci.yml ## @@ -101,6 +101,37 @@ jobs: docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r609321509 ## File path: t/discovery/nacos.t ## @@ -0,0 +1,152 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r609320898 ## File path: t/discovery/nacos.t ## @@ -0,0 +1,152 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r606044345 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,316 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r606044345 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,316 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r606029536 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,316 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r604157217 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603841571 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603799397 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603319995 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603156071 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,285 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r602668288 ## File path: .travis/linux_tengine_runner.sh ## @@ -40,6 +40,9 @@ before_install() { # start consul servers docker run --rm --name consul_1 -d

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r602649771 ## File path: .travis/linux_tengine_runner.sh ## @@ -40,6 +40,9 @@ before_install() { # start consul servers docker run --rm --name consul_1 -d

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r60254 ## File path: .travis/linux_tengine_runner.sh ## @@ -40,6 +40,9 @@ before_install() { # start consul servers docker run --rm --name consul_1 -d

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r599625682 ## File path: t/discovery/nacos.t ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r599636476 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,285 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r599625682 ## File path: t/discovery/nacos.t ## @@ -0,0 +1,125 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r597369333 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,237 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r597352555 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,237 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r597351976 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,237 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r597350777 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,237 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r597350658 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,237 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r596664303 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,237 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r596662744 ## File path: docs/en/latest/discovery/nacos.md ## @@ -0,0 +1,93 @@ +--- +title: nacos +--- + + + +### Configuration for Nacos + +Add following