dickens7 commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-691832972
> thx, it will be better if you can add test cases.
I'm sorry to be a little busy these few days, maybe a few days later
-
dickens7 commented on pull request #2193:
URL: https://github.com/apache/apisix/pull/2193#issuecomment-689441251
I think it’s not a good idea to remove the sample variable, I moved the
sample decision logic to create_tracer function. Keep upstream decided to
sample the request, we do too.
