[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-23 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1441645056 @spacewander @Fabriceli I have test the modify and PR, pls help check. now the consul healthy and apisix dump were updated almost at the same time. If there is still delay

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-23 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1441454380 > > > > Maybe you need to print more debug log OK, I config here, it is working, i will try continue test ```bash nginx_config: error_log_level: info ``` -

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-23 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1441429172 It seems not print log.info info in this init.lua file, how to open debug level? I try to config conf/debug.yaml ,it not working fot this -- This is an automated messa

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-22 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1441316215 More test here, there is a node from unhealthy to healthy, consul update at 15:35:09 and apisix update at 15:35:28. ```bash --->Thu Feb 23 15:35:08 CST 2023===nginx-1 fetch hea

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-22 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1441306635 In this way, I started to modify and found a problem When the node health changes from healthy to unhealthy, Consul will find the update faster, while Apisix will finish the updat

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-22 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1441029239 > Have to check whether the `/health/state/:state` API will be updated or not when any endpoint updated or added or deleted. `/health/state/any` meet expectations >state (s

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-22 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1441022773 OK, Let me modify this and submit a PR according to we discussed above. I will test it after modification. -- This is an automated message from the Apache Git Service.

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-22 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1439759023 Or mybey we can wath `/health/state/:state` , it seems a ONE request. I found some information

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-21 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1439574897 > > I lost here. > > `if consul_server.index ~= watch_result.headers['X-Consul-Index'] then` > > It also needs to be adjusted accordingly, becaus the health status is a dynamic val

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437990998 Indeed, there are some challenge for me. I tried to see the code there are consul_sub

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437772210 At this stage,apisix V3.1 (docker.io/apache/apisix:3.1.0-debian) release has another issues , and master have fix 8827. So I use de

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1437747330 I have some test here I prepare 4 instance nginx here: | ip | port | check

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-20 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1436769240 I have noticed that nacos discovery use the query parameter `healthyOnly=true` to filter unhealthy endpoints. But I haven't verified this, just from the perspective of code analys

[GitHub] [apisix] dyrnq commented on issue #8856: feat: As a user, I want to apisix support consul discovery with health API

2023-02-19 Thread via GitHub
dyrnq commented on issue #8856: URL: https://github.com/apache/apisix/issues/8856#issuecomment-1436231298 They are all consul discovery, Only the interface is slightly different. Consul has an agent ability to health check the endpoints that registered. health check is an optional for