[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1465583280 > > I don't know much about this mechanism about events,I dare not move that piece of code. I'm afraid to fix more bugs. > > Can you join and help finish the work together. > > I cr

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1451909513 I don't know much about this mechanism abhout events,I dare not move that piece of code. I'm afraid to fix more bugs. Can you join and help finish the work together. -- This is

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1451126669 Now I use commit code like below can pass test, that is give up pass index parameter to consul , do not use blocking query, it will work fine. Is there have a better way? ```ba

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1449678397 Yes, that lost keepalive usage. We need find a compatible mechanism to watch catalog/services AND health/state/any X-Consul-Index both, I found all of consul APIs, there has no

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1449153539 > > > > we need create some tests for these cases I am not sure the resty_consul:new code how block query two API, if one block and wait, how another exec? -- This

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1449139478 @Fabriceli After continuous testing, I found problems. If the consul register and deregister with no health check , then the v1/health/state/any will no change of X-Consul-Ind

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447792547 @Fabriceli Very strange question, the consul update have delay when consul service node changed when use **date && nerdctl stop ngin

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447649238 > please check it (**wait** arg) in [lua-resty-consul](https://github.com/hamishforbes/lua-resty-consul), we use this lib to get infos from Consul got it -- This is an automate

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447549444 @Fabriceli @spacewander I have fix , but there has a small discussion and uncertainty about a config of ```bash discovery: consul: timeout: wait: 60 ``` t

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1447458625 > Could you fix the CI: https://github.com/apache/apisix/actions/runs/4280301682/jobs/7470288647? I am in process of this. -- This is an automated message from the Apache Git Servic

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445900176 @Fabriceli I have unit test completed on my pc use flow test case, I have push the code. Please help checks. ```bash === TEST 16: prepare nodes with consul health check --- c

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445880188 Or maybe I can use A fake address that can be visited instead? ```bash \"Checks\": [{\"http\": \"http://baidu.com\"; ``` It can work -- This is an automated message fro

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445825627 > > @Fabriceli > > I encountered difficulties. > > I notice the test ci use docker-compose start consul_1 8500 and consul_2 8600 and then they can not access `http://127.0.0.1:30511` wh

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445795598 @Fabriceli I encountered difficulties. I notice the test ci use docker-compose start consul_1 8500 and consul_2 8600 and then they cant access `http://127.0.0.1:30511` which re

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445634595 > @Fabriceli there are some test use 8600 which is the first consul DNS port, it can not use to another consul instance(8500), i want to update it to 18500. I see there use docker-com

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445631179 @Fabriceli there are some test use 8600 which is the first consul DNS port, it can not use to another consul instance(8500), i want to update it to 18500. -- This is an automated message

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445540720 > > @Fabriceli Help me see what is left unfinished? There are some ci failed. > > Please fix the test cases, there are some test failed. Referenced infos about how to run APISIX test:

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1445496520 @Fabriceli Help me see what is left unfinished? There are some ci failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1442697485 @soulbird test case added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [apisix] dyrnq commented on pull request #8928: fix(consul): fix consul discovery only fetch healthy endpoint

dyrnq commented on PR #8928: URL: https://github.com/apache/apisix/pull/8928#issuecomment-1442680880 > Please add test cases Considering that this is a fix, there are some test case before this, can we use the previous test case? -- This is an automated message from the Ap