[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382 ## t/cli/plugin/test_file_logger_std_output.sh: ## @@ -0,0 +1,75 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382 ## t/cli/plugin/test_file_logger_std_output.sh: ## @@ -0,0 +1,75 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1071973979 ## apisix/plugins/file-logger.lua: ## @@ -14,23 +14,23 @@ -- See the License for the specific language governing permissions and -- limitations under the License. --

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1071039535 ## apisix/plugins/file-logger.lua: ## @@ -14,23 +14,23 @@ -- See the License for the specific language governing permissions and -- limitations under the License. --

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1070781054 ## apisix/plugins/file-logger.lua: ## @@ -138,10 +138,10 @@ local function write_file_data(conf, log_message) core.log.error("failed to write file: ",

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1070599704 ## apisix/plugins/file-logger.lua: ## @@ -136,6 +138,20 @@ local function write_file_data(conf, log_message) core.log.error("failed to write file: ",

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1070574570 ## apisix/plugins/file-logger.lua: ## @@ -136,6 +138,20 @@ local function write_file_data(conf, log_message) core.log.error("failed to write file: ",