[GitHub] [apisix] e1ijah1 commented on pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-28 Thread via GitHub
e1ijah1 commented on PR #8681: URL: https://github.com/apache/apisix/pull/8681#issuecomment-1407553999 @spacewander It looks like the connection to the ETCD in one environment is down, causing CI to fail. Would you mind restarting the CI and reviewing my code? -- This is an automated mes

[GitHub] [apisix] e1ijah1 commented on pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on PR #8681: URL: https://github.com/apache/apisix/pull/8681#issuecomment-1386421353 > Can you add a test in https://github.com/apache/apisix/tree/master/t/cli? The test has been added. Please take a look if you're available. @spacewander -- This is an automated

[GitHub] [apisix] e1ijah1 commented on pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-16 Thread GitBox
e1ijah1 commented on PR #8681: URL: https://github.com/apache/apisix/pull/8681#issuecomment-1383780787 > Can you add a test in https://github.com/apache/apisix/tree/master/t/cli? I'm not quite sure how to capture the standard output in E2E testing. Could you please give me some hints