[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-28 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-769547830 > > About the bug of `openresty-debug`, there are two suggestions: > > > > 1. Add conditions: when OpenResty version is not 1.19 , allow to use Lua 5.1 > > 2. Modify

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-27 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-768812660 @membphis @spacewander @tokers About run APISIX CLI, Luajit of OpenResty 1.19 is absolutely recommended. But In other cases, such as the bug of `opentesty-bug`, whether to

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-27 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-768764167 > @fukiki I think the title can be changed :), we only want to run APISIX CLI with LuaJIT. About the bug of openresty-debug, only using OpenResty 1.19 not Lua 5.1?

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-26 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-768098488 About the bug of `openresty-debug`, there are two suggestions: 1. Add conditions: when OpenResty version is not 1.19 , allow to use Lua 5.1 2. Modify document: introduce the

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-26 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-767441443 > > > please wait for more time, we'll try to find the bug and fix it. > > > It works fine with my computer :( > > > > > > @membphis It also works fine with my

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-26 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-767388890 > please wait for more time, we'll try to find the bug and fix it. > It works fine with my computer :( @membphis It also works fine with my computer, but failed in CI

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-25 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-766638650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-25 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-767231810 > can you revert your code to this version? > > ![image](https://user-images.githubusercontent.com/6814606/105726591-2e6a8300-5f65-11eb-8f51-7beca99fbbf3.png) This

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-25 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-766638650 About luajit path, I have a problem: There are different LUA_PATH, LUA_CPATH between lua and luajit, which `luarocks install` will be dependent on. Lua:

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-764519554 @membphis @tokers Please take a look when you have time. This is an automated message from the Apache Git

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-764519554 @membphis @tokers Please take a look when you have time. This is an automated message from the Apache Git

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-20 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-763470991 > can we put this file `bin/apisix.lua` to `apisix/cli`? `apisix.lua` is a part of cli, put it into `apisix/cli` will be better. Thanks. I will modify it.

[GitHub] [apisix] fukiki commented on pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-19 Thread GitBox
fukiki commented on pull request #3335: URL: https://github.com/apache/apisix/pull/3335#issuecomment-763380652 @membphis Could you review [commit 065a44](https://github.com/apache/apisix/pull/3335/commits/065a44e8166976333f0eaa9684157e00880e3881) for me? Thank you. By the way,