[GitHub] [apisix] gy09535 commented on pull request #2727: feat: Improve zipkin span reporter performance

2020-11-18 Thread GitBox
gy09535 commented on pull request #2727: URL: https://github.com/apache/apisix/pull/2727#issuecomment-729715738 > > For code style should we have some tools such vs code format config? > > I've been looking for it, but I didn't find a useful one. Got it.

[GitHub] [apisix] gy09535 commented on pull request #2727: feat: Improve zipkin span reporter performance

2020-11-17 Thread GitBox
gy09535 commented on pull request #2727: URL: https://github.com/apache/apisix/pull/2727#issuecomment-729452331 For code style should we has some tools such vs code format config? This is an automated message from the Apache

[GitHub] [apisix] gy09535 commented on pull request #2727: feat: Improve zipkin span reporter performance

2020-11-16 Thread GitBox
gy09535 commented on pull request #2727: URL: https://github.com/apache/apisix/pull/2727#issuecomment-727920569 Please confirm @moonming . This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] gy09535 commented on pull request #2727: feat: Improve zipkin span reporter performance

2020-11-15 Thread GitBox
gy09535 commented on pull request #2727: URL: https://github.com/apache/apisix/pull/2727#issuecomment-727695044 fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] gy09535 commented on pull request #2727: feat: Improve zipkin span reporter performance

2020-11-12 Thread GitBox
gy09535 commented on pull request #2727: URL: https://github.com/apache/apisix/pull/2727#issuecomment-726575429 > Please add some automated test cases. Added This is an automated message from the Apache Git Service.