[GitHub] [apisix] imjoey commented on pull request #2279: feat: Add labels for upstream object

2020-09-26 Thread GitBox
imjoey commented on pull request #2279: URL: https://github.com/apache/apisix/pull/2279#issuecomment-699594693 @membphis @nic-chen @gxthrj PR updated and any feedback would be much appreciated. This is an automated message

[GitHub] [apisix] imjoey commented on pull request #2279: feat: Add labels for upstream object

2020-09-23 Thread GitBox
imjoey commented on pull request #2279: URL: https://github.com/apache/apisix/pull/2279#issuecomment-697212801 > > > @imjoey One thing confuses me that the labels field is attached on the whole `upstream` object, It's closer to the labels on Kubernetes Service, not the Pod, and labels on P

[GitHub] [apisix] imjoey commented on pull request #2279: feat: Add labels for upstream object

2020-09-23 Thread GitBox
imjoey commented on pull request #2279: URL: https://github.com/apache/apisix/pull/2279#issuecomment-697208483 > This is a very interesting topic. > I hope to add labels to all objects in apisix, so that some strong bindings through `xxx_id` can be changed to loose binding relationships

[GitHub] [apisix] imjoey commented on pull request #2279: feat: Add labels for upstream object

2020-09-23 Thread GitBox
imjoey commented on pull request #2279: URL: https://github.com/apache/apisix/pull/2279#issuecomment-697196007 > @imjoey One thing confuses me that the labels field is attached on the whole `upstream` object, It's closer to the labels on Kubernetes Service, not the Pod, and labels on Pod a