[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809271644 > Thanks for your contribution. > However, we already have an ongoing PR: #3820 > > I take a first look at yours. Your implementation has namespaceId and groupName, and an

[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809848507 @spacewander @membphis Execuse me, why the checks stopped here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809864565 > GitHub action is not stable enough. Try to push a new commit again. It works. Thanks, ze xuan~ -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-30 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-810121182 @spacewander Excuse me, the nacos test case failed, because it could not find the nacos cluster. How could I complete this e2e test? It seems that I have to modify `config.yaml

[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-30 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-810660808 > Sorry for my rude behavior. But we **really really have an ongoing PR and this one won't be accepted**. > Your commits have created much noise in my notification inbox.