[GitHub] [apisix] jbampton commented on pull request #3247: feat: add basic EditorConfig file to help maintain consistent coding …

2021-03-27 Thread GitBox
jbampton commented on pull request #3247: URL: https://github.com/apache/apisix/pull/3247#issuecomment-808720531 Hello @Yiyiyimu I think we should get this one merged so people can start using it. We could stay with the current GitHub Actions or move to the GitHub Super Linter or pe

[GitHub] [apisix] jbampton commented on pull request #3247: feat: add basic EditorConfig file to help maintain consistent coding …

2021-01-14 Thread GitBox
jbampton commented on pull request #3247: URL: https://github.com/apache/apisix/pull/3247#issuecomment-760205521 Also you might want to know that a lot of the world's top projects use the EditorConfig standard seen here: https://github.com/editorconfig/editorconfig/wiki/Projects-Usin

[GitHub] [apisix] jbampton commented on pull request #3247: feat: add basic EditorConfig file to help maintain consistent coding …

2021-01-13 Thread GitBox
jbampton commented on pull request #3247: URL: https://github.com/apache/apisix/pull/3247#issuecomment-759981662 If the contributors don't care and don't install the EditorConfig plugin then it won't bother them. But most editors already provide support. Yes we can lint on the CI fo

[GitHub] [apisix] jbampton commented on pull request #3247: feat: add basic EditorConfig file to help maintain consistent coding …

2021-01-11 Thread GitBox
jbampton commented on pull request #3247: URL: https://github.com/apache/apisix/pull/3247#issuecomment-758423265 The EditorConfig file works with your editor. Most editors have support for it already. Basically it will `lint` the file that you have open in your editor automaticall