[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762595427 ## File path: apisix/cli/file.lua ## @@ -65,8 +65,15 @@ local function resolve_conf_var(conf) local var_used = false -- we use '

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762595417 ## File path: conf/config.yaml ## @@ -30,6 +30,16 @@ # And then run `export ETCD_HOST=$your_host` before `make init`. # # If the configured environment

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762595361 ## File path: t/cli/test_main.sh ## @@ -310,6 +310,45 @@ fi echo "pass: support environment variables in local_conf" +# should use default value when

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762531135 ## File path: apisix/cli/file.lua ## @@ -65,8 +65,15 @@ local function resolve_conf_var(conf) local var_used = false -- we use '

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762530881 ## File path: conf/config.yaml ## @@ -30,6 +30,16 @@ # And then run `export ETCD_HOST=$your_host` before `make init`. # # If the configured environment

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r761728930 ## File path: t/cli/test_main.sh ## @@ -310,6 +310,35 @@ fi echo "pass: support environment variables in local_conf" +# support default value when en

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r761670480 ## File path: t/cli/test_main.sh ## @@ -310,6 +310,35 @@ fi echo "pass: support environment variables in local_conf" +# support default value when en

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r761625354 ## File path: apisix/cli/file.lua ## @@ -65,8 +65,15 @@ local function resolve_conf_var(conf) local var_used = false -- we use '

[GitHub] [apisix] kevinw66 commented on a change in pull request #5675: feat: support resolve default value when environment not set

kevinw66 commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r761621281 ## File path: apisix/cli/file.lua ## @@ -65,8 +65,15 @@ local function resolve_conf_var(conf) local var_used = false -- we use '