[GitHub] [apisix] membphis commented on a change in pull request #1989: Fixed discovery weight bug

2020-08-12 Thread GitBox
membphis commented on a change in pull request #1989: URL: https://github.com/apache/apisix/pull/1989#discussion_r469394676 ## File path: t/discovery/eureka-weight.t ## @@ -0,0 +1,168 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor lic

[GitHub] [apisix] membphis commented on a change in pull request #1989: Fixed discovery weight bug

2020-08-10 Thread GitBox
membphis commented on a change in pull request #1989: URL: https://github.com/apache/apisix/pull/1989#discussion_r467839154 ## File path: t/discovery/eureka-weight.t ## @@ -0,0 +1,168 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor lic

[GitHub] [apisix] membphis commented on a change in pull request #1989: Fixed discovery weight bug

2020-08-08 Thread GitBox
membphis commented on a change in pull request #1989: URL: https://github.com/apache/apisix/pull/1989#discussion_r467521066 ## File path: apisix/discovery/eureka.lua ## @@ -203,16 +205,18 @@ local function fetch_full_registry(premature) nodes = core.table.n

[GitHub] [apisix] membphis commented on a change in pull request #1989: Fixed discovery weight bug

2020-08-08 Thread GitBox
membphis commented on a change in pull request #1989: URL: https://github.com/apache/apisix/pull/1989#discussion_r467448661 ## File path: apisix/discovery/eureka.lua ## @@ -203,16 +205,18 @@ local function fetch_full_registry(premature) nodes = core.table.n

[GitHub] [apisix] membphis commented on a change in pull request #1989: Fixed discovery weight bug

2020-08-08 Thread GitBox
membphis commented on a change in pull request #1989: URL: https://github.com/apache/apisix/pull/1989#discussion_r467447927 ## File path: apisix/discovery/eureka.lua ## @@ -203,16 +205,18 @@ local function fetch_full_registry(premature) nodes = core.table.n

[GitHub] [apisix] membphis commented on a change in pull request #1989: Fixed discovery weight bug

2020-08-06 Thread GitBox
membphis commented on a change in pull request #1989: URL: https://github.com/apache/apisix/pull/1989#discussion_r466351129 ## File path: apisix/discovery/eureka.lua ## @@ -34,6 +35,8 @@ local log= core.log local default_weight local applications + + Review