membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-693429050
@Yiyiyimu you can create a new Github issue if you find some other things.
this PR has been merged, we should use the new issue to resolve the problem.
--
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-692411184
> one more thing, we need to check the `etcd` version in `bin/apisix`,
confirm the `etcd` version `>= 3.4` .
we can fix this in a new PR, here is the related issue:
https
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-691957197
one more thing, we need to check the `etcd` version in `bin/apisix`, confirm
the `etcd` version `>= 3.4` .
This
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680972604
> @membphis it seems I could not directly reply in your comment on "etcd v2
version".
> The original implementation should directly use the version detection in
lua-resty-etc
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-680969971
@Yiyiyimu that is another problem. you can take a look at the doc of
lua-nginx-module:
https://github.com/openresty/lua-nginx-module#cosockets-not-available-everywhere
---
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-678748139
> I think we should create a new branch that using etcd v2 before the
merge,and maintain it for a while,for the users who can’t migrate to etcd v
I have created a new bran
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-678647597
I think we can merge this PR at next week.
This is an automated message from the Apache Git Service.
To respond
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-674666089
> Is there any reason that could cause the difference? Or the default
benchmark test is not suitable for this change
I think you need to check the error log first for conf
membphis commented on pull request #2036:
URL: https://github.com/apache/apisix/pull/2036#issuecomment-672938803
> I make a default benchmark test on my local PC, it seems that deploying
etcd v3 could improve performance quite a lot
Use v3 or v2 protocol, their test results should be
