[GitHub] [apisix] moonming commented on a change in pull request #2121: fix: limit count config not effective

2020-08-31 Thread GitBox
moonming commented on a change in pull request #2121: URL: https://github.com/apache/apisix/pull/2121#discussion_r479986030 ## File path: apisix/plugin.lua ## @@ -297,6 +297,7 @@ local function merge_service_route(service_conf, route_conf) local new_conf =

[GitHub] [apisix] moonming commented on a change in pull request #2121: fix: limit count config not effective

2020-08-31 Thread GitBox
moonming commented on a change in pull request #2121: URL: https://github.com/apache/apisix/pull/2121#discussion_r479962776 ## File path: apisix/plugin.lua ## @@ -332,7 +333,8 @@ function _M.merge_service_route(service_conf, route_conf) core.log.info("service conf: ",

[GitHub] [apisix] moonming commented on a change in pull request #2121: fix: limit count config not effective

2020-08-31 Thread GitBox
moonming commented on a change in pull request #2121: URL: https://github.com/apache/apisix/pull/2121#discussion_r479962013 ## File path: apisix/init.lua ## @@ -361,21 +361,11 @@ function _M.http_access_phase() return core.response.exit(404) end -