[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-04-18 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r615513972 ## File path: t/error_handler/error_handler.t ## @@ -0,0 +1,214 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-04-18 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r615512328 ## File path: t/error_handler/error_handler.t ## @@ -0,0 +1,214 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-04-18 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r615494330 ## File path: t/error_handler/error_handler.t ## @@ -0,0 +1,214 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-04-18 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r615492580 ## File path: apisix/error_handler.lua ## @@ -0,0 +1,78 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor lice

[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-03-29 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r603767827 ## File path: apisix/error_handler.lua ## @@ -0,0 +1,54 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor lice

[GitHub] [apisix] moonming commented on a change in pull request #3883: feat: add 5xx error page

2021-03-29 Thread GitBox
moonming commented on a change in pull request #3883: URL: https://github.com/apache/apisix/pull/3883#discussion_r603766958 ## File path: apisix/cli/ngx_tpl.lua ## @@ -233,6 +233,9 @@ http { {% end %} {% end %} +# error_page +error_page 500 502 503 504 @apis