[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

2020-08-11 Thread GitBox
moonming commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-672423902 @membphis please take a look, and I think we need more test cases, WDYT? This is an automated message from the A

[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

2020-08-11 Thread GitBox
moonming commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-672426400 @redynasc For the code of other projects, we cannot add ASF header, please take a look at https://github.com/apache/skywalking/blob/master/LICENSE#L204, which is the correct way

[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

2020-08-16 Thread GitBox
moonming commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-674489669 @redynasc ping This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

2020-08-19 Thread GitBox
moonming commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-676015427 @redynasc any update? This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

2020-08-26 Thread GitBox
moonming commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-680748038 the license issue is not fixed, which is MUST fixed before next release. This is an automated message from the A

[GitHub] [apisix] moonming commented on pull request #2001: add ewma balancer

2020-08-26 Thread GitBox
moonming commented on pull request #2001: URL: https://github.com/apache/apisix/pull/2001#issuecomment-681348703 I will help to fix license issue after this PR merged. Thanks, Ming Wen Twitter: _WenMing redynasc 于2020年8月27日周四 上午10:52写道: > the license issue is