[GitHub] [apisix] moonming commented on pull request #2121: bugfix: updated the value of remaining when `count` changes in limit-count plugin.

Mon, 31 Aug 2020 05:56:37 -0700 


moonming commented on pull request #2121:
URL: https://github.com/apache/apisix/pull/2121#issuecomment-683760175


   ```
   #   Failed test 'TEST 1: log rotate - response_body_like - response is 
expected (2020-08-31_10-25-32__access.log 2020-08-31_10-25-31__access.log 
2020-08-31_10-25-33__access.log . 2020-08-31_10-25-32__error.log error.log 
2020-08-31_10-25-33__error.log access.log 2020-08-31_10-25-31__error.log .. 
nginx.pid)'
   #   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm 
line 1635.
   #                   '2020-08-31_10-25-32__access.log
   # 2020-08-31_10-25-31__access.log
   # 2020-08-31_10-25-33__access.log
   # .
   # 2020-08-31_10-25-32__error.log
   # error.log
   # 2020-08-31_10-25-33__error.log
   # access.log
   # 2020-08-31_10-25-31__error.log
   # ..
   # nginx.pid
   # '
   #     doesn't match '(?^:\_error\.log[\s\S]*\_access\.log)'
   # Looks like you failed 1 test of 7.
   t/plugin/log-rotate.t .................... 
   ```
   @membphis please take a look this failed test case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to