[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191

2020-09-13 Thread GitBox
moonming commented on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-691795888 > thx, it will be better if you can add test cases. ping @dickens7 This is an automated message from the

[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191

2020-09-10 Thread GitBox
moonming commented on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-690119857 thx, it will be better if you can add test cases. This is an automated message from the Apache Git Service. To r

[GitHub] [apisix] moonming commented on pull request #2193: fixed #2191

2020-09-09 Thread GitBox
moonming commented on pull request #2193: URL: https://github.com/apache/apisix/pull/2193#issuecomment-689408350 ``` apisix/plugins/zipkin/codec.lua:41:13: value assigned to variable sample is unused ``` please remove `sample` variable, thx ---