[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

2020-09-15 Thread GitBox
moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692515133 YOUR_OWN_API_TOKEN Thanks, Ming Wen Twitter: _WenMing YuanSheng Wang 于2020年9月15日周二 下午3:09写道: > *@membphis* commented on this pull request. > ---

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

2020-09-15 Thread GitBox
moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692515707 I insist on this, if automatic generation token is not possible, I would rather not remove the default token Thanks, Ming Wen Twitter: _WenMing YuanShen

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

2020-09-15 Thread GitBox
moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692518089 why `**` is invalid? Is this hard-coded in the code? Thanks, Ming Wen Twitter: _WenMing YuanSheng Wang 于2020年9月15日周二 下午3:15写道: > YOUR_OWN_API_T

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

2020-09-15 Thread GitBox
moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692560517 No, `YOUR_OWN_API_TOKEN` is just hint in doc, not api token itself. Thanks, Ming Wen Twitter: _WenMing YuanSheng Wang 于2020年9月15日周二 下午4:29写道: > *@m

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

2020-09-16 Thread GitBox
moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-693237220 I don't think so, `YOUR_OWN_API_TOKEN` is good as hint, not the real token. we can keep the current token Th

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

2020-09-16 Thread GitBox
moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-693734871 In this pr, we only need to modify one file, and only need to make one change, which is to print a warning when the Admin IP is not 127.0.0.1 and using default token