[GitHub] [apisix] nic-chen commented on a change in pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

2020-09-17 Thread GitBox
nic-chen commented on a change in pull request #2239: URL: https://github.com/apache/apisix/pull/2239#discussion_r490192846 ## File path: apisix/plugins/hmac-auth.lua ## @@ -182,13 +201,25 @@ local function generate_signature(ctx, secret_key, params)

[GitHub] [apisix] nic-chen commented on a change in pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

2020-09-17 Thread GitBox
nic-chen commented on a change in pull request #2239: URL: https://github.com/apache/apisix/pull/2239#discussion_r490010272 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -41,6 +41,8 @@ | `secret_key`| 必须 | 无 | 与 `access_key` 配对使用。| | `algorithm` | 可选 | hmac-sha256 |

[GitHub] [apisix] nic-chen commented on a change in pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

2020-09-16 Thread GitBox
nic-chen commented on a change in pull request #2239: URL: https://github.com/apache/apisix/pull/2239#discussion_r489911418 ## File path: apisix/plugins/hmac-auth.lua ## @@ -52,16 +58,19 @@ local schema = { clock_skew = { type = "integer",