[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r573420343 ## File path: conf/config-default.yaml ## @@ -89,6 +89,8 @@ apisix: role: viewer delete_uri_tail_slash: false# delete the '/' at the end

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r573383937 ## File path: conf/config-default.yaml ## @@ -89,6 +89,8 @@ apisix: role: viewer delete_uri_tail_slash: false# delete the '/' at the end

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r572888199 ## File path: apisix/init.lua ## @@ -325,8 +325,29 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r563292590 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562625641 ## File path: t/node/global-rule.t ## @@ -120,7 +120,34 @@ GET /hello -=== TEST 6: delete global rule +=== TEST 6: not limited +--- request +GET

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562624813 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562488874 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =