[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1089925057 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1089900189 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068429 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1067936534 ## apisix/plugins/jwt-auth.lua: ## @@ -277,29 +259,13 @@ local function get_rsa_or_ecdsa_keypair(conf, consumer_name) -- if keys are present in conf,