[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions

shuaijinchao commented on a change in pull request #5715: URL: https://github.com/apache/apisix/pull/5715#discussion_r763780260 ## File path: apisix/plugins/log-rotate.lua ## @@ -194,18 +231,33 @@ local function rotate() core.log.info("rotate interval:", interval) cor

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions

shuaijinchao commented on a change in pull request #5715: URL: https://github.com/apache/apisix/pull/5715#discussion_r763780260 ## File path: apisix/plugins/log-rotate.lua ## @@ -194,18 +231,33 @@ local function rotate() core.log.info("rotate interval:", interval) cor

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions

shuaijinchao commented on a change in pull request #5715: URL: https://github.com/apache/apisix/pull/5715#discussion_r763696459 ## File path: apisix/plugins/log-rotate.lua ## @@ -194,18 +231,33 @@ local function rotate() core.log.info("rotate interval:", interval) cor

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions

shuaijinchao commented on a change in pull request #5715: URL: https://github.com/apache/apisix/pull/5715#discussion_r763689392 ## File path: apisix/plugins/log-rotate.lua ## @@ -194,18 +231,33 @@ local function rotate() core.log.info("rotate interval:", interval) cor

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions

shuaijinchao commented on a change in pull request #5715: URL: https://github.com/apache/apisix/pull/5715#discussion_r763689392 ## File path: apisix/plugins/log-rotate.lua ## @@ -194,18 +231,33 @@ local function rotate() core.log.info("rotate interval:", interval) cor

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5715: fix(log-rotate): after enabling compression collect log exceptions

shuaijinchao commented on a change in pull request #5715: URL: https://github.com/apache/apisix/pull/5715#discussion_r763597332 ## File path: apisix/plugins/log-rotate.lua ## @@ -181,6 +151,70 @@ local function scan_log_folder() end +local function rename_file(log, date_st