soham4abc commented on pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#issuecomment-1039272826
Thank you everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
soham4abc commented on pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#issuecomment-1039272826
Thank you everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
soham4abc commented on pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#issuecomment-1033774171
Thanks a lot @tzssangglass and @bisakhmondal For guiding me in this issue!
--
This is an automated message from the Apache Git Service.
To respond to the message,
soham4abc commented on pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#issuecomment-1030825353
> Adding a test for it is easy. Could you follow @bisakhmondal 's guide to
add a test?
> A test is required to prevent regression.
Sure... Just might take some time!
soham4abc commented on pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#issuecomment-1030762769
Any issues? @bisakhmondal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
soham4abc commented on pull request #6242:
URL: https://github.com/apache/apisix/pull/6242#issuecomment-1029193478
> > @bisakhmondal Could you help @soham4abc to add a test for it?
>
> Yes sure. @soham4abc we use test-nginx in APISIX for testing. You can find
the docs here
