[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2023-01-11 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1067040193 ## apisix/admin/kms.lua: ## @@ -0,0 +1,203 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NO

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2023-01-11 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1067038996 ## apisix/admin/kms.lua: ## @@ -0,0 +1,203 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NO

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2022-11-28 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1034263159 ## docs/en/latest/admin-api.md: ## @@ -1119,3 +1120,65 @@ Route used in the [Stream Proxy](./stream-proxy.md). To learn more about filtering in stream proxies, check

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2022-11-27 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1033055981 ## apisix/constants.lua: ## @@ -33,6 +33,7 @@ return { ["/protos"] = true, ["/plugin_configs"] = true, ["/consumer_groups"] = true, +

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2022-11-24 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1031940650 ## t/admin/kms.t: ## @@ -0,0 +1,192 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2022-11-24 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1031940451 ## apisix/schema_def.lua: ## @@ -692,6 +692,23 @@ _M.service = { } +_M.vault = { Review Comment: Use `kms_vault`. -- This is an automated message from the

[GitHub] [apisix] soulbird commented on a diff in pull request #8394: feat(admin): add kms admin api

2022-11-24 Thread GitBox
soulbird commented on code in PR #8394: URL: https://github.com/apache/apisix/pull/8394#discussion_r1031938164 ## apisix/schema_def.lua: ## @@ -692,6 +692,23 @@ _M.service = { } +_M.vault = { +type = "object", +properties = { +uri = { +type = "st