[GitHub] [apisix] soulbird commented on pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

soulbird commented on PR #8660: URL: https://github.com/apache/apisix/pull/8660#issuecomment-1384865994 Vault related links in this chapter should be updated https://github.com/apache/apisix/blob/master/docs/en/latest/getting-started.md#features https://github.com/apache/apisix/blob/mast

[GitHub] [apisix] soulbird commented on pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

soulbird commented on PR #8660: URL: https://github.com/apache/apisix/pull/8660#issuecomment-1384782519 > How should [this](https://github.com/apache/apisix/blob/master/apisix/plugins/jwt-auth.lua#L164-L165) be handled? > > https://user-images.githubusercontent.com/61597896/212726256

[GitHub] [apisix] soulbird commented on pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

soulbird commented on PR #8660: URL: https://github.com/apache/apisix/pull/8660#issuecomment-1384773382 A link should be added after the field, pointing to APISIX Secret -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] soulbird commented on pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

soulbird commented on PR #8660: URL: https://github.com/apache/apisix/pull/8660#issuecomment-1379823150 Should also update doc： https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/jwt-auth.md If you are interested, you can update the Chinese documentation at the same