[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-14 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557291411 ## File path: apisix/admin/upstreams.lua ## @@ -45,6 +45,10 @@ local function get_chash_key_schema(hash_on) return nil, nil end +

[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557099723 ## File path: apisix/balancer/chash.lua ## @@ -39,8 +39,10 @@ local function fetch_chash_hash_key(ctx, upstream) elseif hash_on == "cookie" then

[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557081297 ## File path: apisix/balancer/chash.lua ## @@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream) chash_key = ctx.var["http_"

[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557052944 ## File path: apisix/balancer/chash.lua ## @@ -38,6 +38,9 @@ local function fetch_chash_hash_key(ctx, upstream) chash_key = ctx.var["http_"

[GitHub] [apisix] spacewander commented on a change in pull request #3278: feat: support hash on vars_combinations

2021-01-13 Thread GitBox
spacewander commented on a change in pull request #3278: URL: https://github.com/apache/apisix/pull/3278#discussion_r557028364 ## File path: t/node/chash-hashon.t ## @@ -625,3 +625,90 @@ chash_key: "chash_val_3" chash_key: "chash_val_4" chash_key: "chash_val_5" chash_key: