spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r596598466
##
File path: docs/en/latest/discovery/nacos.md
##
@@ -0,0 +1,93 @@
+---
+title: nacos
+---
+
+
+
+### Configuration for Nacos
+
+Add following configu
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r597362835
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,237 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r599433211
##
File path: docs/en/latest/discovery/nacos.md
##
@@ -0,0 +1,95 @@
+---
+title: nacos
+---
+
+
+
+### Configuration for Nacos
+
+Add following configu
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r600110250
##
File path: t/discovery/nacos.t
##
@@ -0,0 +1,125 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r600111763
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,285 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602173854
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602663539
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r602672250
##
File path: .travis/linux_tengine_runner.sh
##
@@ -40,6 +40,9 @@ before_install() {
# start consul servers
docker run --rm --name consul_1
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603167933
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603173738
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603719667
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603719667
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r603879135
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r604533670
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,324 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r605413510
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,326 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r605524014
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,316 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r606041056
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,316 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r606045390
##
File path: apisix/discovery/nacos.lua
##
@@ -278,9 +278,13 @@ end
function _M.nodes(service_name)
-while( not applications )
+local log
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609287508
##
File path: t/discovery/nacos.t
##
@@ -0,0 +1,152 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609308381
##
File path: t/discovery/nacos.t
##
@@ -0,0 +1,152 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609411973
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,322 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609413111
##
File path: .github/workflows/centos7-ci.yml
##
@@ -101,6 +101,37 @@ jobs:
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609413722
##
File path: .github/workflows/centos7-ci.yml
##
@@ -101,6 +101,37 @@ jobs:
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609595479
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,322 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609596820
##
File path: .github/workflows/centos7-ci.yml
##
@@ -101,6 +101,37 @@ jobs:
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r609596820
##
File path: .github/workflows/centos7-ci.yml
##
@@ -101,6 +101,37 @@ jobs:
docker run --rm --name consul_1 -d -p 8500:8500 consul:1.7 consul
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r615639810
##
File path: apisix/discovery/nacos.lua
##
@@ -0,0 +1,306 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributo
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r615681419
##
File path: apisix/discovery/nacos.lua
##
@@ -182,47 +179,47 @@ local function get_base_uri()
end
-local function get_page_service(infos, base_u
spacewander commented on a change in pull request #3820:
URL: https://github.com/apache/apisix/pull/3820#discussion_r615685716
##
File path: apisix/discovery/nacos.lua
##
@@ -275,41 +273,33 @@ end
function _M.nodes(service_name)
-local logged = false
Review comment:
29 matches
Mail list logo