[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set

2021-12-05 Thread GitBox
spacewander commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762550646 ## File path: apisix/cli/file.lua ## @@ -65,8 +65,15 @@ local function resolve_conf_var(conf) local var_used = false -- we us

[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set

2021-12-05 Thread GitBox
spacewander commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762550515 ## File path: conf/config.yaml ## @@ -30,6 +30,16 @@ # And then run `export ETCD_HOST=$your_host` before `make init`. # # If the configured environm

[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set

2021-12-04 Thread GitBox
spacewander commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762511289 ## File path: apisix/cli/file.lua ## @@ -65,8 +65,15 @@ local function resolve_conf_var(conf) local var_used = false -- we us

[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set

2021-12-04 Thread GitBox
spacewander commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r762511228 ## File path: conf/config.yaml ## @@ -30,6 +30,16 @@ # And then run `export ETCD_HOST=$your_host` before `make init`. # # If the configured environm

[GitHub] [apisix] spacewander commented on a change in pull request #5675: feat: support resolve default value when environment not set

2021-12-02 Thread GitBox
spacewander commented on a change in pull request #5675: URL: https://github.com/apache/apisix/pull/5675#discussion_r761596029 ## File path: apisix/cli/file.lua ## @@ -65,8 +65,15 @@ local function resolve_conf_var(conf) local var_used = false -- we us