[GitHub] [apisix] spacewander commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-27 Thread via GitHub
spacewander commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1089581139 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key = conf.public_key

[GitHub] [apisix] spacewander commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
spacewander commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073050987 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key = conf.public_key